summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* wintest: fixed syntax highlighting with emacsAndrew Tridgell2011-03-291-1/+1
|
* wintest: ensure we startup the w2k3 DC VMAndrew Tridgell2011-03-291-0/+1
| | | | Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
* Be a little clearer about when and when not to set this option.Jeremy Allison2011-03-281-4/+8
| | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Mon Mar 28 23:59:47 CEST 2011 on sn-devel-104
* Fix inspired by work done by David Disseldorp for bug #8040 - smbclient ↵Jeremy Allison2011-03-287-26/+73
| | | | | | | | | segfaults when a Cyrillic netbios name or workgroup is configured. Change msrpc_gen to return NTSTATUS and ensure everywhere this is used it is correctly checked to return that status. Jeremy.
* s3: Fix Coverity ID 2143: DEADCODEVolker Lendecke2011-03-281-4/+0
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Mar 28 12:06:19 CEST 2011 on sn-devel-104
* s3: Fix Coverity ID 2143: DEADCODEVolker Lendecke2011-03-281-4/+0
|
* s3: Fix Coverity ID 2173: FORWARD_NULLVolker Lendecke2011-03-281-1/+1
|
* Revert "Change strict allocate to default to true.Stefan Metzmacher2011-03-282-7/+6
| | | | | | | | | | | | | | | This reverts commit ecf48af135e4c1ebc5aafe4b3dad785162f5949a. This makes Samba unusable on systems without Linux and a modern Filesystem. This was discussed with Jeremy on IRC: http://irclog.samba.org/2011/01/20110126-Wed.log metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Mar 28 09:00:09 CEST 2011 on sn-devel-104
* s3: Fix Coverity ID 2188: MISSING_BREAKVolker Lendecke2011-03-271-0/+2
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 23:11:10 CEST 2011 on sn-devel-104
* s3: Fix Coverity ID 2189: MISSING_BREAKVolker Lendecke2011-03-271-1/+3
|
* tdb: Fix Coverity ID 2192: NO_EFFECTVolker Lendecke2011-03-271-1/+1
| | | | (ret < 0) can never be true
* s3: Fix Coverity ID 2195: NO_EFFECTVolker Lendecke2011-03-271-1/+1
| | | | level is unsigned
* librpc: Add some error checking to dcerpc_floor_pack_rhs_if_version_dataVolker Lendecke2011-03-271-1/+5
|
* librpc: Fix Coverity ID 2198: NULL_RETURNSVolker Lendecke2011-03-271-3/+14
|
* s3: Fix Coverity ID 2200: NULL_RETURNS (cut&paste error)Volker Lendecke2011-03-271-1/+1
|
* s3: Fix Coverity ID 2228: RESOURCE_LEAKVolker Lendecke2011-03-271-0/+1
| | | | Holger, please check!
* s3: Fix Coverity ID 2226: RESOURCE_LEAKVolker Lendecke2011-03-271-0/+1
| | | | Holger, please check!
* s3: Fix Coverity ID 976: BAD_SIZEOFVolker Lendecke2011-03-271-1/+1
|
* s3: Fix Coverity ID 958: BAD_SIZEOFVolker Lendecke2011-03-271-1/+1
| | | | | | This is supposed to wipe out the md5 context, not only the first bytes of it. Others, please check!
* s3: Fix Coverity ID 682: NEGATIVE_RETURNSVolker Lendecke2011-03-271-1/+4
|
* s3: Fix Coverity ID 590: DEADCODEVolker Lendecke2011-03-271-4/+0
|
* s3: Fix Coverity ID 585: NEGATIVE_RETURNSVolker Lendecke2011-03-271-1/+1
|
* s3: Fix Coverity ID 513: UNINITVolker Lendecke2011-03-271-1/+1
|
* s3: Fix Coverity ID 83: RESOURCE_LEAKVolker Lendecke2011-03-271-0/+3
|
* s3: Convert cli_raw_tcon to cli_smbVolker Lendecke2011-03-272-26/+24
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 19:50:21 CEST 2011 on sn-devel-104
* s3: Fix a memleakVolker Lendecke2011-03-271-0/+2
|
* s3: Replace a use of cli_errstrVolker Lendecke2011-03-271-1/+1
|
* s3: Replace cli_negprot_sendsync() by cli_negprot_send()Volker Lendecke2011-03-273-38/+22
|
* s3: Remove a pointless staticVolker Lendecke2011-03-271-1/+1
|
* s3: Remove a use of cli_send_smbVolker Lendecke2011-03-273-39/+50
|
* s3: Remove two calls to cli_errstrVolker Lendecke2011-03-271-4/+8
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 13:17:47 CEST 2011 on sn-devel-104
* s3: Fix Coverity ID 2296: UNUSED_VALUEVolker Lendecke2011-03-271-3/+0
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 12:12:35 CEST 2011 on sn-devel-104
* s3: Fix Coverity ID 2327: FORWARD_NULLVolker Lendecke2011-03-271-0/+2
| | | | | | Make check_ft_info robust against an invalid type. Günther, please check!
* s3: Fix Coverity ID 2328: FORWARD_NULLVolker Lendecke2011-03-271-0/+3
| | | | Make startsmbfilepwent robust against an invalid open type
* s3: Fix Coverity ID 2329: RESOURCE_LEAKVolker Lendecke2011-03-271-0/+1
|
* s3: Fix Coverity ID 2330: RESOURCE_LEAKVolker Lendecke2011-03-271-0/+1
|
* s3: Fix Coverity ID 2331: RESOURCE_LEAKVolker Lendecke2011-03-271-0/+1
|
* s3: Fix an uninitialized variable readVolker Lendecke2011-03-261-1/+2
| | | | | | | | | | The "is_valid_policy_handle" in the exit path reads uninitialized data Lets see if this fixes Coverity ID 2172 which complains about h being dereferenced in the dcerpc_winreg_CloseKey. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sat Mar 26 14:24:28 CET 2011 on sn-devel-104
* s3: Fix Coverity ID 2326, CHECKED_RETURNVolker Lendecke2011-03-261-1/+1
|
* Revert "Fix bug 8021 - Incorrect string termination in volume/volume_name ↵Jeremy Allison2011-03-261-1/+1
| | | | | | | | | | | | | | for TRANS2-QUERY_FS_INFO/Info Volume." This reverts commit 042aafb87df6c05877b8fc7ef0d44877689d860a. I need to test against OS/2 to see if this is something Win28K breaks for older clients before allowing this. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Mar 26 01:19:55 CET 2011 on sn-devel-104
* Fix bug 8040 - smbclient segfaults when a Cyrillic netbios name or workgroup ↵Jeremy Allison2011-03-251-2/+23
| | | | | | | | | | | | | | | | | | | | | | | is configured. As discovered by David Disseldorp <ddiss@suse.de>, convert_string_talloc() doesn't always return consistent results for a zero length string. The API states an incoming string must *always* contain the terminating null, but unfotunately too much code expects passing in a zero source length to return a null terminated string, so at least ensure we return a correct null string in the required character set and return the correct length. Also ensure we cannot return a zero length for a converted string (we ensure that the returned buffer is always allocated and zero terminated anyway) as calling code depends on the fact that returning true from this function will *always* return a non-zero length (as it must include the terminating null). Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Mar 25 23:25:40 CET 2011 on sn-devel-104
* s3-netapi: fix memoryleak while not using talloc_tos() in ↵Günther Deschner2011-03-252-6/+6
| | | | | | | | | | | cli_get_session_key() usage. Thanks Volker! Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Mar 25 18:21:18 CET 2011 on sn-devel-104
* s3: Compile IDL files in autogen, some configure tests need thisVolker Lendecke2011-03-252-0/+12
| | | | | Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Mar 25 16:35:30 CET 2011 on sn-devel-104
* Revert "s3-includes: fixed CONST_DISCARD() to actually discard const"Volker Lendecke2011-03-251-1/+1
| | | | | | | | | | | | | | This reverts commit 37261928bec145f4cbd85f3e409063563c00ac9e. In source3 this creates a warning of the form passdb/pdb_ldap.c:4565: warning: passing argument 2 of ‘pull_utf8_talloc’ from incompatible pointer type include/proto.h:444: note: expected ‘char **’ but argument is of type ‘char ***’ for every use of CONST_DISCARD. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Mar 25 13:16:35 CET 2011 on sn-devel-104
* charcnv: ensure convert_string_error doesn't conflict with s3 functionAndrew Tridgell2011-03-251-5/+5
| | | | | | | | | use _handle for handle based functions Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Fri Mar 25 05:22:24 CET 2011 on sn-devel-104
* s3-charcnv: fixed converted_size return in fast pathsAndrew Tridgell2011-03-251-9/+20
|
* s3-charcnv: removed unused functionAndrew Tridgell2011-03-252-8/+0
| | | | lp_failed_convert_char() is not needed any more
* lib/util/charset rename iconv_convenience to iconv_handleAndrew Bartlett2011-03-2515-108/+108
| | | | | | This better reflects what this structure is Andrew Bartlett
* s3-charcnv: convert_string_internal() should not display errorsAndrew Tridgell2011-03-251-31/+4
| | | | debug error display happens in the convert_string() outer function
* s3-string: removed the conv_silent globalAndrew Tridgell2011-03-251-29/+17
| | | | | | use convert_string_error() instead Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>