summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* dcerpc.idl: make use of dcerpc_bind_ack_resultStefan Metzmacher2014-01-161-1/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* dcerpc.idl: add enums and bitmaps for dcerpc_bind_ack_result, ↵Stefan Metzmacher2014-01-161-4/+44
| | | | | | | dcerpc_bind_[ack|nak]_reason Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* dcerpc.idl: add a bitmap for dcerpc_pfc_flagsStefan Metzmacher2014-01-161-9/+16
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* dcerpc.idl: use logical dcerpc_object orderingDavid Disseldorp2014-01-161-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This IDL code: typedef [nodiscriminant] union { [default] dcerpc_empty empty; [case(LIBNDR_FLAG_OBJECT_PRESENT)] GUID object; } dcerpc_object; Compiles into the following default-before-case marshalling code: switch (level) { default: { NDR_CHECK(ndr_push_dcerpc_empty(ndr, NDR_SCALARS, &r->empty)); break; } case LIBNDR_FLAG_OBJECT_PRESENT: { NDR_CHECK(ndr_push_GUID(ndr, NDR_SCALARS, &r->object)); break; } } The default entry before case does not change the flow of execution but is more logical when present at the end of the switch statement. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* s4:torture/libnet: fix compiler warnings in libnet_lookup.cStefan Metzmacher2014-01-161-0/+1
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/libnet: check the result of libnet_LookupName()Stefan Metzmacher2014-01-161-1/+5
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: remove compiler warnings in ntsvcs.cStefan Metzmacher2014-01-161-9/+8
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: remove compiler warnings in spoolss_notify.cStefan Metzmacher2014-01-161-1/+4
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: s/pipe/pipes/Stefan Metzmacher2014-01-161-4/+4
| | | | | | | pipe(2) is a system call. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: remove unused variables from alter_context.cStefan Metzmacher2014-01-161-5/+0
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3:rpcclient: remove unused code from cmd_lsa_get_username()Stefan Metzmacher2014-01-161-10/+0
| | | | | | | lsa_GetUserName() doesn't require a policy handle. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3:rpcclient: add support for DCERPC_AUTH_LEVEL_CONNECTStefan Metzmacher2014-01-162-21/+11
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:librpc: remove dcerpc_event_context()Stefan Metzmacher2014-01-162-15/+3
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: avoid using dcerpc_event_context()Stefan Metzmacher2014-01-162-4/+2
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/rpc: avoid usage of p->conn->event_ctxStefan Metzmacher2014-01-161-1/+1
| | | | | | | | | | | torture_suite_add_rpc_iface_tcase() uses tctx->ev, which means p->conn->event_ctx and tctx->ev are the same. As we want to get rid of per connection tevent_context pointers, we should use tctx->ev. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:torture/libnet: remove bogus usage of p->conn->event_ctxStefan Metzmacher2014-01-161-7/+0
| | | | | | | | ctx->event_ctx and p->conn->event_ctx already have the same value as torture->ev. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:winbind: let wb_samr_userdomgroups_send() take ↵Stefan Metzmacher2014-01-162-9/+11
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:winbind: let wb_lsa_lookupnames_send() take ↵Stefan Metzmacher2014-01-162-6/+7
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:winbind: let wb_lsa_lookupsids_send() take ↵Stefan Metzmacher2014-01-163-6/+8
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:winbind: make clear that we use the global tevent_contextStefan Metzmacher2014-01-164-2/+8
| | | | | | | | | We should avoid using the tevent_context pointer on a dcecli_connection, it's the same as the global per task one anyway. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:winbind: correctly fill the libnet_context lsa and samr binding handlesStefan Metzmacher2014-01-161-0/+6
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_usermod() take tevent_context/dcerpc_binding_handleStefan Metzmacher2014-01-162-4/+4
| | | | | | | This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_usermod_send() take ↵Stefan Metzmacher2014-01-162-12/+16
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_userdel() take tevent_context/dcerpc_binding_handleStefan Metzmacher2014-01-162-4/+6
| | | | | | | This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_userdel_send() take ↵Stefan Metzmacher2014-01-162-11/+17
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_useradd() take tevent_context/dcerpc_binding_handleStefan Metzmacher2014-01-162-4/+4
| | | | | | | This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_useradd_send() take ↵Stefan Metzmacher2014-01-163-11/+18
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_userinfo() take tevent_context/dcerpc_binding_handleStefan Metzmacher2014-01-163-6/+8
| | | | | | | This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_userinfo_send() take ↵Stefan Metzmacher2014-01-163-21/+31
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: remove unused libnet_rpc_groupdel* codeStefan Metzmacher2014-01-162-206/+0
| | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_groupadd() take tevent_context/dcerpc_binding_handleStefan Metzmacher2014-01-162-6/+11
| | | | | | | This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_groupadd_send() take ↵Stefan Metzmacher2014-01-162-11/+16
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_groupinfo() take tevent_context/dcerpc_binding_handleStefan Metzmacher2014-01-162-6/+7
| | | | | | | This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: let libnet_rpc_groupinfo_send() take ↵Stefan Metzmacher2014-01-162-15/+25
| | | | | | | | | tevent_context/dcerpc_binding_handle This avoids usage/dereferencing 'struct dcerpc_pipe'. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: avoid using dcecli_connection->event_ctxStefan Metzmacher2014-01-161-1/+1
| | | | | | | | | | We should avoid per connection tevent_contexts, the one per libnet_context isn't much better, but a start. Note the pointers have the same value. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s4:libnet: keep a dcerpc_binding_handle for samr and lsaStefan Metzmacher2014-01-161-1/+4
| | | | | | | This completes commit a3ae9802d47f7a39030be089d15fc42f8e8917e6. Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org>
* s3:dbwrap: Use milliseconds for "Held tdb lock" messageChristof Schmitt2014-01-161-5/+6
| | | | | | | | | | | This is consistent with the parameter using milliseconds and the other warnings in the same file also using milliseconds. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Jan 16 11:19:39 CET 2014 on sn-devel-104
* s3:dbwrap: Store warning thresholds in db_ctdb_ctxChristof Schmitt2014-01-161-4/+18
| | | | | | | | | Avoid the parameter lookup for the warning thresholds in the hot code path by reading them in db_open_ctdb and storing them in the db_ctdb_ctx. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:dbwrap include the hashchain in the logsChristian Ambach2014-01-161-3/+12
| | | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* s3:dbwrap report time for chainlock and CTDB migrateChristian Ambach2014-01-161-2/+15
| | | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
* dbwrap_ctdb: Instrument chainunlock timingVolker Lendecke2014-01-161-2/+26
| | | | | | | | | | | | We need an indication whether we run into the fcntl thundering herd. fcntl unlock should be blindingly fast in the normal case. If it takes longer than 5 milliseconds, warn. The timeout can be adapted by setting ctdb:unlock_warn_threshold = <number-of-milliseconds> Reviewed-by: Christof Schmitt <cs@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org>
* ctdb_conn: Log long fetch_lock callsVolker Lendecke2014-01-161-4/+22
| | | | | | | | | | | | | | | | | With this patch, the number of fetch_lock attempts before dbwrap_ctdb logs that it took x attempts to get a record is configurable with net conf setparm global ctdb:migrate_attempts 10 This patch also adds net conf setparm global ctdb:migrate_duration 5000 to trigger the same log message if it took longer than x milliseconds to retrieve a record. Reviewed-by: Christof Schmitt <cs@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org>
* ctdb-daemon: Remove ctdb_fork_with_logging()Amitay Isaacs2014-01-162-65/+0
| | | | | | | | | | This function has been replaced with ctdb_vfork_with_logging(). Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Thu Jan 16 04:05:35 CET 2014 on sn-devel-104
* ctdb-tests: Set CTDB_EVENT_HELPER when running with local daemonsAmitay Isaacs2014-01-161-0/+1
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Remove unused code to run eventscriptsAmitay Isaacs2014-01-161-104/+0
| | | | | | | Eventscripts are now executed using a helper. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Replace ctdb_fork_with_logging with ctdb_vfork_with_logging ↵Amitay Isaacs2014-01-161-26/+28
| | | | | | | | | (part 2) Use ctdb_event_helper to run debug-hung-script.sh. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Replace ctdb_fork_with_logging with ctdb_vfork_with_logging ↵Amitay Isaacs2014-01-161-20/+90
| | | | | | | | | (part 1) Use ctdb_event_helper to run eventscripts. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Add helper process to execute event scriptsAmitay Isaacs2014-01-163-1/+143
| | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: Add ctdb_vfork_with_logging()Amitay Isaacs2014-01-162-0/+87
| | | | | | | | This will be used to spawn lightweight helper processes to run eventscripts. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
* ctdb-daemon: No need to call event scripts with CTDB_CALLED_BY_USERAmitay Isaacs2014-01-166-46/+16
| | | | | | | | This was added to support external monitoring using CTDB event scripts. However, it was never used. Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net>
generated by cgit (git 2.34.1) at 2025-09-28 12:48:32 +0000