summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* CVE-2013-4408:s3:Ensure LookupNames replies arrays are range checked.Jeremy Allison2013-12-0920-46/+359
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:Ensure LookupSids replies arrays are range checked.Jeremy Allison2013-12-098-7/+102
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:Ensure we always check call_id when validating an RPC reply.Jeremy Allison2013-12-091-8/+25
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>
* CVE-2013-4408:s3:ctdb_conn: add some length verification to ctdb_packet_more()Stefan Metzmacher2013-12-091-0/+5
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:libcli/util: add some size verification to ↵Stefan Metzmacher2013-12-091-0/+5
| | | | | | | | | tstream_read_pdu_blob_done() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:util_tsock: add some overflow detection to ↵Stefan Metzmacher2013-12-091-0/+5
| | | | | | | | | tstream_read_packet_done() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:async_sock: add some overflow detection to read_packet_handler()Stefan Metzmacher2013-12-091-0/+5
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s4:dcerpc_sock: check for invalid frag_len within ↵Stefan Metzmacher2013-12-091-0/+6
| | | | | | | | | sock_complete_packet() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s4:dcerpc_smb2: check for invalid frag_len in ↵Stefan Metzmacher2013-12-091-0/+6
| | | | | | | | | send_read_request_continue() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s4:dcerpc_smb: check for invalid frag_len in ↵Stefan Metzmacher2013-12-091-0/+6
| | | | | | | | | send_read_request_continue() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s4:dcerpc: check for invalid frag_len in ncacn_pull()Stefan Metzmacher2013-12-091-0/+4
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:rpc_client: verify frag_len at least contains the header sizeStefan Metzmacher2013-12-091-0/+8
| | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:s3:rpc_client: check for invalid frag_len in ↵Stefan Metzmacher2013-12-091-0/+4
| | | | | | | | | dcerpc_pull_ncacn_packet() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:librpc: check for invalid frag_len within ↵Stefan Metzmacher2013-12-091-0/+9
| | | | | | | | | | | | dcerpc_read_ncacn_packet_next_vector() We should do this explicit instead of relying on tstream_readv_pdu_ask_for_next_vector() to catch the overflow. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* CVE-2013-4408:librpc: check for invalid frag_len within ↵Stefan Metzmacher2013-12-091-0/+5
| | | | | | | | | dcerpc_read_ncacn_packet_done() Bug: https://bugzilla.samba.org/show_bug.cgi?id=10185 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* ctdb:packaging:RPM: don't run autogen.Michael Adam2013-12-091-3/+0
| | | | | | | | | | | | | | | | | autogen is already run in maketarball.sh which generates the tarball for the RPM. This way, we don't have a rpm build dependency on autoconf. Recent changes introduced a dependency into autoconf version >= 2.60, so this fix allows the generated source RPM to be built also on older platforms. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Mon Dec 9 05:47:00 CET 2013 on sn-devel-104
* ctdb:packaging:RPM: package the new manpagesMichael Adam2013-12-091-0/+4
| | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb:build: install the new manpagesMichael Adam2013-12-091-0/+6
| | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* lib/ntdb optimize includes in ntdb toolsChristian Ambach2013-12-077-61/+5
| | | | | | | | | | | use the private header (which will use libreplace or system headers) instead of direct includes of system includes Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Rusty Russell <rusty@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Sat Dec 7 18:38:21 CET 2013 on sn-devel-104
* lib/ntdb optimize includes in ntdb testsChristian Ambach2013-12-0727-97/+20
| | | | | | | | use the private header (which will use libreplace or system headers) instead of direct includes of system includes Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Rusty Russell <rusty@samba.org>
* lib/ntdb correct includes in private headerChristian Ambach2013-12-071-0/+5
| | | | | | | | include all necessary headers when libreplace is not around Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Rusty Russell <rusty@samba.org>
* lib/ntdb fix compilation when libreplace is not aroundChristian Ambach2013-12-072-1/+10
| | | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Rusty Russell <rusty@samba.org>
* lib/socket_wrapper fix compilation when libreplace is not aroundChristian Ambach2013-12-071-0/+20
| | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
* s3:vfs_btrfs change includesChristian Ambach2013-12-071-2/+1
| | | | | | | use the ones from libreplace instead of system ones Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
* s3:pam_smbpass change includesChristian Ambach2013-12-071-7/+4
| | | | | | | use the ones from libreplace instead of system ones Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
* s3:vfs fix a compile warningChristian Ambach2013-12-071-1/+1
| | | | | | | | Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Sat Dec 7 14:20:43 CET 2013 on sn-devel-104
* ldb: bad if test in ldb_comparison_fold()Jeremy Allison2013-12-071-1/+1
| | | | | | | | | | | | Found by David Binderman <dcb314@hotmail.com> BUG: https://bugzilla.samba.org/show_bug.cgi?id=10305 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Sat Dec 7 11:10:47 CET 2013 on sn-devel-104
* docs: update the manpage of vfs_shadow_copy2Michael Adam2013-12-061-48/+242
| | | | | | | | | | | | | | Document the configuration and all the options available for the shadow_copy2 module. Pair-Programmed-With: Björn Baumbach <bb@sernet.de> Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Dec 6 22:26:31 CET 2013 on sn-devel-104
* s3:modules:shadow_copy2: remove redundant documentation comment blockMichael Adam2013-12-071-77/+4
| | | | | | | | | and refer to the manual page instead Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3:modules:shadow_copy2: improve headline commentMichael Adam2013-12-071-1/+1
| | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s3:module:shadow_copy2: add my (C)Michael Adam2013-12-071-0/+1
| | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4:torture:smb2: add new durable-v2-open.reopen1a testMichael Adam2013-12-061-0/+110
| | | | | | | | | | | | | | | - open session1 on tcp connection conn1 - open a durable handle on a session1 - do a session reconnect on a new tcp connection conn2 - doing a durable reconnect on session1 gives USER_SESSION_DELETED - doing a durable reconnect on session2 succeeds Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Fri Dec 6 15:59:15 CET 2013 on sn-devel-104
* s4:torture:smb2: add new durable-open.reopen1a testMichael Adam2013-12-061-0/+100
| | | | | | | | | | | | - open session1 on tcp connection conn1 - open a durable handle on a session1 - do a session reconnect on a new tcp connection conn2 - doing a durable reconnect on session1 gives USER_SESSION_DELETED - doing a durable reconnect on session2 succeeds Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* cldap: quieten error when abandon packet is sentGarming Sam2013-12-061-0/+7
| | | | | | | | | | | | The specification indicates that no response needs to be sent when receiving an abandon request packet. Signed-off-by: Garming Sam <garming@catalyst.net.nz> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Dec 6 07:13:29 CET 2013 on sn-devel-104
* pyntdb: Add tests for Python API.Jelmer Vernooij2013-12-062-2/+156
| | | | | | Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyntdb: Don't segfault when passing in None as filename (for memory db)Jelmer Vernooij2013-12-061-1/+1
| | | | | | Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyntdb: Don't allow access after a database is closed.Jelmer Vernooij2013-12-062-6/+77
| | | | | | Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* tdb tests: Remove custom code for "tdb2", which has been split out into ntdb.Jelmer Vernooij2013-12-061-43/+22
| | | | | | Signed-off-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* selftest: Remove samba3.smb2.lock.*.rw-exclusive from flapping fileChristof Schmitt2013-12-061-1/+0
| | | | | | | | | | This test demonstrates a problem with byte range locks and AIO. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Fri Dec 6 05:19:37 CET 2013 on sn-devel-104
* selftest: Run smb2.lock tests also against AIO shareChristof Schmitt2013-12-051-0/+4
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* selftest: Introduce share for testing AIOChristof Schmitt2013-12-051-0/+4
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3: Return correct error code from SMB2 AIO read failureChristof Schmitt2013-12-051-1/+1
| | | | | | | | | This is similar to commit 27e20d5d60ea8aa526bcb7c2dfc18dd2de0bb97b which fixed the same case for SMB2 writes: When sending the AIO read fails, return the real error instead of mapping it to NT_STATUS_FILE_CLOSED. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3-aio: Use correct locking context for SMB2Christof Schmitt2013-12-051-2/+2
| | | | | | | | | The synchronous SMB2 reads and writes use open_persistent_id. The AIO codepathes have to use the same, otherwise a write will conflict with a lock on the same open file. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
* s3-torture: Call cli_flush().Andreas Schneider2013-12-061-1/+2
| | | | | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Fri Dec 6 03:07:32 CET 2013 on sn-devel-104
* krb5_wrap: Move function declaration outside the function.Andreas Schneider2013-12-061-8/+9
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3-libsmb: Fix a memory leak in get_pdc_ip().Andreas Schneider2013-12-061-0/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3-torture: Make sure status is used initialized.Andreas Schneider2013-12-061-4/+3
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3-torture: Fix several memory leaks in delete_fn().Andreas Schneider2013-12-061-1/+5
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s3-utils: Fix a memory leak in smbget.Andreas Schneider2013-12-061-0/+1
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
* s4-torture: Use talloc for asprintf.Andreas Schneider2013-12-061-12/+10
| | | | | Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>