summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* s4:winbind: don't leak libnet_context into the main event contextStefan Metzmacher2013-06-041-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This needs to be a talloc child of struct wbsrv_domain otherwise the cleanup of a broken connection doesn't work. The following command can trigger the leak on a domain controller. root@dc:~/samba# ls -l /var/lib/samba/sysvol/samba.private/ total 16 drwxrwx---+ 5 root 3000000 4096 May 14 14:46 Policies drwxrwx---+ 2 root 3000000 4096 May 14 11:45 scripts gid 3000000 belongs to Builtin\Administrators. The code triggers a ncacn_np: connection to the local smbd and complains that domain BUILTIN is not available: [2013/05/29 17:28:03, 2] ../source4/winbind/wb_init_domain.c:376(init_domain_recv_queryinfo) Expected domain name BUILTIN, DC dc.samba.private said SAMBA In that case the connection was not closed, which is fixed by this commit. Using ncalrpc: for all local SIDs and serving the BUILTIN domain is a project for another day... Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue Jun 4 11:05:09 CEST 2013 on sn-devel-104
* s3:lib/ctdb_packet use sys_send in packet_fd_writeChristian Ambach2013-06-031-1/+1
| | | | | | | | | | | use the signal safe variant here to prevent spurious errors when running with CTDB and a signal comes in Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Mon Jun 3 20:01:22 CEST 2013 on sn-devel-104
* Bug 8997: change libreplace GPL source to LGPLDavid Disseldorp2013-06-033-31/+43
| | | | | | | | | | | | | | | | | | | | | | | | libreplace currently includes socket.c and getifaddrs.c both of which are GPL licensed. Although not required, talloc and tdb build alongside this source, leading to some ambiguity regarding their LGPL licences. The following copyright holders have agreed to the GPL->LGPL change: lib/replace/getifaddrs.c Copyright (C) Andrew Tridgell 1998 Copyright (C) Jeremy Allison 2007 Copyright (C) Jelmer Vernooij <jelmer@samba.org> 2007 lib/replace/test/getifaddrs.c lib/replace/socket.c * Copyright (C) Michael Adam <obnox@samba.org> 2008 Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Jun 3 18:06:18 CEST 2013 on sn-devel-104
* torture: support printer publish pending responsesDavid Disseldorp2013-06-031-14/+37
| | | | | | | | | | | | | Windows (tested against 2k8r2) returns WERR_IO_PENDING and DSPRINT_PENDING when a publish or unpublish is requested via setprinter(level=7). Modify the AD printer publishing test to support these responses. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Jun 3 16:06:15 CEST 2013 on sn-devel-104
* torture: add AD printer publishing testDavid Disseldorp2013-06-032-0/+122
| | | | | | | | | This test publishes and unpublishes a printer using setprinter(level=7). Printer info2.attributes and info7.action flags are check at each point to ensure MS-RPRN conformance. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* Fix bug 9900: is_printer_published GUID retrievalDavid Disseldorp2013-06-034-56/+121
| | | | | | | | | | | | | Samba currently always responds to GetPrinter(level = 7) requests with DSPRINT_UNPUBLISH, regardless of the AD publish status tracked via the PRINTER_ATTRIBUTE_PUBLISHED flag. This is due to erroneous "objectGUID" unmarshalling in is_printer_published(). This change splits "objectGUID" retrieval into a separate function, and adds a pull_reg_sz() call to correctly unmarshall the GUID. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* printing: explicitly clear PUBLISHED attributeDavid Disseldorp2013-06-031-1/+1
| | | | | | | | | Currently nt_printer_publish(DSPRINT_UNPUBLISH) flips (via xor) the info2->attributes PRINTER_ATTRIBUTE_PUBLISHED flag, rather than explicitly clearing it. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org>
* tdb: Add another overflow check to tdb_expand_adjustVolker Lendecke2013-06-031-0/+6
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Mon Jun 3 14:08:54 CEST 2013 on sn-devel-104
* tdb: Make tdb_recovery_allocate overflow-safeVolker Lendecke2013-06-031-1/+6
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb: Make tdb_recovery_size overflow-safeVolker Lendecke2013-06-032-7/+28
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb: add proper OOM/ENOSPC handling to tdb_expand()Stefan Metzmacher2013-06-031-8/+23
| | | | | | | | | | | Failing to do so will result in corrupt tdbs: We will overwrite the hash chain pointers with 0x42424242. Pair-Programmed-With: Volker Lendecke <vl@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb: add overflow detection to tdb_expand_adjust()Stefan Metzmacher2013-06-031-3/+31
| | | | | | | | | | | | | We round up at maximun to a new size of 4GB, but still return at least the given size. The caller has to deal with ENOSPC itself. Pair-Programmed-With: Volker Lendecke <vl@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb: add overflow/ENOSPC handling to tdb_expand_file()Stefan Metzmacher2013-06-031-1/+11
| | | | | | | | Pair-Programmed-With: Volker Lendecke <vl@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb: add a 'new_size' helper variable to tdb_expand_file()Stefan Metzmacher2013-06-031-4/+7
| | | | | | | | Pair-Programmed-With: Volker Lendecke <vl@samba.org> Signed-off-by: Stefan Metzmacher <metze@samba.org> Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
* tdb: Add overflow-checking tdb_add_off_tVolker Lendecke2013-06-032-0/+12
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
* param_table: Remove misleading allow dns updates options.Michael Wood2013-06-011-5/+0
| | | | | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Jun 1 12:46:32 CEST 2013 on sn-devel-104
* docs: Avoid mentioning a possibly misleading option.Michael Wood2013-06-011-2/+2
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* WHATSNEW: Fix 4.0 default for allow dns updates.Michael Wood2013-06-011-1/+1
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli: Remove uneeded debug messageKai Blin2013-06-011-1/+0
| | | | | | Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* dns: Delete dnsNode objects when they are emptyKai Blin2013-06-012-1/+124
| | | | | | | | | | | | If an update leaves the dnsNode without any entries, the dnsNode object should be deleted. Thanks to Günter Kukkukk for his excellent debugging work on this one. This should fix bug #9559 Signed-off-by: Kai Blin <kai@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4-dns: set TTL value in the NS server part of the SOA recordGuenter Kukkukk2013-05-301-0/+1
| | | | | | | | | | | | noticed this when using samba-tool to create a new zone Signed-off-by: Guenter Kukkukk <kukks@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu May 30 09:41:20 CEST 2013 on sn-devel-104
* build-htmlman-nogit: Run build-htmlman-nogit with bash.Karolin Seeger2013-05-301-1/+1
| | | | | | | | | | | | On debian/ubuntu, the "dash" which is sh, does not provide pushd/popd... Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu May 30 04:48:06 CEST 2013 on sn-devel-104
* build-htmlman-git: Run build-htmlman-git with bash.Karolin Seeger2013-05-301-1/+1
| | | | | | | | | On debian/ubuntu, the "dash" which is sh, does not provide pushd/popd... Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build-htmlman-nogit: manpages-3 has been moved to manpages.Karolin Seeger2013-05-301-1/+1
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build-htmlman-git: manpages-3 has been moved to manpages.Karolin Seeger2013-05-301-1/+1
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* docs-xml/.gitignore: manpages-3 has been moved to manpages.Karolin Seeger2013-05-301-1/+1
| | | | | | Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* vfs_glusterfs: Samba VFS module for glusterfsAnand Avati2013-05-303-0/+1522
| | | | | | | | | | | Implement a Samba VFS plugin for glusterfs based on gluster's gfapi. This is a "bottom" vfs plugin (not something to be stacked on top of another module), and translates (most) calls into closest actions on gfapi. Reviewed-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Simo Sorce <idra@samba.org> Signed-off-by: Anand Avati <avati@redhat.com>
* samba-tool/dns: Set secure zone update flag after creating new zoneAmitay Isaacs2013-05-301-3/+9
| | | | | | | Windows DC ignores the secure update flag while creating new zone. Windows performs another operation to set the secure update flag. Signed-off-by: Amitay Isaacs <amitay@gmail.com>
* samba-tool/dns: Pass on additional flags when creating zonesAmitay Isaacs2013-05-301-0/+6
| | | | | | | | Windows DCs require additional flags to be set when creating zones. This fixes bug #9599. Signed-off-by: Amitay Isaacs <amitay@gmail.com>
* s4-dns: Support update of SOA recordsAmitay Isaacs2013-05-301-2/+3
| | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com>
* s4-rpc: dnsserver: When updating SOA record, use the specified serialAmitay Isaacs2013-05-301-6/+9
| | | | | | | This makes sure that when updating SOA record, the serial is set to the value sent by client. For all other records, serial is incremented. Signed-off-by: Amitay Isaacs <amitay@gmail.com>
* s4-rpc: dnsserver: dns_name_equal() returns booleanAmitay Isaacs2013-05-301-2/+2
| | | | | | | | | Remove the remaining check for return value after strcmp() was changed to dns_name_equal(). Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* s4-rpc: dnsserver: Fix removal of trailing '.' in soa mnameAmitay Isaacs2013-05-301-2/+2
| | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* build: Add missing new line to replaced python shebang line. (Fix bug #9909)Michael Adam2013-05-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | When configuring with a non-standard python specified in the PYTHON environment variable, the shebang lines in various python tools like samba-tool and samba_dnsupdate get replaced. This replace line for the shebang was missing a newline which joined the shebang line with the following line, rendereing those scripts with a nonempty second line unusuable, for example samba_dnsupdate. This patch fixes this bug which is bug #9909 on bugzilla. Pair-Programmed-With: Karolin Seeger <kseeger@samba.org> Signed-off-by: Michael Adam <obnox@samba.org> Signed-off-by: Karolin Seeger <kseeger@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed May 29 13:21:51 CEST 2013 on sn-devel-104
* s4-torture: Always compile backupkey ndr testsuite.Günther Deschner2013-05-292-4/+1
| | | | | | | | | | | | | This removes another incorrect AD_DC_BUILD_IS_ENABLED check ifdef check. The ndr test is not at all heimdal specific. Guenther Signed-off-by: Günther Deschner <gd@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Alexander Bokovoy <ab@samba.org> Autobuild-Date(master): Wed May 29 11:29:51 CEST 2013 on sn-devel-104
* waf: build PIEs if supported by the compilerDavid Disseldorp2013-05-291-6/+12
| | | | | | | | | | | Currently waf performs a mandatory check for compiler PIE support, unless --without-pie is specified. This change makes Waf only perform the mandatory check if --with-pie is specified. If neither --with-pie nor --without-pie are specified, then PIEs are only built if compiler support is available. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org>
* autobuild: remove remnants of removed samba3 targetsMichael Adam2013-05-291-2/+0
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Wed May 29 09:35:16 CEST 2013 on sn-devel-104
* net: use smbconf_create_set_share() in "net conf import"Michael Adam2013-05-281-47/+2
| | | | | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue May 28 20:01:12 CEST 2013 on sn-devel-104
* libsmbconf: add smbconf_create_set_shareDavid Disseldorp2013-05-282-0/+90
| | | | | | | | | | | | | | This call creates a new share definition, using the parameters provided with a smbconf_service structure. Such an interface allows for simple cloning of services with: smbconf_get_share(conf_ctx, mem_ctx, base_sharename, &base_service_def); base_service_def->name = clone_sharename; smbconf_create_set_share(conf_ctx, base_service_def); Pair-Programmed-With: Michael Adam <obnox@samba.org> Signed-off-by: David Disseldorp <ddiss@samba.org> Signed-off-by: Michael Adam <obnox@samba.org>
* libsmbconf: fix documentation of transaction calls.Michael Adam2013-05-281-2/+7
| | | | | Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* dsdb-repl_meta_data: Move TODO comment about conflicts and missing parentsAndrew Bartlett2013-05-281-9/+4
| | | | | | | Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Tue May 28 18:11:00 CEST 2013 on sn-devel-104
* torture: Add tests of rename behaviour to replica_sync.pyAndrew Bartlett2013-05-281-0/+104
| | | | Reviewed-by: Stefan Metzmacher <metze@samba.org>
* dsdb-repl_meta_data: Handle renames better, considering only the RDN as ↵Andrew Bartlett2013-05-281-76/+141
| | | | | | | | | | given, and then the parent as given This ignores the full DN as given, because the parent compents might be out of date. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* dsdb-linked_attributes: Do not crash if the target GUID can not be foundAndrew Bartlett2013-05-281-0/+15
| | | | | | | | | | Note that we must not give an error when we cannot find the object that should hold the backlink, there really isn't anything we can do in this case. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
* tdb: fix logging of offets and lengths.Rusty Russell2013-05-287-47/+46
| | | | | | | | | | | | We can have offsets > 2G, so use unsigned values. Fixes other prints to be native types rather than casts, too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue May 28 11:22:14 CEST 2013 on sn-devel-104
* s4-dns: Print/Set minimumTTL value in SOA recordAmitay Isaacs2013-05-281-1/+3
| | | | | | | | | Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Tue May 28 08:47:56 CEST 2013 on sn-devel-104
* build: Remove unused mkbuildoptions.awkAndrew Bartlett2013-05-281-275/+0
| | | | | | | | | | This is not used by the waf build. Andrew Bartlett Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* build: Remove unused tool for config.h comparisonAndrew Bartlett2013-05-282-37/+0
| | | | | | Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* build: Remove feature tests for variables now always providedAndrew Bartlett2013-05-281-11/+0
| | | | | | | | | | | These #ifdef statements were added in replacement for #if (_SAMBA_BUILD_ >= 4) in fbe7ed79b0f056a9a8f44a9b42e887441d2f00d5 Andrew Bartlett Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* build: Remove unused credentials_samba3.cAndrew Bartlett2013-05-281-49/+0
| | | | | | | | | | This file was only used by the autoconf build system. Andrew Bartlett Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
generated by cgit (git 2.34.1) at 2025-09-26 15:21:42 +0000