summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix all warnings in source3 with gcc4.3.Jeremy Allison2008-12-3116-53/+168
| | | | Jeremy.
* Fix more asprintf and "ignoring return code" warnings from gcc 4.3.Jeremy Allison2008-12-315-58/+103
| | | | Jeremy.
* Replace a static variable and alarm() calls by using sys_select()Volker Lendecke2008-12-311-23/+24
| | | | Günther, please check!
* Fix some nonempty blank linesVolker Lendecke2008-12-311-5/+5
|
* Make a CONST_DISCARD unnecessary by applying some constVolker Lendecke2008-12-311-3/+2
| | | | Derrell, please check!
* Replace "goto again" by "return NT_STATUS_RETRY" in receive_message_or_smbVolker Lendecke2008-12-311-11/+13
| | | | This gives lower-level routines the chance to indicate a retry condition
* Disable the use of splice(2)Volker Lendecke2008-12-311-1/+1
| | | | | | | | | | On a debian lenny installation with a kernel that calls itself 2.6.28, I could repeatably block smbd using splice. According to the output of netstat, the recvq of the TCP connection was full and at the same time according to strace smbd was stuck in a splice syscall trying to read from that TCP connection. We can not protect ourselves from this condition, as nobody will ever notify us that something is broken. So sadly we can't use splice yet at all. Maybe in 2.6.29...
* Try to fix recvfile using splice on LinuxVolker Lendecke2008-12-311-21/+36
| | | | | | | | According to the splice(2) manpage, one of the file descriptors *must* be a pipe. With this patch I could successfully run splice(2) on a debian lenny installation. Jeremy, please check!
* Fix a "nested extern" warningVolker Lendecke2008-12-311-1/+1
|
* Rename parent_dirname_talloc() to parent_dirname()Volker Lendecke2008-12-3112-34/+17
|
* Remove unused function parent_dirnameVolker Lendecke2008-12-312-14/+0
|
* Use parent_dirname_talloc instead of parent_dirname in smb_unix_mknodVolker Lendecke2008-12-311-3/+7
|
* Use parent_dirname_talloc instead of parent_dirname in copy_internalsVolker Lendecke2008-12-311-2/+6
|
* Use parent_dirname_talloc instead of parent_dirname in vfswrap_mkdirVolker Lendecke2008-12-311-1/+6
|
* Make use of TALLOC_MEMDUP in parent_dirname_talloc()Volker Lendecke2008-12-311-2/+1
|
* Remove unused function get_numlist()Volker Lendecke2008-12-312-52/+0
|
* recvfile can't be used for printing so farVolker Lendecke2008-12-311-0/+4
|
* s3:winbindd: we don't need to call messaging_reinit() twiceStefan Metzmacher2008-12-311-7/+0
| | | | | | reinit_after_fork() already calls messaging_reinit() metze
* Enable individual smbtorture_s3 subtests in make testVolker Lendecke2008-12-311-0/+4
|
* Fix an ancient uninitialized variable readVolker Lendecke2008-12-314-8/+10
| | | | The callers of open_file_ntcreate expect *psbuf to be filled correctly
* s3 build: Revert previous patch to fix the buildTim Prouty2008-12-301-3/+101
| | | | | 888524623d179ceb4d540f5ac0f3b013d3ce5735 broke the build. I'm reverting it for the short term, while I work on a better fix.
* Fix more "ignore return value" warnings from gcc 4.3.Jeremy Allison2008-12-304-15/+31
| | | | Jeremy
* librpc: Re-run make idl-full from source3Tim Prouty2008-12-303-9/+9
|
* pidl: Fix a const build warning in the samba3 merged buildTim Prouty2008-12-301-1/+1
| | | | | | | | | | | The warning: ../librpc/gen_ndr/ndr_spoolss.c: In function ‘ndr_pull_spoolss_EnumPrinterData’: ../librpc/gen_ndr/ndr_spoolss.c:14792: warning: passing argument 1 of ‘memset’ discards qualifiers from pointer target type In some case the pidl generated code needs to memset a const struct field. This causes the above warning. This patch discardeds the const in this case. I'm open to a more elegant fix, but this eliminates the warning and should be relatively safe.
* s3/s4: Move CONST_DISCARD into lib/util so it's available from s3 and s4Tim Prouty2008-12-302-2/+2
|
* s3 build: Remove redundant #defines that are in idl generated headersTim Prouty2008-12-301-101/+3
| | | | | This fixes a series of samba3 build warnings in the merged build: 'error: "X" redefined', where X is one of the redundant #defines
* s4: simplify some overly-complicated logicTim Prouty2008-12-301-1/+1
|
* s3 build: Fix warningTim Prouty2008-12-301-0/+2
|
* s3:cluster: register the client connection via CTDB_CONTROL_TCP_ADDStefan Metzmacher2008-12-304-13/+27
| | | | | | | This means we correctly pass IPv6 addresses too. (CTDB_CONTROL_TCP_CLIENT was IPv4 only) metze
* Fix a memory leak in cups_pull_comment_locationVolker Lendecke2008-12-301-0/+4
| | | | We allocated "request" with ippNew, so we also should ippDelete it.
* Fix a spinning smbd when printingVolker Lendecke2008-12-301-1/+1
| | | | | | Without this, we end up adding more than one timed event. In the event handler print_notify_event_send_messages() only one event will be deleted, all others will fire indefinitely.
* Print the vuid in BENCH-SESSSETUPVolker Lendecke2008-12-301-0/+2
|
* Second part of the bugfix for #5933Volker Lendecke2008-12-301-7/+13
| | | | | | | | Incrementing the next vuid did not correctly overflow Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-) Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
* First part of bugfix for #5933Volker Lendecke2008-12-301-3/+0
| | | | | | | | | | Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing num_validated_vuids twice per session setup, but decrement it only once. Looking at sesssetup.c we always call register_initial_vuid() before register_existing_vuid(), so there's no point in incrementing it in register_existing_vuid(). Jeremy, please check!
* Move a comment to its placeVolker Lendecke2008-12-301-5/+5
|
* Simplify invalidate_vuid slightlyVolker Lendecke2008-12-301-4/+0
| | | | get_valid_user_struct_internal() checks for UID_FIELD_INVALID itself
* Simplify is_partial_auth_vuid slightlyVolker Lendecke2008-12-301-5/+1
|
* Simplify invalidate_all_vuids() slightlyVolker Lendecke2008-12-301-5/+2
| | | | invalidate_vuid takes care of removing the user_struct from validated_users
* Fix the merged buildStefan Metzmacher2008-12-301-0/+1
| | | | metze
* lib/tevent: fix standalone make distclean realdistcleanStefan Metzmacher2008-12-301-2/+2
| | | | | | Bug report by Brad Hards <bradh@frogmouth.net>. metze
* pidl: don't generate invalid C codeStefan Metzmacher2008-12-291-1/+3
| | | | | | | | | When we don't know how to handle a type for the python bindings, we should not generate invalid C code. Jelmer: please fix do the full fix for this. metze
* s3:pdb_tdb: store the next rid counter in passdb.tdb instead of ↵Stefan Metzmacher2008-12-291-75/+47
| | | | | | | | winbind_idmap.tdb This upgrades the TDBSAM_VERSION to 4 and SAMU_BUFFER_V4. metze
* s3:passdb: add SAMU_BUFFER_V4 with no changesStefan Metzmacher2008-12-292-2/+19
| | | | | | | The upgrade is required because of the followin TDBSAM_VERSION upgrade. metze
* s3:passdb: make marshalling struct samu from and to a buffer more genericStefan Metzmacher2008-12-294-667/+679
| | | | | | | This marshalling isn't specific to tdbsam and it's ugly to have the related functions in two different files. metze
* s4:cluster: fix dependency to TDB_WRAPStefan Metzmacher2008-12-291-0/+1
| | | | metze
* s4:lib/tevent: rename structsStefan Metzmacher2008-12-29211-684/+681
| | | | | | | | | | | | | | | | | | | | list="" list="$list event_context:tevent_context" list="$list fd_event:tevent_fd" list="$list timed_event:tevent_timer" for s in $list; do o=`echo $s | cut -d ':' -f1` n=`echo $s | cut -d ':' -f2` r=`git grep "struct $o" |cut -d ':' -f1 |sort -u` files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4` for f in $files; do cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp mv $f.tmp $f done done metze
* s4:pvfs_aio: use teventStefan Metzmacher2008-12-292-12/+12
| | | | metze
* s4:sys_lease_linux: use teventStefan Metzmacher2008-12-292-8/+8
| | | | metze
* Fix SESSSETUP_BENCH torture test for long runtimesVolker Lendecke2008-12-291-6/+9
| | | | | deadtime hits without any files open. To enable long runtimes, open a file with delete_on_close set.
* s4:cluster: remove old/broken ctdb codeStefan Metzmacher2008-12-2997-28446/+1
| | | | | | | | We don't need a full copy of ctdb... If we want to readd cluster support, we should just use a ctdb client library. metze