summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* libads: Fix CID 1273306 Uninitialized scalar variableVolker Lendecke2015-03-041-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* lib: Fix CID 1273292 Uninitialized pointer readVolker Lendecke2015-03-041-1/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* lib: Fix CID 1273056 Negative array index readVolker Lendecke2015-03-041-1/+6
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* lib: Fix CID 1128561 Pointer to local outside scopeVolker Lendecke2015-03-041-2/+3
| | | | | | | | This is not strictly a bug, but it is confusing enough to justify a small patch I guess. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* Fix whitespaceVolker Lendecke2015-03-042-54/+52
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* lib: Fix CID 1128552 Buffer not null terminatedVolker Lendecke2015-03-041-6/+8
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* build:wafadmin: fix use of spaces instead of tabs.Michael Adam2015-03-041-3/+3
| | | | | | | | Indentation should not be a mixture of tabs and spaces. Waf uses tabs. Signed-off-by: Michael Adam <obnox@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
* ctdb-build: Specify absolute path to libsocket-wrapper.soAmitay Isaacs2015-03-041-1/+2
| | | | | | | | | | | | | Specifying a relative path to LD_PRELOAD can fail if any of the test scripts uses cd to change directory and execute commands. Adding statd-callout tests breaks autotest since statd-callout does "cd". Signed-off-by: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Martin Schwenke <martin@meltin.net> Autobuild-User(master): Amitay Isaacs <amitay@samba.org> Autobuild-Date(master): Wed Mar 4 13:11:53 CET 2015 on sn-devel-104
* ctdb-tests: Remove the old, confusing INSTALL scriptMartin Schwenke2015-03-041-96/+0
| | | | | | | It is not used after switching to waf build. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-scripts: Remove unused function nfs_statd_update()Martin Schwenke2015-03-041-17/+0
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-scripts: Change statd-callout to be more scalableMartin Schwenke2015-03-0411-59/+123
| | | | | | | | | | | | | | | | Updating ctdb.tdb on each add-client, del-client and each delete during notify was too ambitious. Persistent transactions do not perform well enough to do this. Revert to having add-client and del-client create touch files. Each monitor event calls "statd-callout update" to convert touch files into ctdb.tdb records. Update testcases to do the "update" and add an extra test. Signed-off-by: Martin Schwenke <martin@meltin.net> Pair-programmed-with: Amitay Isaacs <amitay@gmail.com> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-scripts: Fix a regression in statd-calloutMartin Schwenke2015-03-041-1/+1
| | | | | | | | | | | | | | | | Commit 4638010abb116aed0c180207aaa11475277aecb7 changed from using gensub() to gsub() in awk. However, it didn't halve the number of backslashes in the target strings. This is necessary because backslash is used in gensub() target strings to allow substitution of text matching parenthesised subexpressions. This is not the case with gsub(). So, halve the number of backslashes in the target string where gsub() is used in statd-callout. This is the only target string broken by changes made by the above commit Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Unit tests for statd-calloutMartin Schwenke2015-03-0411-13/+196
| | | | | | | | | With improvements to unit test infrastructure to support. This includes linking the real statd-callout into etc-ctdb/ in place of the placeholder script. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Make setup of public addresses more obviousMartin Schwenke2015-03-041-11/+28
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Extend eventscript unit test infrastructure for other scriptsMartin Schwenke2015-03-041-6/+19
| | | | | | | | There's so much infrastructure here that it would be a shame not to use it for testing things like statd-callout. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Support testing scripts that change directoryMartin Schwenke2015-03-042-0/+8
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Extend ctdb stub to support "ip" with and without -XMartin Schwenke2015-03-041-8/+20
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* ctdb-tests: Extend ctdb stub to support "ptrans", "pdelete", "catdb"Martin Schwenke2015-03-041-14/+87
| | | | | Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
* tevent: version 0.9.24David Disseldorp2015-03-042-1/+89
| | | | | | | | | | * Ignore unsolicited signal wakeup in tevent_port event loop. Signed-off-by: David Disseldorp <ddiss@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Mar 4 08:33:06 CET 2015 on sn-devel-104
* pyldb: Add tests for type errorsPetr Viktorin2015-03-041-0/+42
| | | | | | | | | Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Wed Mar 4 01:49:02 CET 2015 on sn-devel-104
* pyldb: Report errors converting controls list to char**Petr Viktorin2015-03-031-0/+20
| | | | | | | | | With this change, passing an unexpected type to the CRUD methods will result in an informative TypeError. Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyldb: Better error reportingPetr Viktorin2015-03-031-2/+2
| | | | | | | | Provide more useful error messages for some type errors Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyldb: Type-check arguments parsed with PyArg_ParseTuple*Petr Viktorin2015-03-031-8/+8
| | | | | | | | | PyObject* arguments need to be type-checked before they're cast to subtypes. Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyldb: Fix reference leaksPetr Viktorin2015-03-031-6/+12
| | | | | | | | | | | | | The parse_ldif and MessageElement.__iter__ functions leaked references to intermediate lists whose iterators they return. The MessageElement repr used the undocumented macro PyObject_REPR, which leaks references. (It was used internally in CPython before fatal errors, and will be removed in Python 3.5.) Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyldb: Remove use of staticforward macroPetr Viktorin2015-03-031-1/+1
| | | | | | Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyldb: Properly preallocate result control listPetr Viktorin2015-03-031-1/+5
| | | | | | | | | | | The list was always allocated with size 1, so if there is more than 1 result control, the additional items would not be added in the list, and would become leaked references. Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyldb: Use the Py_TYPE macroPetr Viktorin2015-03-031-3/+3
| | | | | | | | | | The "ob_type" member of Python objects is going away in Python 3 for compliance with C's strict aliasing rules. The Py_TYPE macro should be used instead. Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pyldb: Correct reference counting when returning boolsPetr Viktorin2015-03-031-4/+4
| | | | | | | | | Simply returning Py_True/PyFalse doesn't increment the bool object's reference count. Signed-off-by: Petr Viktorin <pviktori@redhat.com> Reviewed-by: Jelmer Vernooij <jelmer@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* pam: Fix CID 1034871 Resource leakVolker Lendecke2015-03-031-0/+1
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> Autobuild-User(master): Ralph Böhme <slow@samba.org> Autobuild-Date(master): Tue Mar 3 20:03:25 CET 2015 on sn-devel-104
* pam: Fix CID 1034870 Resource leakVolker Lendecke2015-03-031-1/+4
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* lib: Fix CID 1273073 Assign instead of compareVolker Lendecke2015-03-031-1/+1
| | | | | | | This is a brown paper bag thingy, right? Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* smbd: Fix CID 1273088 Resource leakVolker Lendecke2015-03-031-0/+1
| | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* aio_fork: Fix CID 1273291 Uninitialized scalar variableVolker Lendecke2015-03-031-3/+1
| | | | | | | The previous code left msg.msg_flags uninitialized Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org>
* tevent: Ignore unexpected signal events in the same way the epoll backend does.Jeremy Allison2015-03-031-3/+9
| | | | | | | | | | Bug: https://bugzilla.samba.org/show_bug.cgi?id=11118 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org> Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Tue Mar 3 17:33:06 CET 2015 on sn-devel-104
* Fix the O3 developer buildVolker Lendecke2015-03-0315-41/+53
| | | | | | | | | | Different gcc versions complain at different places Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Alexander Bokovoy <ab@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Mar 3 13:14:53 CET 2015 on sn-devel-104
* smbd: Make SMB3 clients use encryption with "smb encrypt = auto"Volker Lendecke2015-03-032-0/+10
| | | | | | | | Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Tue Mar 3 10:40:42 CET 2015 on sn-devel-104
* waf: Fix the build on openbsdVolker Lendecke2015-03-031-1/+3
| | | | | | | | | | We have single-digit vnum='0', make the assignment deal with it Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Tue Mar 3 03:33:24 CET 2015 on sn-devel-104
* gpfs: Add include guard to gpfswrap.hChristof Schmitt2015-03-031-0/+5
| | | | | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org> Autobuild-User(master): Christof Schmitt <cs@samba.org> Autobuild-Date(master): Tue Mar 3 01:01:25 CET 2015 on sn-devel-104
* gpfs: Rename library wrapper to gpfswrapChristof Schmitt2015-03-024-3/+3
| | | | | | | | | The code in gpfs.c and vfs_gpfs.h now only wraps the gpfs library. Rename the files to gpfswrap to make it clear that this is the only purpose of that file. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Update file headersChristof Schmitt2015-03-023-45/+43
| | | | | | | | Update file headers to reflect the new code organization and reformat for consistency. Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Remove unncessary includes from gpfs.cChristof Schmitt2015-03-021-5/+1
| | | | | | | replace.h provides everything that is required (errno and ENOSYS). Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Move DBGC_CLASS definition below includesChristof Schmitt2015-03-021-4/+3
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Include gpfs_fcntl.h only from vfs_gpfs header fileChristof Schmitt2015-03-023-2/+2
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Move definition of GPFS_GETACL_NATIVE to vfs_gpfs.cChristof Schmitt2015-03-022-4/+4
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Move smbd_gpfs_set_times_path to vfs_gpfs.cChristof Schmitt2015-03-023-39/+38
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Move get_gpfs_fset_id to vfs_gpfs.cChristof Schmitt2015-03-023-45/+44
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Move get_gpfs_quota to vfs_gpfs.cChristof Schmitt2015-03-023-29/+27
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Move set_gpfs_lease to vfs_gpfs.cChristof Schmitt2015-03-023-21/+20
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Move set_gpfs_sharemode to vfs_gpfs.cChristof Schmitt2015-03-023-48/+46
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>
* gpfs: Introduce wrapper for gpfs_getfilesetidChristof Schmitt2015-03-022-9/+15
| | | | | Signed-off-by: Christof Schmitt <cs@samba.org> Reviewed-by: Ralph Böhme <slow@samba.org>