<feed xmlns='http://www.w3.org/2005/Atom'>
<title>samba.git/source4/torture/raw, branch master</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/'/>
<entry>
<title>torture: Fix raw.open.chained-ntcreatex</title>
<updated>2014-12-09T18:43:31+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2014-11-27T20:44:18+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=8c569893250f87baf2c0b887c0dea076ca8249cf'/>
<id>8c569893250f87baf2c0b887c0dea076ca8249cf</id>
<content type='text'>
sizeof(buf) is 5. On FreeBSD10/clang this overwrites "ret". Not good.

Same as 574750777a

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Tue Dec  9 19:43:31 CET 2014 on sn-devel-104
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sizeof(buf) is 5. On FreeBSD10/clang this overwrites "ret". Not good.

Same as 574750777a

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Jeremy Allison &lt;jra@samba.org&gt;

Autobuild-User(master): Jeremy Allison &lt;jra@samba.org&gt;
Autobuild-Date(master): Tue Dec  9 19:43:31 CET 2014 on sn-devel-104
</pre>
</div>
</content>
</entry>
<entry>
<title>torture: Fix raw.open.chained-openx</title>
<updated>2014-11-28T12:30:18+00:00</updated>
<author>
<name>Volker Lendecke</name>
<email>vl@samba.org</email>
</author>
<published>2014-11-27T20:44:18+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=574750777ad47d733a45a72e7da83297e3faa897'/>
<id>574750777ad47d733a45a72e7da83297e3faa897</id>
<content type='text'>
sizeof(buf) is 5. On FreeBSD10/clang this overwrites "ret". Not good.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Ralph Böhme &lt;slow@samba.org&gt;
Autobuild-Date(master): Fri Nov 28 13:30:18 CET 2014 on sn-devel-104
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
sizeof(buf) is 5. On FreeBSD10/clang this overwrites "ret". Not good.

Signed-off-by: Volker Lendecke &lt;vl@samba.org&gt;
Reviewed-by: Ralph Boehme &lt;slow@samba.org&gt;

Autobuild-User(master): Ralph Böhme &lt;slow@samba.org&gt;
Autobuild-Date(master): Fri Nov 28 13:30:18 CET 2014 on sn-devel-104
</pre>
</div>
</content>
</entry>
<entry>
<title>s4:torture: Add smb2.oplock test batch9a and raw.oplock test batch9a</title>
<updated>2014-11-07T19:13:09+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2014-11-05T18:12:20+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=8db5150143c4770bf2ffc40a5234f7b090ec8208'/>
<id>8db5150143c4770bf2ffc40a5234f7b090ec8208</id>
<content type='text'>
Shows attribute(stat) access open can create a file,
and subsequent attribute(stat) opens don't break oplocks.

Can be extended to explore more varients.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Stefan Metzmacher &lt;metze@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Shows attribute(stat) access open can create a file,
and subsequent attribute(stat) opens don't break oplocks.

Can be extended to explore more varients.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Stefan Metzmacher &lt;metze@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>torture: Provide enough space for test EA name in raw.eas test</title>
<updated>2014-09-11T06:50:16+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2014-09-02T02:38:11+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=01d4c0e804e0c10fe6acfbdbe6747dcc5df6abc9'/>
<id>01d4c0e804e0c10fe6acfbdbe6747dcc5df6abc9</id>
<content type='text'>
The issue is that previously bad_ea_name[5] was the last element on
the array, and so when we later did a strlen() on it, we read past the
end of the stack array.  We need bad_ea_name[5] to be the second-last
element, followed by the \0 placed there by the strlcpy().

Found by AddressSanitizer

Change-Id: I871c08200aa2591c612dfa44da92b83132f83d88
Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Kamen Mazdrashki &lt;kamenim@samba.org&gt;

Autobuild-User(master): Andrew Bartlett &lt;abartlet@samba.org&gt;
Autobuild-Date(master): Thu Sep 11 08:50:16 CEST 2014 on sn-devel-104
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The issue is that previously bad_ea_name[5] was the last element on
the array, and so when we later did a strlen() on it, we read past the
end of the stack array.  We need bad_ea_name[5] to be the second-last
element, followed by the \0 placed there by the strlcpy().

Found by AddressSanitizer

Change-Id: I871c08200aa2591c612dfa44da92b83132f83d88
Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Kamen Mazdrashki &lt;kamenim@samba.org&gt;

Autobuild-User(master): Andrew Bartlett &lt;abartlet@samba.org&gt;
Autobuild-Date(master): Thu Sep 11 08:50:16 CEST 2014 on sn-devel-104
</pre>
</div>
</content>
</entry>
<entry>
<title>torture: allow us to correctly use sizeof(buf) in raw.open tests</title>
<updated>2014-09-08T05:26:34+00:00</updated>
<author>
<name>Andrew Bartlett</name>
<email>abartlet@samba.org</email>
</author>
<published>2014-09-02T02:28:04+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=e93affbe1b4ff32858988bde79d00cdc82729089'/>
<id>e93affbe1b4ff32858988bde79d00cdc82729089</id>
<content type='text'>
This changes the sizeof(buf) from sizeof(void *), 8 on 64-bit machines, to sizeof("test") (eg 5).

Found by AddressSanitizer

Andrew Bartlett

Change-Id: I01f18b35c041f3b16be9f6da8ae5d1917d7e24d9
Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Kamen Mazdrashki &lt;kamenim@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This changes the sizeof(buf) from sizeof(void *), 8 on 64-bit machines, to sizeof("test") (eg 5).

Found by AddressSanitizer

Andrew Bartlett

Change-Id: I01f18b35c041f3b16be9f6da8ae5d1917d7e24d9
Signed-off-by: Andrew Bartlett &lt;abartlet@samba.org&gt;
Reviewed-by: Kamen Mazdrashki &lt;kamenim@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>torture: Use torture_assert macro for value check in raw.read</title>
<updated>2014-08-29T22:27:13+00:00</updated>
<author>
<name>Christof Schmitt</name>
<email>cs@samba.org</email>
</author>
<published>2014-08-07T21:44:23+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=f796694aaa08ca8bd3c08ec43541a88a1eb75517'/>
<id>f796694aaa08ca8bd3c08ec43541a88a1eb75517</id>
<content type='text'>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>torture: Use torture_assert macro for status check in raw.read</title>
<updated>2014-08-29T22:27:13+00:00</updated>
<author>
<name>Christof Schmitt</name>
<email>cs@samba.org</email>
</author>
<published>2014-08-07T21:40:00+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=d29362e85ebdf4450659641f889eebf5937f9345'/>
<id>d29362e85ebdf4450659641f889eebf5937f9345</id>
<content type='text'>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>torture: Use torture_fail macro in check_buffer for read requests</title>
<updated>2014-08-29T22:27:13+00:00</updated>
<author>
<name>Christof Schmitt</name>
<email>cs@samba.org</email>
</author>
<published>2014-08-07T21:31:42+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=ba8bc46c467c17f35ecea9064c91829c5be87136'/>
<id>ba8bc46c467c17f35ecea9064c91829c5be87136</id>
<content type='text'>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>torture: Add test for 16 bit alignment of readx data</title>
<updated>2014-08-29T22:27:13+00:00</updated>
<author>
<name>Christof Schmitt</name>
<email>cs@samba.org</email>
</author>
<published>2014-08-07T21:25:13+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=61dbb57475eda861fabf38ab61dc6109159ed524'/>
<id>61dbb57475eda861fabf38ab61dc6109159ed524</id>
<content type='text'>
MS-CIFS requires a one byte pad to guarantee 16 bit alignment of the
data:

Pad (1 byte): This field is optional. When using the NT LAN Manager
dialect, this field can be used to align the Data field to a 16-bit
boundary relative to the start of the SMB Header. If Unicode strings are
being used, this field MUST be present. When used, this field MUST be
one padding byte long.

Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
MS-CIFS requires a one byte pad to guarantee 16 bit alignment of the
data:

Pad (1 byte): This field is optional. When using the NT LAN Manager
dialect, this field can be used to align the Data field to a 16-bit
boundary relative to the start of the SMB Header. If Unicode strings are
being used, this field MUST be present. When used, this field MUST be
one padding byte long.

Signed-off-by: Christof Schmitt &lt;cs@samba.org&gt;
Reviewed-by: Volker Lendecke &lt;vl@samba.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>s4: torture: Add a new lock test to show that the Samba SMB1 multi-lock implementation is (currently) correct.</title>
<updated>2014-07-08T08:16:59+00:00</updated>
<author>
<name>Jeremy Allison</name>
<email>jra@samba.org</email>
</author>
<published>2014-07-07T18:00:13+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/pviktori/public_git/samba.git/commit/?id=c324b9f03f85d724dfde8e85f08d5f20fa2796ac'/>
<id>c324b9f03f85d724dfde8e85f08d5f20fa2796ac</id>
<content type='text'>
Needed as there was a proposal to re-architect
our multi-lock to dispense with lock order precedence,
which isn't how Windows does it (unfortunately,
as the new code would have been cleaner :-).
Tested against the Win2k12 SMB1 implementation.

This test is designed to show that
lock precedence on the server is based
on the order received, not on the ability
to grant. For example:

A blocked lock request containing 2 locks
will be satified before a subsequent blocked
lock request over one of the same regions,
even if that region is then unlocked. E.g.

(a) lock 100-&gt;109, 120-&gt;129 (granted)
(b) lock 100-&gt;109, 120-129 (blocks)
(c) lock 100-&gt;109          (blocks)
(d) unlock 100-&gt;109

lock (c) will not be granted as lock (b)
will take precedence.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;

Autobuild-User(master): Andreas Schneider &lt;asn@cryptomilk.org&gt;
Autobuild-Date(master): Tue Jul  8 10:16:59 CEST 2014 on sn-devel-104
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Needed as there was a proposal to re-architect
our multi-lock to dispense with lock order precedence,
which isn't how Windows does it (unfortunately,
as the new code would have been cleaner :-).
Tested against the Win2k12 SMB1 implementation.

This test is designed to show that
lock precedence on the server is based
on the order received, not on the ability
to grant. For example:

A blocked lock request containing 2 locks
will be satified before a subsequent blocked
lock request over one of the same regions,
even if that region is then unlocked. E.g.

(a) lock 100-&gt;109, 120-&gt;129 (granted)
(b) lock 100-&gt;109, 120-129 (blocks)
(c) lock 100-&gt;109          (blocks)
(d) unlock 100-&gt;109

lock (c) will not be granted as lock (b)
will take precedence.

Signed-off-by: Jeremy Allison &lt;jra@samba.org&gt;
Reviewed-by: Andreas Schneider &lt;asn@samba.org&gt;

Autobuild-User(master): Andreas Schneider &lt;asn@cryptomilk.org&gt;
Autobuild-Date(master): Tue Jul  8 10:16:59 CEST 2014 on sn-devel-104
</pre>
</div>
</content>
</entry>
</feed>
