Jeremy.
(cherry picked from commit 0bae1ef3de8fda5e1e2d641b14a408e627396912)
(This used to be commit db2acaf46fdc38078b6b28b68909e289f6c9e0ec)

(cherry picked from commit 74c8575b3f3b90ea21ae6aa7ccd95947838af956)
(This used to be commit 8fd54bb55f0c23bd025d1719abcbe75c6a2ea8ac)

With the ctdb checkin dde9f3f006 tdb optimized out write lock checks for
write-enabled transaction. Sadly, this also removed the possibility to ever
remove dead records left over from tdb_delete calls within a transaction.

Tridge, please check this! Did dde9f3f006 have any reason beyond performance
optimizations?

Thanks,

Volker
(cherry picked from commit 3f884c4ae36f3260e63626bdd4989d9258ae6497)
(This used to be commit 1d85e0647e287d269b3f6b534da88f497d6f76c3)

This reverts commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115.

This fix is not valid:

1. convert_string() is not only used for key strings but also for data.

2. Some databases use string_tdb_data() i.e. non-null-terminated strings
   as keynames and others (like the one I was using), use
   string_term_tdb_data(), i.e. zero-terminated key strings.

After discussion with Metze, the easiest (and proper way) to
handle this is to specify key names as "keyname\0" for databases
which use string_term_tdb_data().

Sorry for the noise...

Michael
(This used to be commit 17c012c4645f4e9542537c15f80d9b4e74304d11)

This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.

It seems that it fixes bug #2344 ...

Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)

Michael
(This used to be commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115)

(This used to be commit 22e7bcfbe4534c070ac2dd5f39773ea023dfa7f7)

(This used to be commit 3d798a1440603b7929955f2120f09ba1482885a1)

(This used to be commit 3563d62663c36ff267011f1f6f9b256be21c32fb)

(This used to be commit 8ee4f075046e0b181ec8a4ac1eaf3ea5621a56bf)