samba.git/source4/heimdal/lib, branch master

heimdal: Fix CID 1273430 Double free

2015-03-06T16:38:09+00:00

I think Coverity is right here: Before the preceding call to
krb5_make_principal we already krb5_free_principal(ctx, tmp_creds.server)
without wiping out tmp_creds.server. The call to krb5_make_principal only
stores something fresh when it also returns 0 a.k.a. success.

Signed-off-by: Volker Lendecke 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Fri Mar  6 17:38:09 CET 2015 on sn-devel-104

Fix the O3 developer build

2015-03-03T12:14:53+00:00

Different gcc versions complain at different places

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Mar  3 13:14:53 CET 2015 on sn-devel-104

heimdal: Fix the developer O3 build

2015-02-25T13:02:09+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy

s4-heimdal: fix krb5_get_init_creds_opt_set_process_last_req().

2014-08-08T04:02:35+00:00

Most probably just a copy/paste error.

Guenther

Signed-off-by: Günther Deschner 
Reviewed-by: Andrew Bartlett

heimdal: Use krb5_free_default_realm() for free()

2014-02-21T14:59:28+00:00

The resource allocated by krb5_default_default_realm() should be
free()'d by krb5_free_default_realm() instead of plain free()
for better readability.

Signed-off-by: Santosh Kumar Pradhan 
Reviewed-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

heimdal: Fix a format error on FreeBSD10

2014-01-24T21:42:38+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison

heimdal: Fix CID 745516 Use after free

2013-11-14T18:17:06+00:00

If the loop is exited normally, i.e. we did not find anything proper
within DH_NUM_TRIES, we try to BN_free a second time.

Signed-off-by: Volker Lendecke 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Thu Nov 14 19:17:06 CET 2013 on sn-devel-104

heimdal: Fix CID 240779 Allocation size mismatch

2013-11-13T10:05:44+00:00

The error Coverity complains about is in the malloc. krb5_enctypes is
an enum, so it is usually smaller than the size of a pointer. So we
overallocate, but in the memcpy further down we copy from potentially
invalid memory.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed Nov 13 11:05:44 CET 2013 on sn-devel-104

heimdal: Fix CID 241943 Uninitialized pointer read

2013-11-13T08:01:55+00:00

In the error case without EXTRA_ADDRESSES we access ignore_addresses
without initialization

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

heimdal: Fix 241482 Resource leak

2013-11-11T20:04:09+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Ira Cooper