samba.git/source4/heimdal/lib/krb5, branch master

heimdal: Fix CID 1273430 Double free

2015-03-06T16:38:09+00:00

I think Coverity is right here: Before the preceding call to
krb5_make_principal we already krb5_free_principal(ctx, tmp_creds.server)
without wiping out tmp_creds.server. The call to krb5_make_principal only
stores something fresh when it also returns 0 a.k.a. success.

Signed-off-by: Volker Lendecke 
Reviewed-by: David Disseldorp 

Autobuild-User(master): David Disseldorp 
Autobuild-Date(master): Fri Mar  6 17:38:09 CET 2015 on sn-devel-104

Fix the O3 developer build

2015-03-03T12:14:53+00:00

Different gcc versions complain at different places

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Mar  3 13:14:53 CET 2015 on sn-devel-104

heimdal: Fix the developer O3 build

2015-02-25T13:02:09+00:00

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy

s4-heimdal: fix krb5_get_init_creds_opt_set_process_last_req().

2014-08-08T04:02:35+00:00

Most probably just a copy/paste error.

Guenther

Signed-off-by: Günther Deschner 
Reviewed-by: Andrew Bartlett

heimdal: Use krb5_free_default_realm() for free()

2014-02-21T14:59:28+00:00

The resource allocated by krb5_default_default_realm() should be
free()'d by krb5_free_default_realm() instead of plain free()
for better readability.

Signed-off-by: Santosh Kumar Pradhan 
Reviewed-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

heimdal: Fix CID 240779 Allocation size mismatch

2013-11-13T10:05:44+00:00

The error Coverity complains about is in the malloc. krb5_enctypes is
an enum, so it is usually smaller than the size of a pointer. So we
overallocate, but in the memcpy further down we copy from potentially
invalid memory.

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Wed Nov 13 11:05:44 CET 2013 on sn-devel-104

heimdal: Fix CID 241943 Uninitialized pointer read

2013-11-13T08:01:55+00:00

In the error case without EXTRA_ADDRESSES we access ignore_addresses
without initialization

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider

heimdal:lib/krb5: don't name a struct 'token'

2012-06-16T13:20:58+00:00

This is a static const struct and the name is never used,
so just make it an anonymous struct.

This hopefully fixes the build on AIX:

"../source4/heimdal/lib/roken/roken-common.h", line 276.9: 1506-236 (W) Macro name __attribute__ has been redefined.
"../source4/heimdal/lib/roken/roken-common.h", line 276.9: 1506-358 (I) "__attribute__" is defined on line 45 of ../source4/heimdal/lib/com_err/com_err.h.
"../source4/heimdal/lib/krb5/expand_path.c", line 331.21: 1506-334 (S) Identifier token has already been defined on line 98 of "/usr/include/net/if_arp.h".
"../source4/heimdal/lib/krb5/expand_path.c", line 390.43: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 391.31: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 392.20: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 392.48: 1506-019 (S) Expecting an array or a pointer to object type.
"../source4/heimdal/lib/krb5/expand_path.c", line 393.39: 1506-019 (S) Expecting an array or a pointer to object type.
Waf: Leaving directory `/opt/home/build/build_farm/samba_4_0_test/bin'
Build failed:  -> task failed (err #1):
	{task: cc expand_path.c -> expand_path_52.o}
gmake: *** [all] Error 1

metze

Autobuild-User(master): Stefan Metzmacher 
Autobuild-Date(master): Sat Jun 16 15:20:59 CEST 2012 on sn-devel-104

s4:heimdal: fix use of a non-existent word (existant)

2012-06-12T05:21:44+00:00

heimdal: Fix the build on FreeBSD

2012-03-01T02:51:31+00:00

We don't have BACKTRACE_SYMBOLS by default