samba.git/source3/rpc_server/spoolss, branch master

spoolss: retrieve published printer GUID if not in registry

2015-02-18T11:43:44+00:00

When a printer is published, the GUID for the published DN is retrieved
from the domain controller and stored in the registry.
When handling a spoolss GetPrinter(level=7) request, the same GUID is
obtained from the registry and returned to the client.

This change sees the spoolss server query the DC for the published
printer GUID if it is not present in the registry when handling a
spoolss GetPrinter(level=7) request.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11018

Pair-Programmed-With: David Disseldorp 
Signed-off-by: Andreas Schneider 
Signed-off-by: David Disseldorp 
Reviewed-by: Guenther Deschner 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Wed Feb 18 12:43:44 CET 2015 on sn-devel-104

spoolss: clear PrinterInfo on GetPrinter error

2014-12-19T14:40:43+00:00

If an error is returned without zeroing a pre-allocated @info pointer,
then marshalling of the response will fail.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

spoolss: clear info on GetPrinterDriverDirectory error

2014-12-19T14:40:43+00:00

If an error is returned without zeroing a pre-allocated @info pointer,
then marshalling of the response will fail.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

spoolss: clear info on GetPrintProcessorDirectory error

2014-12-19T14:40:43+00:00

If an error is returned without zeroing a pre-allocated @info pointer,
then marshalling of the response will fail.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

spoolss: clear FormInfo on GetForm error

2014-12-19T14:40:43+00:00

In handling a spoolss GetForm request, the handler may return an
immediate error if one of the input parameters is invalid.  If this is
done without zeroing the pre-allocated @info pointer, then marshalling
of the response will fail.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

spoolss: clear DriverInfo on GetPrinterDriver2 error

2014-12-19T14:40:42+00:00

In handling a spoolss GetPrinterDriver2 request, the handler may
return an immediate error if one of the input parameters is invalid.
If this is done without zeroing the pre-allocated @info pointer, then
marshalling of the response will fail.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

spoolss: clear JobInfo on GetJob error

2014-12-19T14:40:42+00:00

In handling a spoolss GetJob request, the _spoolss_GetJob() handler may
return an immediate error if one of the input parameters is invalid. If
this is done without zeroing the pre-allocated @info pointer, then
api_spoolss_GetJob() will attempt to marshall @info, which in the case
of an @offered value of zero results in a marshalling error:

ndr_push_error(7): Bad subcontext (PUSH) content_size 64 is larger
than size_is(0)

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10984

Signed-off-by: David Disseldorp 
Reviewed-by: Andreas Schneider

samba: pass down size_t instead of int to add_string_to_array().

2014-11-17T18:53:22+00:00

Guenther

Signed-off-by: Günther Deschner 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Günther Deschner 
Autobuild-Date(master): Mon Nov 17 19:53:22 CET 2014 on sn-devel-104

spoolss: remove unused fill_job_info3()

2014-10-30T05:52:04+00:00

This logic has been moved into the previous EnumJobs(level=3) caller.
The info3 structure only contains two fields that are used, so it
doesn't make sense to have a separate helper for it.

Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison

spoolss: fix jobid in level 3 EnumJobs response

2014-10-30T05:52:04+00:00

Until now, these responses have incorrectly carried the printing backend
job identifier (sysjob), rather than the one allocated and returned by
Samba on job submission.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10905

Reported-by: Franz Pförtsch 
Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison