metze
(This used to be commit bdb8ed24488fd87cd30dd18744feeef0bd4b2c18)

(cherry picked from commit 8cb07814bc6627fc8eba228eafd13336e3ca3758)
(This used to be commit 7d85b8d076d6b5b1773c44cd527e016b5d319da5)

(cherry picked from commit 6f88c41c31271fd4b634b6393dc4ca44563a88d2)
(This used to be commit 830f99fb5d73c999bb0975828bab6e5f7537baf6)

Jeremy.
(This used to be commit 0bae1ef3de8fda5e1e2d641b14a408e627396912)

(This used to be commit 74c8575b3f3b90ea21ae6aa7ccd95947838af956)

With the ctdb checkin dde9f3f006 tdb optimized out write lock checks for
write-enabled transaction. Sadly, this also removed the possibility to ever
remove dead records left over from tdb_delete calls within a transaction.

Tridge, please check this! Did dde9f3f006 have any reason beyond performance
optimizations?

Thanks,

Volker
(This used to be commit 3f884c4ae36f3260e63626bdd4989d9258ae6497)

This reverts commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115.

This fix is not valid:

1. convert_string() is not only used for key strings but also for data.

2. Some databases use string_tdb_data() i.e. non-null-terminated strings
   as keynames and others (like the one I was using), use
   string_term_tdb_data(), i.e. zero-terminated key strings.

After discussion with Metze, the easiest (and proper way) to
handle this is to specify key names as "keyname\0" for databases
which use string_term_tdb_data().

Sorry for the noise...

Michael
(cherry picked from commit 17c012c4645f4e9542537c15f80d9b4e74304d11)
(This used to be commit 42c953c106b3da90e8c3452c4a246392502c200d)

This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.

It seems that it fixes bug #2344 ...

Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)

Michael
(This used to be commit 9be6b46f7715cdc7f77308d7613e8df73effe3c1)

used for tdb_traverse() to tdb_traverse_read().
Jeremy.
(This used to be commit bda0f03fb3fa8a7b14d4f54bee7076d691cad44f)