samba.git/lib/ldb, branch master

pyldb: Add tests for type errors

2015-03-04T00:49:02+00:00

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Mar  4 01:49:02 CET 2015 on sn-devel-104

pyldb: Report errors converting controls list to char**

2015-03-03T22:20:06+00:00

With this change, passing an unexpected type to the CRUD methods
will result in an informative TypeError.

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

pyldb: Better error reporting

2015-03-03T22:20:06+00:00

Provide more useful error messages for some type errors

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

pyldb: Type-check arguments parsed with PyArg_ParseTuple*

2015-03-03T22:20:06+00:00

PyObject* arguments need to be type-checked before they're
cast to subtypes.

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

pyldb: Fix reference leaks

2015-03-03T22:20:06+00:00

The parse_ldif and MessageElement.__iter__ functions leaked references
to intermediate lists whose iterators they return.

The MessageElement repr used the undocumented macro PyObject_REPR, which
leaks references. (It was used internally in CPython before fatal errors,
and will be removed in Python 3.5.)

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

pyldb: Remove use of staticforward macro

2015-03-03T22:20:06+00:00

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

pyldb: Properly preallocate result control list

2015-03-03T22:20:06+00:00

The list was always allocated with size 1, so
if there is more than 1 result control, the additional
items would not be added in the list, and would
become leaked references.

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

pyldb: Use the Py_TYPE macro

2015-03-03T22:20:06+00:00

The "ob_type" member of Python objects is going away
in Python 3 for compliance with C's strict aliasing rules.
The Py_TYPE macro should be used instead.

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

pyldb: Correct reference counting when returning bools

2015-03-03T22:20:06+00:00

Simply returning Py_True/PyFalse doesn't increment the bool object's
reference count.

Signed-off-by: Petr Viktorin 
Reviewed-by: Jelmer Vernooij 
Reviewed-by: Andrew Bartlett

Fix the O3 developer build

2015-03-03T12:14:53+00:00

Different gcc versions complain at different places

Signed-off-by: Volker Lendecke 
Reviewed-by: Alexander Bokovoy 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Tue Mar  3 13:14:53 CET 2015 on sn-devel-104