From 3e9feb8d9af56fc29718376fd8505f6c94e6c3b6 Mon Sep 17 00:00:00 2001 From: James Shubin Date: Mon, 16 Sep 2013 01:40:22 -0400 Subject: Nitpick cleanups. --- manifests/brick.pp | 14 +++++++------- manifests/server.pp | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) (limited to 'manifests') diff --git a/manifests/brick.pp b/manifests/brick.pp index 889b752..2ac1d6e 100644 --- a/manifests/brick.pp +++ b/manifests/brick.pp @@ -163,17 +163,17 @@ define gluster::brick( '/bin/false', # TODO: add more criteria ], require => $exec_requires, - timeout => 3600, # set to something very long + timeout => 3600, # set to something very long noop => $exec_noop, alias => "gluster-brick-make-${name}", } # make an empty directory for the mount point file { "${valid_path}": - ensure => directory, # make sure this is a directory - recurse => false, # don't recurse into directory - purge => false, # don't purge unmanaged files - force => false, # don't purge subdirs and links + ensure => directory, # make sure this is a directory + recurse => false, # don't recurse into directory + purge => false, # don't purge unmanaged files + force => false, # don't purge subdirs and links require => Exec["gluster-brick-make-${name}"], } @@ -185,12 +185,12 @@ define gluster::brick( fstype => "${valid_fstype}", # noatime,nodiratime to save gluster from silly updates options => "${mount_options},${ro_bool},noatime,nodiratime,noexec", # TODO: is nodev? nosuid? noexec? a good idea? - dump => '0', # fs_freq: 0 to skip file system dumps + dump => '0', # fs_freq: 0 to skip file system dumps # NOTE: technically this should be '2', to `fsck.xfs` # after the rootfs ('1'), but fsck.xfs actually does # 'nothing, successfully', so it's irrelevant, because # xfs uses xfs_check and friends only when suspect. - pass => '2', # fs_passno: 0 to skip fsck on boot + pass => '2', # fs_passno: 0 to skip fsck on boot require => [ File["${valid_path}"], ], diff --git a/manifests/server.pp b/manifests/server.pp index f98078a..33ebf7d 100644 --- a/manifests/server.pp +++ b/manifests/server.pp @@ -66,7 +66,7 @@ class gluster::server( file { '/var/lib/glusterd/peers/': ensure => directory, # make sure this is a directory - recurse => true, # recursively manage directory + recurse => true, # recursively manage directory purge => true, force => true, owner => root, @@ -124,10 +124,10 @@ class gluster::server( # start service only after the firewall is opened and hosts are defined service { 'glusterd': - enable => true, # start on boot - ensure => running, # ensure it stays running - hasstatus => false, # FIXME: BUG: https://bugzilla.redhat.com/show_bug.cgi?id=836007 - hasrestart => true, # use restart, not start; stop + enable => true, # start on boot + ensure => running, # ensure it stays running + hasstatus => false, # FIXME: BUG: https://bugzilla.redhat.com/show_bug.cgi?id=836007 + hasrestart => true, # use restart, not start; stop } } -- cgit