From 69420a154fc9fb8b04f437125a6a0604b26b1292 Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgallagh@redhat.com>
Date: Fri, 16 Dec 2011 11:13:55 -0500
Subject: Securely set umask when using mkstemp

Coverity 12394, 12395, 12396, 12397 and 12398
---
 src/tests/debug-tests.c | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'src/tests/debug-tests.c')

diff --git a/src/tests/debug-tests.c b/src/tests/debug-tests.c
index 8a338fb5..40dd2e98 100644
--- a/src/tests/debug-tests.c
+++ b/src/tests/debug-tests.c
@@ -191,10 +191,14 @@ int test_helper_debug_check_message(int level, int msgmode)
     int fd;
     int ret;
     int _errno = 0;
+    mode_t old_umask;
     FILE *file = NULL;
 
     strncpy(filename, "sssd_debug_tests.XXXXXX", 24);
+
+    old_umask = umask(077);
     fd = mkstemp(filename);
+    umask(old_umask);
     if (fd == -1) {
         _errno = errno;
         talloc_free(ctx);
@@ -331,10 +335,14 @@ int test_helper_debug_is_empty_message(int level, int msgmode)
     int filesize;
     int ret;
     int _errno = 0;
+    mode_t old_umask;
     FILE *file;
 
     strncpy(filename, "sssd_debug_tests.XXXXXX", 24);
+
+    old_umask = umask(077);
     fd = mkstemp(filename);
+    umask(old_umask);
     if (fd == -1) {
         return DEBUG_TEST_ERROR;
     }
-- 
cgit