From 8bbf89c5ab798c112773fe23515c3a9df56dde71 Mon Sep 17 00:00:00 2001 From: Nick Guay Date: Wed, 18 Jul 2012 11:55:35 -0400 Subject: Fix uninitialized values https://fedorahosted.org/sssd/ticket/1379 --- src/responder/nss/nsssrv_services.c | 6 +++--- src/responder/pam/pamsrv_cmd.c | 2 +- src/responder/sudo/sudosrv_dp.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/responder') diff --git a/src/responder/nss/nsssrv_services.c b/src/responder/nss/nsssrv_services.c index e0ee21c3..90698231 100644 --- a/src/responder/nss/nsssrv_services.c +++ b/src/responder/nss/nsssrv_services.c @@ -597,7 +597,8 @@ fill_service(struct sss_packet *packet, errno_t ret; unsigned int msg_count = *count; size_t rzero, rsize, aptr; - unsigned int num, i, j; + unsigned int num = 0; + unsigned int i, j; uint32_t num_aliases, written_aliases; struct ldb_message *msg; struct ldb_message_element *el; @@ -623,7 +624,6 @@ fill_service(struct sss_packet *packet, rzero = 2 * sizeof(uint32_t); rsize = 0; - num = 0; for (i = 0; i < msg_count; i++) { talloc_zfree(tmp_ctx); tmp_ctx = talloc_new(NULL); @@ -1472,7 +1472,7 @@ static void setservent_step_done(struct tevent_req *req) { errno_t ret; - struct ldb_result *res; + struct ldb_result *res = NULL; struct setent_step_ctx *step_ctx = tevent_req_callback_data(req, struct setent_step_ctx); struct nss_dom_ctx *dctx = step_ctx->dctx; diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c index 20de738f..e66debe2 100644 --- a/src/responder/pam/pamsrv_cmd.c +++ b/src/responder/pam/pamsrv_cmd.c @@ -368,7 +368,7 @@ static errno_t get_selinux_string(struct pam_auth_req *preq) errno_t ret; int i, j; size_t order_count; - size_t len; + size_t len = 0; tmp_ctx = talloc_new(NULL); if (tmp_ctx == NULL) { diff --git a/src/responder/sudo/sudosrv_dp.c b/src/responder/sudo/sudosrv_dp.c index 2063b291..208606c2 100644 --- a/src/responder/sudo/sudosrv_dp.c +++ b/src/responder/sudo/sudosrv_dp.c @@ -58,7 +58,7 @@ sss_dp_get_sudoers_send(TALLOC_CTX *mem_ctx, struct sss_dp_req_state *state; struct sss_dp_get_sudoers_info *info; errno_t ret; - char *key; + char *key = NULL; req = tevent_req_create(mem_ctx, &state, struct sss_dp_req_state); if (!req) { -- cgit