diff options
| author | Jakub Hrozek <jhrozek@redhat.com> | 2012-04-25 17:15:21 +0200 |
|---|---|---|
| committer | Stephen Gallagher <sgallagh@redhat.com> | 2012-05-03 11:46:17 -0400 |
| commit | c9041cb7addc1a49e0771246d17de101662fbcbc (patch) | |
| tree | f5b94be10422e350275c49ee1798cd7cd625c64a | |
| parent | 3353308213d623b2ad0f0044859039c0f8cb7ef5 (diff) | |
| download | sssd_unused-c9041cb7addc1a49e0771246d17de101662fbcbc.tar.gz sssd_unused-c9041cb7addc1a49e0771246d17de101662fbcbc.tar.xz sssd_unused-c9041cb7addc1a49e0771246d17de101662fbcbc.zip | |
PROXY: return correct return codes
We were reporting on the value of "status" instead of "ret'. We also
didn't set ret to EOK in cases group contained no members.
| -rw-r--r-- | src/providers/proxy/proxy_id.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/src/providers/proxy/proxy_id.c b/src/providers/proxy/proxy_id.c index e1325b74..8a8c7ca8 100644 --- a/src/providers/proxy/proxy_id.c +++ b/src/providers/proxy/proxy_id.c @@ -143,8 +143,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_OP_FAILURE, - ("proxy -> getpwnam_r failed for '%s' <%d>\n", - name, status)); + ("proxy -> getpwnam_r failed for '%s' <%d>: %s\n", + name, ret, strerror(ret))); } return ret; } @@ -334,7 +334,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_CRIT_FAILURE, - ("proxy -> getpwuid_r failed for '%d' <%d>\n", uid, status)); + ("proxy -> getpwuid_r failed for '%d' <%d>: %s\n", + uid, ret, strerror(ret))); } return ret; } @@ -656,6 +657,7 @@ static errno_t proxy_process_missing_users(struct sysdb_ctx *sysdb, } } + ret = EOK; done: talloc_free(tmp_ctx); return ret; @@ -848,8 +850,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_OP_FAILURE, - ("proxy -> getgrnam_r failed for '%s' <%d>\n", - name, status)); + ("proxy -> getgrnam_r failed for '%s' <%d>: %s\n", + name, ret, strerror(ret))); } return ret; } @@ -917,8 +919,8 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_OP_FAILURE, - ("proxy -> getgrgid_r failed for '%d' <%d>\n", - gid, status)); + ("proxy -> getgrgid_r failed for '%d' <%d>: %s\n", + gid, ret, strerror(ret))); } return ret; } |