summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2011-09-29 20:25:04 +0200
committerStephen Gallagher <sgallagh@redhat.com>2011-10-03 10:49:49 -0400
commitf8bdb0c652f111ae59ac70a8e93bb40d32bec40d (patch)
tree0abc5a9d6ca26ff06c8d80748dcae63d56c35f4a
parent2f0eb4434eab740b0cdb2e33f2a2f0d3fbe143b7 (diff)
downloadsssd_unused-f8bdb0c652f111ae59ac70a8e93bb40d32bec40d.tar.gz
sssd_unused-f8bdb0c652f111ae59ac70a8e93bb40d32bec40d.tar.xz
sssd_unused-f8bdb0c652f111ae59ac70a8e93bb40d32bec40d.zip
Use explicit base 10 for converting strings to integers
https://fedorahosted.org/sssd/ticket/1013
-rw-r--r--src/db/sysdb.c2
-rw-r--r--src/db/sysdb_ops.c2
-rw-r--r--src/providers/ldap/ldap_id.c4
-rw-r--r--src/providers/proxy/proxy_id.c4
-rw-r--r--src/responder/common/negcache.c4
5 files changed, 8 insertions, 8 deletions
diff --git a/src/db/sysdb.c b/src/db/sysdb.c
index cae8b457..4286589e 100644
--- a/src/db/sysdb.c
+++ b/src/db/sysdb.c
@@ -372,7 +372,7 @@ int sysdb_attrs_get_uint32_t(struct sysdb_attrs *attrs, const char *name,
}
errno = 0;
- val = strtouint32((const char *) el->values[0].data, &endptr, 0);
+ val = strtouint32((const char *) el->values[0].data, &endptr, 10);
if (errno != 0) return errno;
if (*endptr) return EINVAL;
diff --git a/src/db/sysdb_ops.c b/src/db/sysdb_ops.c
index a7911de4..94e5adc0 100644
--- a/src/db/sysdb_ops.c
+++ b/src/db/sysdb_ops.c
@@ -60,7 +60,7 @@ static uint32_t get_attr_as_uint32(struct ldb_message *msg, const char *attr)
}
errno = 0;
- l = strtoll((const char *)v->data, NULL, 0);
+ l = strtoll((const char *)v->data, NULL, 10);
if (errno) {
return (uint32_t)-1;
}
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index be347e17..761086fb 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -236,7 +236,7 @@ static void users_get_done(struct tevent_req *subreq)
break;
case BE_FILTER_IDNUM:
- uid = (uid_t) strtouint32(state->name, &endptr, 0);
+ uid = (uid_t) strtouint32(state->name, &endptr, 10);
if (errno || *endptr || (state->name == endptr)) {
tevent_req_error(req, errno ? errno : EINVAL);
return;
@@ -481,7 +481,7 @@ static void groups_get_done(struct tevent_req *subreq)
break;
case BE_FILTER_IDNUM:
- gid = (gid_t) strtouint32(state->name, &endptr, 0);
+ gid = (gid_t) strtouint32(state->name, &endptr, 10);
if (errno || *endptr || (state->name == endptr)) {
tevent_req_error(req, errno ? errno : EINVAL);
return;
diff --git a/src/providers/proxy/proxy_id.c b/src/providers/proxy/proxy_id.c
index 5ce9095b..a5733b12 100644
--- a/src/providers/proxy/proxy_id.c
+++ b/src/providers/proxy/proxy_id.c
@@ -1080,7 +1080,7 @@ void proxy_get_account_info(struct be_req *breq)
break;
case BE_FILTER_IDNUM:
- uid = (uid_t) strtouint32(ar->filter_value, &endptr, 0);
+ uid = (uid_t) strtouint32(ar->filter_value, &endptr, 10);
if (errno || *endptr || (ar->filter_value == endptr)) {
return proxy_reply(breq, DP_ERR_FATAL,
EINVAL, "Invalid attr type");
@@ -1102,7 +1102,7 @@ void proxy_get_account_info(struct be_req *breq)
ret = get_gr_name(breq, ctx, sysdb, domain, ar->filter_value);
break;
case BE_FILTER_IDNUM:
- gid = (gid_t) strtouint32(ar->filter_value, &endptr, 0);
+ gid = (gid_t) strtouint32(ar->filter_value, &endptr, 10);
if (errno || *endptr || (ar->filter_value == endptr)) {
return proxy_reply(breq, DP_ERR_FATAL,
EINVAL, "Invalid attr type");
diff --git a/src/responder/common/negcache.c b/src/responder/common/negcache.c
index d8c4c269..3926574a 100644
--- a/src/responder/common/negcache.c
+++ b/src/responder/common/negcache.c
@@ -90,7 +90,7 @@ static int sss_ncache_check_str(struct sss_nc_ctx *ctx, char *str, int ttl)
}
errno = 0;
- timestamp = strtoull((const char *)data.dptr, &ep, 0);
+ timestamp = strtoull((const char *)data.dptr, &ep, 10);
if (errno != 0 || *ep != '\0') {
/* Malformed entry, remove it and return no entry */
expired = true;
@@ -330,7 +330,7 @@ static int delete_permanent(struct tdb_context *tdb,
}
errno = 0;
- timestamp = strtoull((const char *)data.dptr, &ep, 0);
+ timestamp = strtoull((const char *)data.dptr, &ep, 10);
if (errno != 0 || *ep != '\0') {
/* Malformed entry, remove it */
remove_key = true;