summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2011-09-29 20:25:04 +0200
committerStephen Gallagher <sgallagh@redhat.com>2011-10-03 10:49:36 -0400
commit519c9ac794ec4ad95ff43fbadf688fe39e745128 (patch)
treec795f80334faf96fd2bb35c769c1c4fb2c14505e
parentb21db8aeb3b8ee2148e884fa5aa65fd477181669 (diff)
downloadsssd_unused-519c9ac794ec4ad95ff43fbadf688fe39e745128.tar.gz
sssd_unused-519c9ac794ec4ad95ff43fbadf688fe39e745128.tar.xz
sssd_unused-519c9ac794ec4ad95ff43fbadf688fe39e745128.zip
Use explicit base 10 for converting strings to integers
https://fedorahosted.org/sssd/ticket/1013
-rw-r--r--src/db/sysdb.c2
-rw-r--r--src/db/sysdb_ops.c2
-rw-r--r--src/providers/ldap/ldap_id.c4
-rw-r--r--src/providers/proxy/proxy_id.c4
-rw-r--r--src/responder/common/negcache.c4
5 files changed, 8 insertions, 8 deletions
diff --git a/src/db/sysdb.c b/src/db/sysdb.c
index 880cd622..ced69b25 100644
--- a/src/db/sysdb.c
+++ b/src/db/sysdb.c
@@ -364,7 +364,7 @@ int sysdb_attrs_get_uint32_t(struct sysdb_attrs *attrs, const char *name,
}
errno = 0;
- val = strtouint32((const char *) el->values[0].data, &endptr, 0);
+ val = strtouint32((const char *) el->values[0].data, &endptr, 10);
if (errno != 0) return errno;
if (*endptr) return EINVAL;
diff --git a/src/db/sysdb_ops.c b/src/db/sysdb_ops.c
index 08437f6d..52e63416 100644
--- a/src/db/sysdb_ops.c
+++ b/src/db/sysdb_ops.c
@@ -60,7 +60,7 @@ static uint32_t get_attr_as_uint32(struct ldb_message *msg, const char *attr)
}
errno = 0;
- l = strtoll((const char *)v->data, NULL, 0);
+ l = strtoll((const char *)v->data, NULL, 10);
if (errno) {
return (uint32_t)-1;
}
diff --git a/src/providers/ldap/ldap_id.c b/src/providers/ldap/ldap_id.c
index c6a11f48..709f2ca0 100644
--- a/src/providers/ldap/ldap_id.c
+++ b/src/providers/ldap/ldap_id.c
@@ -226,7 +226,7 @@ static void users_get_done(struct tevent_req *subreq)
break;
case BE_FILTER_IDNUM:
- uid = (uid_t) strtouint32(state->name, &endptr, 0);
+ uid = (uid_t) strtouint32(state->name, &endptr, 10);
if (errno || *endptr || (state->name == endptr)) {
tevent_req_error(req, errno ? errno : EINVAL);
return;
@@ -462,7 +462,7 @@ static void groups_get_done(struct tevent_req *subreq)
break;
case BE_FILTER_IDNUM:
- gid = (gid_t) strtouint32(state->name, &endptr, 0);
+ gid = (gid_t) strtouint32(state->name, &endptr, 10);
if (errno || *endptr || (state->name == endptr)) {
tevent_req_error(req, errno ? errno : EINVAL);
return;
diff --git a/src/providers/proxy/proxy_id.c b/src/providers/proxy/proxy_id.c
index 3df21063..e68d7f71 100644
--- a/src/providers/proxy/proxy_id.c
+++ b/src/providers/proxy/proxy_id.c
@@ -1078,7 +1078,7 @@ void proxy_get_account_info(struct be_req *breq)
break;
case BE_FILTER_IDNUM:
- uid = (uid_t) strtouint32(ar->filter_value, &endptr, 0);
+ uid = (uid_t) strtouint32(ar->filter_value, &endptr, 10);
if (errno || *endptr || (ar->filter_value == endptr)) {
return proxy_reply(breq, DP_ERR_FATAL,
EINVAL, "Invalid attr type");
@@ -1100,7 +1100,7 @@ void proxy_get_account_info(struct be_req *breq)
ret = get_gr_name(breq, ctx, sysdb, domain, ar->filter_value);
break;
case BE_FILTER_IDNUM:
- gid = (gid_t) strtouint32(ar->filter_value, &endptr, 0);
+ gid = (gid_t) strtouint32(ar->filter_value, &endptr, 10);
if (errno || *endptr || (ar->filter_value == endptr)) {
return proxy_reply(breq, DP_ERR_FATAL,
EINVAL, "Invalid attr type");
diff --git a/src/responder/common/negcache.c b/src/responder/common/negcache.c
index d8c4c269..3926574a 100644
--- a/src/responder/common/negcache.c
+++ b/src/responder/common/negcache.c
@@ -90,7 +90,7 @@ static int sss_ncache_check_str(struct sss_nc_ctx *ctx, char *str, int ttl)
}
errno = 0;
- timestamp = strtoull((const char *)data.dptr, &ep, 0);
+ timestamp = strtoull((const char *)data.dptr, &ep, 10);
if (errno != 0 || *ep != '\0') {
/* Malformed entry, remove it and return no entry */
expired = true;
@@ -330,7 +330,7 @@ static int delete_permanent(struct tdb_context *tdb,
}
errno = 0;
- timestamp = strtoull((const char *)data.dptr, &ep, 0);
+ timestamp = strtoull((const char *)data.dptr, &ep, 10);
if (errno != 0 || *ep != '\0') {
/* Malformed entry, remove it */
remove_key = true;