diff options
author | Lukas Slebodnik <lslebodn@redhat.com> | 2017-01-12 14:29:17 +0100 |
---|---|---|
committer | Lukas Slebodnik <lslebodn@redhat.com> | 2017-01-16 19:11:28 +0100 |
commit | 1fef02f87429597e82965a9870e4597e0fadf212 (patch) | |
tree | a76643b7becf4ad6479f6511149a7c30ef1dc988 /src/tests/intg/test_secrets.py | |
parent | c46dec3dfad9e83321cc9d3185d93f0e8c38f57e (diff) | |
download | sssd-1fef02f87429597e82965a9870e4597e0fadf212.tar.gz sssd-1fef02f87429597e82965a9870e4597e0fadf212.tar.xz sssd-1fef02f87429597e82965a9870e4597e0fadf212.zip |
intg: Avoid using xrange in tests
In Python 2 range() returns a list, and xrange() returns an object that
will only generate the items in the range when needed, saving memory.
In Python 3, the range() function is gone, and xrange() has been renamed
range().
We do not strictly require list or iterator in code therefore we can use
range which is in poth version. And we do not use big ranges there
so the memory overhead with list on python2 is not big.
Reviewed-by: Martin Basti <mbasti@redhat.com>
Diffstat (limited to 'src/tests/intg/test_secrets.py')
-rw-r--r-- | src/tests/intg/test_secrets.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/tests/intg/test_secrets.py b/src/tests/intg/test_secrets.py index 7a9de1aec..062dcb665 100644 --- a/src/tests/intg/test_secrets.py +++ b/src/tests/intg/test_secrets.py @@ -145,7 +145,7 @@ def test_crd_ops(setup_for_secrets, secrets_cli): MAX_SECRETS = 10 sec_value = "value" - for x in xrange(MAX_SECRETS): + for x in range(MAX_SECRETS): cli.set_secret(str(x), sec_value) with pytest.raises(HTTPError) as err507: @@ -153,7 +153,7 @@ def test_crd_ops(setup_for_secrets, secrets_cli): assert str(err507.value).startswith("507") # Delete all stored secrets used for max secrets tests - for x in xrange(MAX_SECRETS): + for x in range(MAX_SECRETS): cli.del_secret(str(x)) # Don't allow storing a secrets which has a payload larger @@ -198,7 +198,7 @@ def test_containers(setup_for_secrets, secrets_cli): # Don't allow creating a container after reaching the max nested level DEFAULT_CONTAINERS_NEST_LEVEL = 4 container = "mycontainer" - for x in xrange(DEFAULT_CONTAINERS_NEST_LEVEL): + for x in range(DEFAULT_CONTAINERS_NEST_LEVEL): container += "%s/" % str(x) cli.create_container(container) |