diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2017-06-02 11:56:55 +0200 |
|---|---|---|
| committer | Lukas Slebodnik <lslebodn@redhat.com> | 2017-06-05 17:09:27 +0200 |
| commit | c62dc2ac02253e130991db0f6acd60ce1a2753f1 (patch) | |
| tree | 2c109f7034db8c003ff0cdd901fe57dc73e7fd35 /src/sss_client | |
| parent | 283d589b3025a3cadaaddf330d3fb4dc4175968d (diff) | |
| download | sssd-c62dc2ac02253e130991db0f6acd60ce1a2753f1.tar.gz sssd-c62dc2ac02253e130991db0f6acd60ce1a2753f1.tar.xz sssd-c62dc2ac02253e130991db0f6acd60ce1a2753f1.zip | |
pam_sss: Fix checking of empty string cert_user
src/sss_client/pam_sss.c: In function ‘eval_response’:
src/sss_client/pam_sss.c:998:64: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
if (type == SSS_PAM_CERT_INFO && pi->cert_user == '\0') {
^~
src/sss_client/pam_sss.c:998:50: note: did you mean to dereference the pointer?
if (type == SSS_PAM_CERT_INFO && pi->cert_user == '\0') {
^
src/sss_client/pam_sss.c:1010:42: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
&& pi->cert_user != '\0') {
^~
src/sss_client/pam_sss.c:1010:28: note: did you mean to dereference the pointer?
&& pi->cert_user != '\0') {
Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
Diffstat (limited to 'src/sss_client')
| -rw-r--r-- | src/sss_client/pam_sss.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/sss_client/pam_sss.c b/src/sss_client/pam_sss.c index 1c0607996..9732459e6 100644 --- a/src/sss_client/pam_sss.c +++ b/src/sss_client/pam_sss.c @@ -995,7 +995,7 @@ static int eval_response(pam_handle_t *pamh, size_t buflen, uint8_t *buf, break; } - if (type == SSS_PAM_CERT_INFO && pi->cert_user == '\0') { + if (type == SSS_PAM_CERT_INFO && *pi->cert_user == '\0') { D(("Invalid CERT message")); break; } @@ -1007,7 +1007,7 @@ static int eval_response(pam_handle_t *pamh, size_t buflen, uint8_t *buf, } if ((pi->pam_user == NULL || *(pi->pam_user) == '\0') - && pi->cert_user != '\0') { + && *pi->cert_user != '\0') { ret = pam_set_item(pamh, PAM_USER, pi->cert_user); if (ret != PAM_SUCCESS) { D(("Failed to set PAM_USER during " |