diff options
| author | Pavel Březina <pbrezina@redhat.com> | 2016-07-14 10:49:37 +0200 |
|---|---|---|
| committer | Lukas Slebodnik <lslebodn@redhat.com> | 2016-08-16 14:40:57 +0200 |
| commit | de5160e354c02020f0593c7cabdb811107d5d8e2 (patch) | |
| tree | 07a8ed2d76d862705981fadc3b60f0c5c00a4ce6 /src/lib | |
| parent | bd4c2ed5aec7f57ea04500f0e43f151eedfdde45 (diff) | |
| download | sssd-de5160e354c02020f0593c7cabdb811107d5d8e2.tar.gz sssd-de5160e354c02020f0593c7cabdb811107d5d8e2.tar.xz sssd-de5160e354c02020f0593c7cabdb811107d5d8e2.zip | |
sifp: fix coverity warning
sssd-1.14.1/src/lib/sifp/sss_sifp_dbus.c:51: check_return:
Calling "dbus_message_append_args_valist" without checking return value
(as is done elsewhere 4 out of 5 times).
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Diffstat (limited to 'src/lib')
| -rw-r--r-- | src/lib/sifp/sss_sifp_dbus.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/lib/sifp/sss_sifp_dbus.c b/src/lib/sifp/sss_sifp_dbus.c index 7c72c52f0..2906c5ac3 100644 --- a/src/lib/sifp/sss_sifp_dbus.c +++ b/src/lib/sifp/sss_sifp_dbus.c @@ -36,6 +36,7 @@ static sss_sifp_error sss_sifp_ifp_call(sss_sifp_ctx *ctx, { DBusMessage *msg = NULL; sss_sifp_error ret; + dbus_bool_t bret; if (object_path == NULL || interface == NULL || method == NULL) { return SSS_SIFP_INVALID_ARGUMENT; @@ -48,7 +49,11 @@ static sss_sifp_error sss_sifp_ifp_call(sss_sifp_ctx *ctx, } if (first_arg_type != DBUS_TYPE_INVALID) { - dbus_message_append_args_valist(msg, first_arg_type, ap); + bret = dbus_message_append_args_valist(msg, first_arg_type, ap); + if (!bret) { + ret = SSS_SIFP_IO_ERROR; + goto done; + } } ret = sss_sifp_send_message(ctx, msg, _reply); |