diff options
| author | Jakub Hrozek <jhrozek@redhat.com> | 2017-03-24 20:36:06 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2017-03-30 14:09:47 +0200 |
| commit | 57eeec5d735c7a3bbe58299fded97414626d85f1 (patch) | |
| tree | f9ba6a4e5b91ce726da933e8e7156609a821ba81 | |
| parent | b010f24f4d96d15c5c85021bb4aa83db25cd3df5 (diff) | |
| download | sssd-57eeec5d735c7a3bbe58299fded97414626d85f1.tar.gz sssd-57eeec5d735c7a3bbe58299fded97414626d85f1.tar.xz sssd-57eeec5d735c7a3bbe58299fded97414626d85f1.zip | |
PAM: Remove unneeded memory context
Since we only store data into pam_ctx in get_public_domains(), it
doesn't make sense to allow passing a separate memory context. It is
always going to be pam_ctx, otherwise the memory hierarchy will cause
issues anyway.
Reviewed-by: Sumit Bose <sbose@redhat.com>
| -rw-r--r-- | src/responder/pam/pamsrv.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/responder/pam/pamsrv.c b/src/responder/pam/pamsrv.c index 816f22931..ab3f45455 100644 --- a/src/responder/pam/pamsrv.c +++ b/src/responder/pam/pamsrv.c @@ -122,7 +122,7 @@ done: return ret; } -static errno_t get_public_domains(TALLOC_CTX *mem_ctx, struct pam_ctx *pctx) +static errno_t get_public_domains(struct pam_ctx *pctx) { char *domains_str = NULL; errno_t ret; @@ -137,7 +137,7 @@ static errno_t get_public_domains(TALLOC_CTX *mem_ctx, struct pam_ctx *pctx) if (strcmp(domains_str, ALL_DOMAIMS_ARE_PUBLIC) == 0) { /* all */ /* copy all domains */ - ret = get_dom_names(mem_ctx, + ret = get_dom_names(pctx, pctx->rctx->domains, &pctx->public_domains, &pctx->public_domains_count); @@ -149,7 +149,7 @@ static errno_t get_public_domains(TALLOC_CTX *mem_ctx, struct pam_ctx *pctx) pctx->public_domains = NULL; pctx->public_domains_count = 0; } else { - ret = split_on_separator(mem_ctx, domains_str, ',', true, false, + ret = split_on_separator(pctx, domains_str, ',', true, false, &pctx->public_domains, &pctx->public_domains_count); if (ret != EOK) { @@ -212,7 +212,7 @@ static int pam_process_init(TALLOC_CTX *mem_ctx, goto done; } - ret = get_public_domains(pctx, pctx); + ret = get_public_domains(pctx); if (ret != EOK) { DEBUG(SSSDBG_FATAL_FAILURE, "get_public_domains failed: %d:[%s].\n", ret, sss_strerror(ret)); |