summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabiano FidĂȘncio <fidencio@redhat.com>2017-08-28 16:38:40 +0200
committerJakub Hrozek <jhrozek@redhat.com>2017-08-31 12:08:34 +0200
commit5a117d36030f589cc04430ea1c6c328a8fdb903f (patch)
treec970fb5abaa28439eca7e85b7dd9a9869958b7ca
parent362b8a94c0ffaa63af3a5a5772c29303be009640 (diff)
downloadsssd-5a117d36030f589cc04430ea1c6c328a8fdb903f.tar.gz
sssd-5a117d36030f589cc04430ea1c6c328a8fdb903f.tar.xz
sssd-5a117d36030f589cc04430ea1c6c328a8fdb903f.zip
SDAP: Don't call be_mark_offline() because sdap_id_conn_data_set_expire_timer() failed
Marking the whole backend as offline because sdap_id_conn_data_set_expire_timer() failed doesn't look any right and from now on let's avoiding doing so. Related: https://pagure.io/SSSD/sssd/issue/2976 Signed-off-by: Fabiano FidĂȘncio <fidencio@redhat.com> Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
-rw-r--r--src/providers/ldap/sdap_id_op.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/providers/ldap/sdap_id_op.c b/src/providers/ldap/sdap_id_op.c
index 856226635..e7ff5464c 100644
--- a/src/providers/ldap/sdap_id_op.c
+++ b/src/providers/ldap/sdap_id_op.c
@@ -592,6 +592,14 @@ static void sdap_id_op_connect_done(struct tevent_req *subreq)
}
}
ret = sdap_id_conn_data_set_expire_timer(conn_data);
+ if (ret != EOK) {
+ DEBUG(SSSDBG_MINOR_FAILURE,
+ "sdap_id_conn_data_set_expire_timer() failed [%d]: %s",
+ ret, sss_strerror(ret));
+ /* Avoid causing the whole backend to be marked as offline because
+ * this operation failed. */
+ ret = EOK;
+ }
sdap_steal_server_opts(conn_cache->id_conn->id_ctx, &srv_opts);
}