diff options
| author | Lukas Slebodnik <lslebodn@redhat.com> | 2017-05-27 14:39:45 +0200 |
|---|---|---|
| committer | Lukas Slebodnik <lslebodn@redhat.com> | 2017-05-31 15:21:29 +0200 |
| commit | 074ded4cda2ce88563a3e7e5cc0eea808d3322b3 (patch) | |
| tree | de831f07b6686f178648475f9c0e5c28f8cc9eca | |
| parent | 29ee3e0945f8935a2eb01913ba00b540e0a94f01 (diff) | |
| download | sssd-074ded4cda2ce88563a3e7e5cc0eea808d3322b3.tar.gz sssd-074ded4cda2ce88563a3e7e5cc0eea808d3322b3.tar.xz sssd-074ded4cda2ce88563a3e7e5cc0eea808d3322b3.zip | |
SECRETS: Fix warning Wpointer-bool-conversion
Debug messages would always say that verify_peer and verify_host
are enabled. Even though they would be explicitly disabled.
src/responder/secrets/proxy.c:143:18: error:
address of 'cfg->verify_peer' will always evaluate to
'true' [-Werror,-Wpointer-bool-conversion]
(&cfg->verify_peer ? "true" : "false"));
~~~~~^~~~~~~~~~~ ~
src/util/debug.h:108:32: note: expanded from macro 'DEBUG'
format, ##__VA_ARGS__); \
^~~~~~~~~~~
src/responder/secrets/proxy.c:149:18: error:
address of 'cfg->verify_host' will always evaluate to
'true' [-Werror,-Wpointer-bool-conversion]
(&cfg->verify_host ? "true" : "false"));
~~~~~^~~~~~~~~~~ ~
src/util/debug.h:108:32: note: expanded from macro 'DEBUG'
format, ##__VA_ARGS__); \
^~~~~~~~~~~
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
| -rw-r--r-- | src/responder/secrets/proxy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/responder/secrets/proxy.c b/src/responder/secrets/proxy.c index 9c2aa425d..a4e97f83e 100644 --- a/src/responder/secrets/proxy.c +++ b/src/responder/secrets/proxy.c @@ -140,13 +140,13 @@ static int proxy_sec_get_cfg(struct proxy_context *pctx, true, &cfg->verify_peer); if (ret) goto done; DEBUG(SSSDBG_CONF_SETTINGS, "verify_peer: %s\n", - (&cfg->verify_peer ? "true" : "false")); + cfg->verify_peer ? "true" : "false"); ret = confdb_get_bool(pctx->cdb, secreq->cfg_section, "verify_host", true, &cfg->verify_host); if (ret) goto done; DEBUG(SSSDBG_CONF_SETTINGS, "verify_host: %s\n", - (&cfg->verify_host ? "true" : "false")); + cfg->verify_host ? "true" : "false"); ret = proxy_get_config_string(pctx, cfg, false, secreq, "capath", &cfg->capath); |