sssd.git/src/tools, branch master

config-check: Message when sssd.conf is missing

2017-04-10T14:34:16+00:00

sssctl config-check should print a message for user
if no sssd.conf was found.

Resolves:
https://pagure.io/SSSD/sssd/issue/3330

Reviewed-by: Lukáš Slebodník

sssctl: integrate pam_test_client into sssctl

2017-04-10T13:21:56+00:00

Reviewed-by: Pavel Březina

SUBDOMAINS: Allow use_fully_qualified_names for subdomains

2017-03-29T12:00:17+00:00

Allow option use_fully_qualified_names in subdomain section.
This option was recently added to subdomain_inherit.

Resolves:
https://pagure.io/SSSD/sssd/issue/3337

Reviewed-by: Fabiano Fidêncio

sss_cache: User/groups invalidation in domain cache

2017-03-08T11:36:56+00:00

When a group/users are invalidated from sss_cache, the group/user
information in domain and timestamps cache are inconsistent with
regard to dataExpireTimestamp attribute.

This patch fixes the problem by explicitly invalidating the domain
cache's entry when the timestamp cache entry is invalidated
by sss_cache call. There is one new function:
* sysdb_invalidate_cache_entry()
provided for this purpose and used only in sss_cache utility.

Resolves:
https://fedorahosted.org/sssd/ticket/3164

Reviewed-by: Lukáš Slebodník 
Reviewed-by: Fabiano Fidêncio

SYSTEMD: Don't mix up responders' socket and monitor activation

2017-03-02T15:46:23+00:00

Let's ensure that in case a responder is explicitly configured in the
sssd.conf its socket won't even start.

The patchset introduces a new binary that will be distributed and will
be called before starting the responders' sockets, ensuring the sockets
will only start in case the responder is supposed to be socket-activated
and its been configured accordingly. Otherwise the responders' socket
startup will fail with a quite helpful debug message leading the admins
to choose between using systemd or not and what has to be done to achieve
their desire.

This suggestion came from Sumit Bose.

The reason for adding a new binary instead of a simple python script is
to avoid dragging unnecessary dependencies to sssd-common package.

Resolves:
https://pagure.io/SSSD/sssd/issue/3300

Signed-off-by: Fabiano Fidêncio 

Reviewed-by: Jakub Hrozek 
Reviewed-by: Lukáš Slebodník

sssctl: Fix warning may be used uninitialized

2017-02-01T13:11:09+00:00

gcc 7 probably does some new optimisations which might cause few
wariables to be uninitialized.

src/tools/sssctl/sssctl_cache.c: In function ‘sssctl_print_object’:
src/tools/sssctl/sssctl_cache.c:523:13: error: ‘dom’ may be used uninitialized
  in this function [-Werror=maybe-uninitialized]
         ret = info[i].attr_fn(tmp_ctx, entry, dom, info[i].attr, &value);
         ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/tools/sssctl/sssctl_cache.c:472:15: error: ‘entry’ may be used
  uninitialized in this function [-Werror=maybe-uninitialized]
     *_entry = talloc_steal(mem_ctx, entry);
               ^~~~~~~~~~~~
src/tools/sssctl/sssctl_cache.c:437:25: note: ‘entry’ was declared here
     struct sysdb_attrs *entry;
                         ^~~~~

Another workaround would be to remove static modifier from function
sssctl_find_object which probably prevents some inlinig + optimisation.

Reviewed-by: Fabiano Fidêncio

TOOLS: Fix warning format-truncation

2017-02-01T13:11:02+00:00

src/tools/sss_groupshow.c: In function ‘print_group_info’:
src/tools/sss_groupshow.c:612:22: error: ‘%d’ directive output truncated
  writing between 10 and 11 bytes into a region of size 7 [-Werror=format-truncation=]
     snprintf(fmt, 8, "%%%ds", level*PADDING_SPACES);
                      ^~~~~~~
src/tools/sss_groupshow.c:612:22: note: using the range
  [-2147483648, 2147483647] for directive argument
src/tools/sss_groupshow.c:612:5: note: ‘snprintf’ output between 13 and 14
  bytes into a destination of size 8
     snprintf(fmt, 8, "%%%ds", level*PADDING_SPACES);

Reviewed-by: Fabiano Fidêncio

sssctl: Case insensitive filters

2016-12-15T09:43:32+00:00

Lowercase the filter in case insensitive domains.

Resolves:
https://fedorahosted.org/sssd/ticket/3235

Reviewed-by: Jakub Hrozek

sssctl: Search by alias

2016-12-15T09:43:29+00:00

Also search by alias when using sssctl to query the cache.

Resolves:
https://fedorahosted.org/sssd/ticket/3235

Reviewed-by: Jakub Hrozek

sssctl: Fix missing declaration

2016-11-25T11:51:12+00:00

The WEXITSTATUS is defined in stdlib.h on linux.
There is a nice comment in stdlib.h:
  /* Define the macros  also would define this way.  */

It's better to not rely on this and use more platfom friendly
way with including "sys/wait.h". For example the libc on FreeBSD
does not provide WEXITSTATUS in stdlib.h.

I found this macro mentioned only in the manual page for wait(2)
and there is mentioned just the "sys/wait.h" and not "stdlib.h"

src/tools/sssctl/sssctl.c: In function 'sssctl_run_command':
src/tools/sssctl/sssctl.c:110: error: implicit declaration of function
'WEXITSTATUS'
gmake[2]: *** [Makefile:22383: src/tools/sssctl/sssctl-sssctl.o] Error 1

Reviewed-by: Fabiano Fidêncio