sssd.git/src/tests, branch sudo

intg: Add sanity tests for pysss_nss_idmap

2017-10-16T13:11:52+00:00

Reviewed-by: Fabiano Fidêncio 
Reviewed-by: Jakub Hrozek

intg: Create FakeAD class based on openldap

2017-10-16T13:11:47+00:00

FakeAD is openldap with ldif schema which allows to load static data
from real AD. Instance of class will also contain some predefined
users/groups which can be used for basic sanity testing in sssd of AD features.

Reviewed-by: Fabiano Fidêncio 
Reviewed-by: Jakub Hrozek

ds_openldap: Extract functionality to protected methods

2017-10-16T13:11:43+00:00

Reviewed-by: Fabiano Fidêncio 
Reviewed-by: Jakub Hrozek

intg: Prefer locally built python modules

2017-10-16T13:11:39+00:00

Patch prepends path to sssd python modules; so we will be
able to import them without any issue and they will be preferred over
system modules.

sh$[/tmp/sssd-intg.3gb4hzpn/var/log/sssd] python2
Python 2.7.13 (default, Aug 16 2017, 12:56:26)
[GCC 7.1.1 20170802 (Red Hat 7.1.1-7)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import SSSDConfig
>>> print(SSSDConfig.__file__)
/tmp/sssd-intg.3gb4hzpn/lib/python2.7/site-packages/SSSDConfig/__init__.pyc
>>> import pyhbac
>>> print(pyhbac.__file__)
/tmp/sssd-intg.3gb4hzpn/lib64/python2.7/site-packages/pyhbac.so

Reviewed-by: Fabiano Fidêncio 
Reviewed-by: Jakub Hrozek

intg: prevent "TypeError: must be type, not classobj"

2017-10-16T13:11:29+00:00

http://stackoverflow.com/questions/9698614/super-raises-typeerror-must-be-type-not-classobj-for-new-style-class

========================== ERRORS ===========================
_______ ERROR at setup of test_regression_ticket2163 ________
Traceback (most recent call last):
  File "src/tests/intg/test_pysss_nss_idmap.py", line 48, in ad_inst
    instance.teardown()
  File "src/tests/intg/ds_openldap.py", line 371, in teardown
    super(FakeAD, self).teardown()
TypeError: super() argument 1 must be type, not classobj

Reviewed-by: Fabiano Fidêncio 
Reviewed-by: Jakub Hrozek

intg: Let python paths be configurable

2017-10-16T13:11:25+00:00

It will allow to prefer locally built python modules
in integration tests.

Reviewed-by: Fabiano Fidêncio 
Reviewed-by: Jakub Hrozek

intg: Fix pep8 warnings in config.py template

2017-10-16T13:11:13+00:00

intg/bld/src/tests/intg/config.py:5:7: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:6:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:7:15: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:8:12: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:9:10: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:10:8: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:11:9: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:12:13: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:13:9: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:14:12: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:15:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:16:13: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:17:12: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:18:13: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:20:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:21:7: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:22:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:23:7: E221 multiple spaces before operator

pep8 will prevent reformatting in case of added new options
e.g. 53a4219e2f51cd0443931aa931505bf0b4bf5a45

Reviewed-by: Fabiano Fidêncio 
Reviewed-by: Jakub Hrozek

sysdb: sanitize search filter input

2017-10-11T15:28:53+00:00

This patch sanitizes the input for sysdb searches by UPN/email, SID and
UUID.

This security issue was assigned CVE-2017-12173

Reviewed-by: Lukáš Slebodník 
Reviewed-by: Jakub Hrozek

intg: Fix execution with dbus-1.11.18

2017-10-04T04:36:07+00:00

Since dbus-1.11.18 DBUS_COOKIE_SHA1 respect $HOME variable
and fallback to value returned from getpwnam only if env HOME
does not exist. It caused problem for dbus communication
between sssd processes because local user usually do not have
directory $HOME/.dbus-keyrings/. And directory created in cwrap
environment is problmatic

[build@host ~]$ ls -ld ~/.dbus-keyrings/
drw-------. 2 build build 6 Oct  3 10:44 /home/build/.dbus-keyrings/

[buildhost ~]$ ls -lna ~/.dbus-keyrings/
ls: cannot access '/home/build/.dbus-keyrings/.': Permission denied
ls: cannot access '/home/build/.dbus-keyrings/..': Permission denied
total 0
d????????? ? ? ? ?            ? .
d????????? ? ? ? ?            ? ..

[build@host ~]$ touch ~/.dbus-keyrings/test
touch: cannot touch '/home/build/.dbus-keyrings/test': Permission denied

Other alternative would be to set env variable HOME to the
same value as in fake passwd file:
  HOME=$(abs_builddir)/root

Related dbus bug:
https://bugs.freedesktop.org/show_bug.cgi?id=101960

Resolves:
https://pagure.io/SSSD/sssd/issue/3531

Reviewed-by: Fabiano Fidêncio

TESTS: Fix "-Wshadow" caught by GCC

2017-09-25T19:35:10+00:00

This warning only happens when building SSSD on RHEL6.

Signed-off-by: Fabiano Fidêncio 
Reviewed-by: Lukáš Slebodník