sssd.git/src/sss_client/libwbclient, branch sudo

libwbclient: Fix warning statement with no effect

2017-08-22T17:36:20+00:00

src/sss_client/libwbclient/wbc_pam_sssd.c: In function ‘wbcAuthenticateUserEx’:
src/sss_client/libwbclient/wbc_pam_sssd.c:52:5: error: statement with no effect [-Werror=unused-value]
     WBC_ERR_WINBIND_NOT_AVAILABLE;
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pam_sssd.c:53:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

Related to:
https://pagure.io/SSSD/sssd/issue/3461

Reviewed-by: Sumit Bose

libwbclient: Change return code for wbcAuthenticateUserEx

2017-08-22T13:37:39+00:00

Samba-4.6 change behaviour of few functions
New version of code make sure session info for user is stored in cache.
It is a performance optimisation to prevent contacting KDC for each
session. More details in samba bug
https://bugzilla.samba.org/show_bug.cgi?id=11259

Old return code WBC_SSSD_NOT_IMPLEMENTED was translated
to NT_STATUS_LOGON_FAILURE which caused many failures.

    [2017/08/21 11:34:15.044321,  5, pid=27742, effective(0, 0), real(0, 0)]
    ../libcli/security/security_token.c:53(security_token_debug)
      Security token: (NULL)
    [2017/08/21 11:34:15.044330,  5, pid=27742, effective(0, 0), real(0, 0)]
    ../source3/auth/token_util.c:640(debug_unix_user_token)
      UNIX token of user 0
      Primary group is 0 and contains 0 supplementary groups
    [2017/08/21 11:34:15.044349,  4, pid=27742, effective(0, 0), real(0, 0)]
    ../source3/smbd/sec_ctx.c:439(pop_sec_ctx)
      pop_sec_ctx (0, 0) - sec_ctx_stack_ndx = 0
    [2017/08/21 11:34:15.044360,  1, pid=27742, effective(0, 0), real(0, 0)]
    ../source3/smbd/sesssetup.c:290(reply_sesssetup_and_X_spnego)
      Failed to generate session_info (user and group token) for session
    setup: NT_STATUS_LOGON_FAILURE

Resolves:
https://pagure.io/SSSD/sssd/issue/3461

Reviewed-by: Sumit Bose

libwbclient-sssd: update interface to version 0.14

2017-08-03T09:17:52+00:00

The main change is a new member of the wbcAuthErrorInfo struct.

Reviewed-by: Fabiano Fidêncio

Use pagure links as a reference to upstream

2017-02-28T09:59:57+00:00

Reviewed-by: Fabiano Fidêncio

libwbclient-sssd: wbcLookupSid() allow NULL arguments

2017-01-21T19:13:56+00:00

Some caller might not be interested in some of the values wbcLookupSid()
returns and just pass NULL. Currently 'net ads user info' does this
because it is not interested in the domain. wbcLookupSid() should handle
this gracefully.

Resolves:
https://fedorahosted.org/sssd/ticket/3273

Reviewed-by: Lukáš Slebodník

libwbclient-sssd: update interface to version 0.13

2016-10-14T16:42:54+00:00

This patch adds wbcCtxUnixIdsToSids() and wbcUnixIdsToSids() to SSSD's
libwbclient and implements the latter.

Resolves:
https://fedorahosted.org/sssd/ticket/3181

Reviewed-by: Fabiano Fidêncio

libwbclient: wbcSidsToUnixIds() don't fail on errors

2016-06-07T09:44:44+00:00

Resolves: https://fedorahosted.org/sssd/ticket/3028

Reviewed-by: Alexander Bokovoy

Fix minor typos

2015-07-23T09:10:16+00:00

Reviewed-by: Lukáš Slebodník

libwbclient-sssd: update interface to version 0.12

2015-05-26T08:23:40+00:00

Reviewed-by: Lukáš Slebodník

Fix warning: equality comparison with extraneous parentheses

2015-02-11T19:38:42+00:00

Example of warning:
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  error: equality comparison with extraneous parentheses
  [-Werror,-Wparentheses-equality]
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
         ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: remove extraneous parentheses around the comparison
  to silence this warning
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
        ~             ^                 ~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: use '=' to turn this equality comparison into an assignment
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
                      ^~
                      =

The reason is definition of some macros which were used in if conditions.

Reviewed-by: Michal Židek