sssd.git/src/resolv, branch sudo

RESOLV: Fix "-Werror=null-dereference" caught by GCC

2017-09-25T19:34:14+00:00

Signed-off-by: Fabiano Fidêncio 
Reviewed-by: Lukáš Slebodník

UTIL: Remove limits.h from util/util.h

2017-06-08T15:10:02+00:00

limits.h is not used directly by util/util.h. The header file limits.h
must be included in 17 files and after removing it from util.h it had to be
added only to 4 missing files

Reviewed-by: Fabiano Fidêncio

Prevent use after free in fd_input_available

2016-12-08T10:48:41+00:00

When both TEVENT_FD_WRITE and TEVENT_FD_READ are set, and an error/EOF
occurs when reading from the socket, we will get a use after free
in the second call ares_process_fd.  The first call will free the watch
structure via a callback.

Prevent this by calling ares_process_fd only once.

Invalid read of size 4
   at fd_input_available (async_resolv.c:147)
   by epoll_event_loop (tevent_epoll.c:728)
   by epoll_event_loop_once (tevent_epoll.c:926)
   by std_event_loop_once (tevent_standard.c:114)
   by _tevent_loop_once (tevent.c:533)
   by tevent_common_loop_wait (tevent.c:637)
   by std_event_loop_wait (tevent_standard.c:140)
   by server_loop (server.c:702)
   by main (data_provider_be.c:587)
 Address ... is 112 bytes inside a block of size 136 free'd
   at free (vg_replace_malloc.c:530)
   by _talloc_free_internal (talloc.c:1116)
   by _talloc_free (talloc.c:1647)
   by ares__close_sockets (ares__close_sockets.c:50)
   by handle_error (ares_process.c:679)
   by read_tcp_data (ares_process.c:391)
   by processfds (ares_process.c:138)
   by fd_input_available (async_resolv.c:144)
   by epoll_event_loop (tevent_epoll.c:728)
   by epoll_event_loop_once (tevent_epoll.c:926)
   by std_event_loop_once (tevent_standard.c:114)
   by _tevent_loop_once (tevent.c:533)
   by tevent_common_loop_wait (tevent.c:637)
   by std_event_loop_wait (tevent_standard.c:140)
   by server_loop (server.c:702)

Resolves:
https://fedorahosted.org/sssd/ticket/3250

Reviewed-by: Jakub Hrozek

Make resolv_is_address() function public and create some basic tests

2016-08-16T18:21:21+00:00

Resolves:
https://fedorahosted.org/sssd/ticket/2789

Reviewed-by: Jakub Hrozek

Just return NULL if tevent_req_create() fails

2016-02-11T13:39:12+00:00

In general we just return NULL if tevent_req_create() fails because
there is nothing we can do with the request anyway. Especially
tevent_req_error() should not be called because it tries to dereference
req.

Reviewed-by: Pavel Březina

resolv: Use the same default timeout for SRV queries as previously

2015-03-03T15:15:28+00:00

When we changed the resolver code to use the TTL values from the DNS
queries instead of harcoded ones, we changed the default value by
accident.

Add a separate SRV TTL that is backwards-compatible with the old
harcoded value.

Reviewed-by: Pavel Březina

resolv: Fix a typo

2015-02-13T17:30:09+00:00

Reviewed-by: Pavel Reichl

RESOLV: Remove obsolete in-tree implementation of SRV and TXT parsing

2015-02-11T10:12:04+00:00

SSSD contained several backwards-compatible definitions of SRV and TXT
APIs as well as structures that carry TTL data. These were intended for
RHEL-5 and older releases. Since we don't support those upstream, it's
better to remove the code -- it has drifted apart from upstream anyway.

Reviewed-by: Pavel Březina

RESOLV: Add an internal function to read TTL from a DNS packet

2015-02-11T10:03:34+00:00

Related:
https://fedorahosted.org/sssd/ticket/1884

Adds an internal resolver function that reads the TTL for SRV records as
specified by RFC-2181. Several internal c-ares definitions are used
until c-ares contains a function that exposes all this information via a
parsing function.

Reviewed-by: Pavel Březina

resolv: fix server sort by weight

2014-07-14T13:05:04+00:00

When the server list consist only from servers with zero weight the
output list contained only one server.

Resolves:
https://fedorahosted.org/sssd/ticket/2357

Reviewed-by: Pavel Reichl