s/dictonary/dictionary/g

Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit e7fd33642a16cbb2cd814d3578c28affcf16f68c)
(cherry picked from commit 0d5e92b3ce507f8c46d3605729abc69d8310ff93)

The python module pysss_nss_idmap contains few module constants
which should be used (based on python documentation) for checking
type of results.

e.g.
    getsidbyid(...)
        getsidbyid(id or list/tuple of id) -> dict(id => dict(results))
        Returns a dictionary with a dictionary of results for each given
        POSIX ID. The result dictionary contains the SID and the type of the
        object which can be accessed with the key constants SID_KEY and
        TYPE_KEY, respectively.

However, type of module constant and type of returned key had different type
with python3 due to different handling of strings. This patch unifies it
to string. The same as it is in python2.

Resolves:
https://pagure.io/SSSD/sssd/issue/3491

Reviewed-by: Sumit Bose <sbose@redhat.com>
(cherry picked from commit cc4d6435ef49738a02ddfc6072f1197d7f8f7319)
(cherry picked from commit 76d0f9091c43676957ae8f62f1c84fb3c25ce563)

Some kind of comments are recognized by gcc7 but they are ignored with
-Wimplicit-fallthrough=5 and only attributes disable the warning.

Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com>
(cherry picked from commit 2e505786d6d9d537f5b6631099862f6b93e2e687)
(cherry picked from commit ff9d6533654d4529e681fbbfa6f118f975e5a333)

src/python/pyhbac.c: In function ‘HbacRuleElement_repr’:
src/python/pyhbac.c:506:59: error: comparison between
    signed and unsigned integer expressions [-Werror=sign-compare]
     if (strnames == NULL || strgroups == NULL || category == -1) {
                                                           ^
src/python/pyhbac.c: In function ‘HbacRuleElement_to_native’:
src/python/pyhbac.c:614:51: error: comparison between
    signed and unsigned integer expressions [-Werror=sign-compare]
     if (!el->names || !el->groups || el->category == -1) {
                                                   ^

The static function native_category had type of terurn value uint32_t
But it also could return -1 which indicated an error.

It's better to don't mix return code with returned value.

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
(cherry picked from commit f47a339d7794cd5a24d368b3b3640452686e45a5)

src/python/pysss_murmur.c: In function ‘py_murmurhash3’:
src/python/pysss_murmur.c:47:17: error: comparison between
     signed and unsigned integer expressions [-Werror=sign-compare]
         key_len > strlen(key)) {
                 ^

uint32_t murmurhash3(const char *key, int len, uint32_t seed)
The second argument of the function murmurhash3 has type int.
But the code expects to be unsigned integer.

There is code in python wrapper py_murmurhash3
which check boundaries of that argument.
It should be an unsigned "key_len > INT_MAX || key_len < 0".
An exception should be thrown for negative number.

Moreover, the length should be shorter then a length of input string.
The strlen returns size_t which is unsigned and key_len is signed long.
We already checked that value is unsigned so
we can safely cast key_len to size_t

Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
(cherry picked from commit 2ff8131cf02decaf0dd0754e843732fe7774fc59)

Reviewed-by: Pavel Březina <pbrezina@redhat.com>
(cherry picked from commit 42604cc8d11743febf5aa892cb3a7d3c32bfed48)

The function PyUnicode_FromString is available in python >= 2.6

Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>

The macro PySet_Check is defined in python >= 2.6

Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>

The function PySet_Add is available in python >= 2.6

Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>

The function PySet_New is available in python >= 2.6

Reviewed-by: Stephen Gallagher <sgallagh@redhat.com>