From 0169c7d2a2b26a86eb10542690c557c34fc0eb00 Mon Sep 17 00:00:00 2001 From: Radek Novacek Date: Mon, 18 Nov 2013 14:15:56 +0100 Subject: Fix missing format strings Missing format strings are considered a vulnerability. --- src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c | 2 +- src/hardware/LMI_MemoryProvider.c | 2 +- src/hardware/LMI_ProcessorCacheMemoryProvider.c | 2 +- src/hardware/LMI_ProcessorCapabilitiesProvider.c | 2 +- src/hardware/LMI_ProcessorElementCapabilitiesProvider.c | 2 +- src/hardware/LMI_ProcessorProvider.c | 2 +- src/service-dbus/LMI_ServiceProvider.c | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src') diff --git a/src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c b/src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c index 7f0c9b7..8fe6956 100644 --- a/src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c +++ b/src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c @@ -295,7 +295,7 @@ done: sysfs_free_cpu_caches(&sysfs_cpu_caches, &sysfs_cpu_caches_nb); if (error_msg) { - KReturn2(_cb, ERR_FAILED, error_msg); + KReturn2(_cb, ERR_FAILED, "%s", error_msg); } CMReturn(CMPI_RC_OK); diff --git a/src/hardware/LMI_MemoryProvider.c b/src/hardware/LMI_MemoryProvider.c index 43cba24..02ccd76 100644 --- a/src/hardware/LMI_MemoryProvider.c +++ b/src/hardware/LMI_MemoryProvider.c @@ -139,7 +139,7 @@ done: free(huge_page_sizes); if (error_msg) { - KReturn2(_cb, ERR_FAILED, error_msg); + KReturn2(_cb, ERR_FAILED, "%s", error_msg); } CMReturn(CMPI_RC_OK); diff --git a/src/hardware/LMI_ProcessorCacheMemoryProvider.c b/src/hardware/LMI_ProcessorCacheMemoryProvider.c index 616faa7..64879dc 100644 --- a/src/hardware/LMI_ProcessorCacheMemoryProvider.c +++ b/src/hardware/LMI_ProcessorCacheMemoryProvider.c @@ -158,7 +158,7 @@ done: sysfs_free_cpu_caches(&sysfs_cpu_caches, &sysfs_cpu_caches_nb); if (error_msg) { - KReturn2(_cb, ERR_FAILED, error_msg); + KReturn2(_cb, ERR_FAILED, "%s", error_msg); } CMReturn(CMPI_RC_OK); diff --git a/src/hardware/LMI_ProcessorCapabilitiesProvider.c b/src/hardware/LMI_ProcessorCapabilitiesProvider.c index a3ed407..9eeb9b6 100644 --- a/src/hardware/LMI_ProcessorCapabilitiesProvider.c +++ b/src/hardware/LMI_ProcessorCapabilitiesProvider.c @@ -131,7 +131,7 @@ done: dmi_free_processors(&dmi_cpus, &dmi_cpus_nb); if (error_msg) { - KReturn2(_cb, ERR_FAILED, error_msg); + KReturn2(_cb, ERR_FAILED, "%s", error_msg); } CMReturn(CMPI_RC_OK); diff --git a/src/hardware/LMI_ProcessorElementCapabilitiesProvider.c b/src/hardware/LMI_ProcessorElementCapabilitiesProvider.c index fcb5128..a74cdff 100644 --- a/src/hardware/LMI_ProcessorElementCapabilitiesProvider.c +++ b/src/hardware/LMI_ProcessorElementCapabilitiesProvider.c @@ -137,7 +137,7 @@ done: dmi_free_processors(&dmi_cpus, &dmi_cpus_nb); if (error_msg) { - KReturn2(_cb, ERR_FAILED, error_msg); + KReturn2(_cb, ERR_FAILED, "%s", error_msg); } CMReturn(CMPI_RC_OK); diff --git a/src/hardware/LMI_ProcessorProvider.c b/src/hardware/LMI_ProcessorProvider.c index 04e1d80..273a03d 100644 --- a/src/hardware/LMI_ProcessorProvider.c +++ b/src/hardware/LMI_ProcessorProvider.c @@ -252,7 +252,7 @@ done: cpuinfo_free_processor(&proc_cpu); if (error_msg) { - KReturn2(_cb, ERR_FAILED, error_msg); + KReturn2(_cb, ERR_FAILED, "%s", error_msg); } CMReturn(CMPI_RC_OK); diff --git a/src/service-dbus/LMI_ServiceProvider.c b/src/service-dbus/LMI_ServiceProvider.c index 0bc2e77..6fbefe8 100644 --- a/src/service-dbus/LMI_ServiceProvider.c +++ b/src/service-dbus/LMI_ServiceProvider.c @@ -52,7 +52,7 @@ static CMPIStatus LMI_ServiceEnumInstanceNames( slist = service_find_all(output, sizeof(output)); if (slist == NULL) { - KReturn2(_cb, ERR_FAILED, output); + KReturn2(_cb, ERR_FAILED, "%s", output); } for (int i = 0; i < slist->cnt; i++) { @@ -139,7 +139,7 @@ static CMPIStatus LMI_ServiceGetInstance( } else if (res == -2) { /* service of that name doesn't exist */ KReturn(ERR_NOT_FOUND); } else { /* some error occured when getting properties */ - KReturn2(_cb, ERR_FAILED, output); + KReturn2(_cb, ERR_FAILED, "%s", output); } } -- cgit