diff options
author | Alois Mahdal <amahdal@redhat.com> | 2014-06-20 23:08:14 +0200 |
---|---|---|
committer | Alois Mahdal <amahdal@redhat.com> | 2014-06-24 13:56:08 +0200 |
commit | b875d6b63ad0009d1fa8a525c2c7be261c68a139 (patch) | |
tree | 8f23f9bf5448ec4c503e18214f17ce3e6604c051 /mof/60_LMI_Software.mof | |
parent | 66d6716ba9c89c4e0f17348f37d51cf9441ce3f9 (diff) | |
download | openlmi-providers-b875d6b63ad0009d1fa8a525c2c7be261c68a139.tar.gz openlmi-providers-b875d6b63ad0009d1fa8a525c2c7be261c68a139.tar.xz openlmi-providers-b875d6b63ad0009d1fa8a525c2c7be261c68a139.zip |
Improve API to cover indications and source instances
With writing new tests, some limitations of current framework emerged.
For example, there has been assumption that one LMIIndication container
will only hold one CIMIndication instance. This is mostly true so far,
but does not have to be always, so is dangersous for further decisions.
Overview of changes:
* Interface of IndicationTestProbe for retrieving data
about delivered indications has been split from get_cns to
get_indications and get_ssource_instances. These don't expose
LMIIndication containers, but rather collect all indications to
one big list, and source instances to parallel list.
* Furthermore, as opposed to rather confusing get_cns, these new
methods don't automatically create PackedSequence or sort
indications. Instead, describe_* methods have been created
solely for this purpose. Similar change has been done to
get_ans, which is now split to get_actions and describe_*
for reporting.
* Also the number-baseded test had been oversimplified, which caused
confusion when trying to use it with LMI_Groups, where indication
name alias is different than sourceInstance alias.
* Assertions about streams are now made separately for indications and
source instances. This is now reflected in tests, which have the
oracles defined separately (expected_*_stream) and also have
aggregated the repeating code to check_* methods so that new
group assertions can be added easily on the go.
Diffstat (limited to 'mof/60_LMI_Software.mof')
0 files changed, 0 insertions, 0 deletions