From 6e3ab18c27e724db5fb7953daa11361227be22af Mon Sep 17 00:00:00 2001
From: Stephen Gallagher <sgallagh@redhat.com>
Date: Fri, 5 Nov 2010 08:54:50 -0400
Subject: Properly check the return value from semanage_commit

semanage_commit() returns -1 on error, and can return a positive
value on success.

https://bugzilla.redhat.com/show_bug.cgi?id=649037
---
 src/tools/selinux.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/tools/selinux.c b/src/tools/selinux.c
index 27cc5680..647fc17a 100644
--- a/src/tools/selinux.c
+++ b/src/tools/selinux.c
@@ -324,7 +324,7 @@ int set_seuser(const char *login_name, const char *seuser_name)
     }
 
     ret = semanage_commit(handle);
-    if (ret != 0) {
+    if (ret < 0) {
         DEBUG(1, ("Cannot commit SELinux transaction\n"));
         ret = EIO;
         goto done;
@@ -394,7 +394,7 @@ int del_seuser(const char *login_name)
     }
 
     ret = semanage_commit(handle);
-    if (ret != 0) {
+    if (ret < 0) {
         DEBUG(1, ("Cannot commit SELinux transaction\n"));
         ret = EIO;
         goto done;
-- 
cgit