<feed xmlns='http://www.w3.org/2005/Atom'>
<title>sssd2.git/src/db/sysdb.c, branch sssd-1-8</title>
<subtitle>System Security Services Daemon [okos' clone]</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/'/>
<entry>
<title>sysdb: try dealing with binary-content attributes</title>
<updated>2013-02-26T16:22:16+00:00</updated>
<author>
<name>Jan Engelhardt</name>
<email>jengelh@inai.de</email>
</author>
<published>2013-02-21T12:12:25+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=7cd86ef19cdde175f318aeca4ef2530d33158342'/>
<id>7cd86ef19cdde175f318aeca4ef2530d33158342</id>
<content type='text'>
https://fedorahosted.org/sssd/ticket/1818

I have here a LDAP user entry which has this attribute

	loginAllowedTimeMap::
	 AAAAAAAAAP///38AAP///38AAP///38AAP///38AAP///38AAAAAAAAA

In the function sysdb_attrs_add_string(), called from
sdap_attrs_add_ldap_attr(), strlen() is called on this blob, which is
the wrong thing to do. The result of strlen is then used to populate
the .v_length member of a struct ldb_val - and this will set it to
zero in this case. (There is also the problem that there may not be
a '\0' at all in the blob.)

Subsequently, .v_length being 0 makes ldb_modify(), called from
sysdb_set_entry_attr(), return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX. End
result is that users do not get stored in the sysdb, and programs like
`id` or `getent ...` show incomplete information.

The bug was encountered with sssd-1.8.5. sssd-1.5.11 seemed to behave
fine, but that may not mean that is the absolute lower boundary of
introduction of the problem.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://fedorahosted.org/sssd/ticket/1818

I have here a LDAP user entry which has this attribute

	loginAllowedTimeMap::
	 AAAAAAAAAP///38AAP///38AAP///38AAP///38AAP///38AAAAAAAAA

In the function sysdb_attrs_add_string(), called from
sdap_attrs_add_ldap_attr(), strlen() is called on this blob, which is
the wrong thing to do. The result of strlen is then used to populate
the .v_length member of a struct ldb_val - and this will set it to
zero in this case. (There is also the problem that there may not be
a '\0' at all in the blob.)

Subsequently, .v_length being 0 makes ldb_modify(), called from
sysdb_set_entry_attr(), return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX. End
result is that users do not get stored in the sysdb, and programs like
`id` or `getent ...` show incomplete information.

The bug was encountered with sssd-1.8.5. sssd-1.5.11 seemed to behave
fine, but that may not mean that is the absolute lower boundary of
introduction of the problem.
</pre>
</div>
</content>
</entry>
<entry>
<title>SYSDB: Make sysdb_attrs_get_el_int() public</title>
<updated>2012-08-21T10:33:15+00:00</updated>
<author>
<name>Jakub Hrozek</name>
<email>jhrozek@redhat.com</email>
</author>
<published>2012-08-21T10:33:15+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=e6709b54aae7cde6a3d6c73c756cb220a8129e2a'/>
<id>e6709b54aae7cde6a3d6c73c756cb220a8129e2a</id>
<content type='text'>
Also rename it to sysdb_attrs_get_el_ext()
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Also rename it to sysdb_attrs_get_el_ext()
</pre>
</div>
</content>
</entry>
<entry>
<title>Save alias of the primary name, too</title>
<updated>2012-03-21T15:22:39+00:00</updated>
<author>
<name>Jakub Hrozek</name>
<email>jhrozek@redhat.com</email>
</author>
<published>2012-03-19T07:03:32+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=6d46dc4f1d46ba4a3c568e41b62b6832474cb0e8'/>
<id>6d46dc4f1d46ba4a3c568e41b62b6832474cb0e8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>SYSDB: Save only lowercased aliases in case-insensitive domains</title>
<updated>2012-03-16T18:06:50+00:00</updated>
<author>
<name>Stephen Gallagher</name>
<email>sgallagh@redhat.com</email>
</author>
<published>2012-03-15T19:43:34+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=2293a41a4c534ad0db42038628dbe6171a08819d'/>
<id>2293a41a4c534ad0db42038628dbe6171a08819d</id>
<content type='text'>
https://fedorahosted.org/sssd/ticket/1253
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://fedorahosted.org/sssd/ticket/1253
</pre>
</div>
</content>
</entry>
<entry>
<title>SYSDB: index sudoUser</title>
<updated>2012-02-01T01:30:25+00:00</updated>
<author>
<name>Jakub Hrozek</name>
<email>jhrozek@redhat.com</email>
</author>
<published>2012-01-24T21:17:46+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=25a9a1768d2e3587cc68b76a0a5df1e42a2c89ab'/>
<id>25a9a1768d2e3587cc68b76a0a5df1e42a2c89ab</id>
<content type='text'>
Most of the the searches in the Sudo responder include the sudoUser
attribute. Indexing it will make the responder faster.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Most of the the searches in the Sudo responder include the sudoUser
attribute. Indexing it will make the responder faster.
</pre>
</div>
</content>
</entry>
<entry>
<title>SYSDB: Add sysdb_attrs_get_uint16_t</title>
<updated>2012-01-31T14:37:40+00:00</updated>
<author>
<name>Stephen Gallagher</name>
<email>sgallagh@redhat.com</email>
</author>
<published>2012-01-28T16:35:42+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=48b6eab1b369107af0d568e016a87637b7affc55'/>
<id>48b6eab1b369107af0d568e016a87637b7affc55</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>SYSDB: Add indexes for servicePort and serviceProtocol</title>
<updated>2012-01-27T14:02:01+00:00</updated>
<author>
<name>Stephen Gallagher</name>
<email>sgallagh@redhat.com</email>
</author>
<published>2012-01-16T14:51:20+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=ff907ba7a9b5e429de086515642f97a0447e546a'/>
<id>ff907ba7a9b5e429de086515642f97a0447e546a</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>SYSDB: Redundant check is redundant.</title>
<updated>2012-01-21T17:47:57+00:00</updated>
<author>
<name>Stephen Gallagher</name>
<email>sgallagh@redhat.com</email>
</author>
<published>2012-01-19T13:07:35+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=69446016c5b06e67e6a52ca5bc05e3735f6ff5e9'/>
<id>69446016c5b06e67e6a52ca5bc05e3735f6ff5e9</id>
<content type='text'>
Coverity 12480
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Coverity 12480
</pre>
</div>
</content>
</entry>
<entry>
<title>sysdb_get_bool() and sysdb_get_bool() functions</title>
<updated>2012-01-17T16:38:16+00:00</updated>
<author>
<name>Pavel Březina</name>
<email>pbrezina@redhat.com</email>
</author>
<published>2012-01-17T14:32:41+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=6961025be43141b1d1ca4a6a046ce8f3ac94f508'/>
<id>6961025be43141b1d1ca4a6a046ce8f3ac94f508</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>SUDO Integration review issues</title>
<updated>2012-01-17T16:38:15+00:00</updated>
<author>
<name>Pavel Březina</name>
<email>pbrezina@redhat.com</email>
</author>
<published>2012-01-12T08:41:52+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/sssd2.git/commit/?id=f643754db81eeade60485bbe3d80324d889cc4f3'/>
<id>f643754db81eeade60485bbe3d80324d889cc4f3</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
