| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Replaced sprintf in the unit test.
Defined constants for sizes and used them.
Wrpapped lines where noticed that they are longer than 80.
Added comments to the places where sprintf is still used
but it is safe to use.
|
|
|
|
|
|
|
| |
Move GNU_SOUCE definition to configure.ac
Change all headers to use config.h.
Move config.h to the top.
Remove errno.h if it is not needed.
|
|
|
|
| |
Address CLANG issues in the main code.
|
|
|
|
|
|
| |
A Coverity check indicated that ther are platforms where strerror() will
return NULL for unknown, e.g. negative error numbers. Chances are that
these platforms will have problems with NULL arguments to printf() too.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory, was based on count, now limited to segment_count.
* Do not pre-allocate all buckets based on requested table size. This
defeats the point of a dynamic hash table which adjusts it's memory
usage depending upon the number of items it holds. Pre-allocation
also runs afoul of the table contraction logic, if the table is
pre-allocated to a large size it will subsequently try to compact it
negating the pre-allocation. Now the initial allocation is
restricted to one directory segment (i.e. table->segment_count == 1)
* If the caller did not specify the directory_bits and segment_bits
then compute them from the requested table size. The directory_size
and segment_size must be powers of 2 to accmodate fast
arithmetic. An optimal maximum number of buckets would be equal to
the anticipated table size. If there were no collisions that would
mean each item would be located in it's own bucket whose chain
length is 1, the item would be immediatly found upon indexing into
the bucket table.
* There is a requirment there be at least one directory
segment, however contract_table() failed to enforce this
requirement. Add a check to enforce the requirement.
* If hash_create() or hash_create_ex() failed it left the tbl
parameter uninitialized but returned an error code. Now upon failure
tbl is initialized to NULL as well as returning an error code.
* Clean up how the directory and segment sizes were computed. It had
been using a loop and shifting 1 bit at a time, now it shifts all
the bits in one operation and assures at least one directory and
segment are allocated.
* In the event of an early exit from hash_create_ex() due to an error
make sure all previously allocated resources are cleaned up by
calling hash_destroy(). There was only one place this was
missing. hash_destroy() blindly assumed the table had a directory,
normally it would unless hash_destroy was called due to an early
exit in hash_create_ex(). Modify hash_destroy() to check for the
existence of the directory before cleaning up the directory
contents.
* Update the function documentation in dhash.h to explain each
parameter of hash_create() and hash_create_ex().
* Enhance dhash_test.c
- To output the random seed used to intialize the random number
generator and add command line option to set the random seed. This
permits recreating a failed test run.
- Add command line parameter to set the initial table size.
- Use proper string to long conversion routines when reading command
line parameters (e.g. strtoul() instead of atoi())
- Add logic to make sure each test value is unique.
* Add additional information to the debug output to show the computed
directory_bits, segment_bits, sizes, etc.
* Adjust the debug_level conditionals to be less verbose.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
size_t is used in dhash.h and was currently not defined by any included
header file.
|
| |
|
|
|
|
|
| |
This changes our approach from having independent tarballs to
having a single, monolithic tarball for all of the libraries
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Old versions of autoconf (before 2.60) did not include
support for the docdir and abs_builddir variables. This
patch emulates support for them.
Fixes https://fedorahosted.org/sssd/ticket/422
|
| |
|
|
|
|
|
|
|
|
| |
Right now, the pkg-config checks for the system version of
libdhash are forcibly disabled, requiring the SSSD to build it
from its own tree. In the future, when we split the libraries off
from the SSSD, it will be easy to switch this check to the
external library.
|
| |
|
| |
|
|
|
|
|
| |
Also pass a flag to the delete callback to tell it if this is a normal
entry removal or we are cleaning up the tbale definitively.
|
|
|
|
| |
Previously we were only building them but not running them.
|
| |
|
| |
|
|
|
|
| |
Necessary for RPM builds on RHEL5
|
| |
|
|
|
|
|
|
| |
Previously, only the SSSD server components were being built with
compile-time warnings enabled. This patch will ensure that all
components in common and sss_client are also built the same way.
|
|
|
|
| |
Fix consts and function declarations
|
|
|
|
|
|
|
|
|
| |
If automake 1.11 or higher is available, use of the configure
option '--enable-silent-rules' will suppress most build messages
and replace them with lines such as
CC sysdb.o
This affects libtool as well.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LT_INIT is supported only on Libtool >= 2.0, so I reverted it to
using AC_PROG_LIBTOOL.
Also reorganized how the common libraries were being built. Now
they are treated as libtool convenience libraries instead of
installable libraries (the --with-singlelib configure flag can
still be used to generate a combined, installable DSO)
I cleaned up the set of files being installed by automake, so the
list of things we need to remove before packaging the RPM is now
only the .la files associated with our own plugins.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Ensures that the common libraries build statically.
Also ensures that the sssd.spec creates the SYSV init script with
the appropriate permissions.
Cleans up the useless rpmdist target that was obsolete.
Adds the *.so.N.0.0 files to the RPM, as the .so and .so.N files
were dangling symlinks.
|
| |
|
|
|
|
|
|
| |
Allow configuration and build of individual SSSD utility libraries
from their own subdirectories. Building all utilities is still
possible recursively from the common root.
|
|
Apply suggested fixes by Simo after code review
* return statements no longer use () unless it's an expression
* remove all use of assert() in library
* use bool,true,false instead of int,TRUE,FALSE
* add check for NULL hash table in public entry points
* example code in header file now a seperate file
* assure consistent use of unsigned long data type
* add more debugging support
* break out generation of integer key into convert_key() function
* table parameters now tunable rather than hardcoded
* table can now accept custom alloc()/free() functions
* add function create_table_ex() to pass extra table parameters
* remove MUL(), DIV(), MOD() macros
* hash statistics now separate struct which can be queried
* test program now accepts tuning parameters, iteration count; has better error checking and reporting
fix min/max load factor comman line args in test program
|