<feed xmlns='http://www.w3.org/2005/Atom'>
<title>ding-libs2.git/ini, branch master</title>
<subtitle>'D is not GLib' utility libraries [okos' clone]</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/'/>
<entry>
<title>INI: Remove dead code</title>
<updated>2013-04-05T11:15:18+00:00</updated>
<author>
<name>Ondrej Kos</name>
<email>okos@redhat.com</email>
</author>
<published>2013-04-03T11:25:28+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=e9a8759bcc696d78ce9d8187e263cfd90c96fdef'/>
<id>e9a8759bcc696d78ce9d8187e263cfd90c96fdef</id>
<content type='text'>
https://fedorahosted.org/sssd/ticket/1857

Discovered by coverity
The code was inaccessibile, if no key is present, the error will
occur before this check.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://fedorahosted.org/sssd/ticket/1857

Discovered by coverity
The code was inaccessibile, if no key is present, the error will
occur before this check.
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove spurious cast</title>
<updated>2013-03-29T09:14:48+00:00</updated>
<author>
<name>Jakub Hrozek</name>
<email>jhrozek@redhat.com</email>
</author>
<published>2013-03-28T19:09:29+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=ff863970210e07383b6ffd9e5000b5d07d3a359b'/>
<id>ff863970210e07383b6ffd9e5000b5d07d3a359b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Expose collected stat data</title>
<updated>2013-01-28T11:03:23+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2013-01-27T01:07:48+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=44174288111e9715ccbb96e8a8283e99a721ba7b'/>
<id>44174288111e9715ccbb96e8a8283e99a721ba7b</id>
<content type='text'>
Added a new top level interface funtion
and a unit test for it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Added a new top level interface funtion
and a unit test for it.
</pre>
</div>
</content>
</entry>
<entry>
<title>Check is the stats we collected</title>
<updated>2013-01-28T09:47:33+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2013-01-26T21:47:56+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=059519fb2a8d056eba5f61cde98ed8b5292195d4'/>
<id>059519fb2a8d056eba5f61cde98ed8b5292195d4</id>
<content type='text'>
This patch corrects a problem related to stats being accessed
and evaluated without being initialized.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch corrects a problem related to stats being accessed
and evaluated without being initialized.
</pre>
</div>
</content>
</entry>
<entry>
<title>Unit test for parsing flags.</title>
<updated>2013-01-24T07:34:56+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2012-12-25T14:31:07+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=66e30c2f3862093505a8497744207d2812c95be3'/>
<id>66e30c2f3862093505a8497744207d2812c95be3</id>
<content type='text'>
Added unit test.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Added unit test.
</pre>
</div>
</content>
</entry>
<entry>
<title>More interface refactoring</title>
<updated>2013-01-24T07:34:51+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2012-12-24T22:45:00+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=6823d7104cca0f8ac22ed9432ee8a2f1a0d9124a'/>
<id>6823d7104cca0f8ac22ed9432ee8a2f1a0d9124a</id>
<content type='text'>
I also realized that error list processing should not be
bound to the file object.
This patch corrects that by moving the error_list and
corresponding count from file object to the config object.
Things updated by the patch:
1. The internal variables are moved from file obj to config obj.
2. The external header is updated to reflect the change
3. Functions are moved from file obj module to config obj module.
4. Parser code is updated because error validation was in
   the wrong place
5. Unit test is adjusted to get error list from the right object.

I had to adjust the copy function for the config object.
Copy function does not copy over the error list.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
I also realized that error list processing should not be
bound to the file object.
This patch corrects that by moving the error_list and
corresponding count from file object to the config object.
Things updated by the patch:
1. The internal variables are moved from file obj to config obj.
2. The external header is updated to reflect the change
3. Functions are moved from file obj module to config obj module.
4. Parser code is updated because error validation was in
   the wrong place
5. Unit test is adjusted to get error list from the right object.

I had to adjust the copy function for the config object.
Copy function does not copy over the error list.
</pre>
</div>
</content>
</entry>
<entry>
<title>Introducing parsing flags</title>
<updated>2013-01-24T07:34:48+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2012-12-24T18:33:44+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=fa00e2e16e5c1d3ac56f1bbd3a84875642d0bb39'/>
<id>fa00e2e16e5c1d3ac56f1bbd3a84875642d0bb39</id>
<content type='text'>
1.  Added definition of the parsing flags to the header.
2.  Added new argument to the parser.
3.  Added function to check the correctness of the line.
4.  Added new constants and strings for errors.
5.  Refactored function that handles spaces.
6.  Moved handle_space since it now calls handle_kvp.
7.  Updated handle_kvp to trim spaces at the beginning.
8.  Adjusted line inspection to handle any space character.
9.  Adjusted exising unit tests. Added parameter to the call.
10. Found couple places where there was a space at the end
    of the line and cleaned them.

The additional unit tests will be added in the follow up patch.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
1.  Added definition of the parsing flags to the header.
2.  Added new argument to the parser.
3.  Added function to check the correctness of the line.
4.  Added new constants and strings for errors.
5.  Refactored function that handles spaces.
6.  Moved handle_space since it now calls handle_kvp.
7.  Updated handle_kvp to trim spaces at the beginning.
8.  Adjusted line inspection to handle any space character.
9.  Adjusted exising unit tests. Added parameter to the call.
10. Found couple places where there was a space at the end
    of the line and cleaned them.

The additional unit tests will be added in the follow up patch.
</pre>
</div>
</content>
</entry>
<entry>
<title>Refactor interface a bit</title>
<updated>2013-01-24T07:34:43+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2012-12-24T16:31:24+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=3b9baa61367f2b651c8068efc99ce017331622e0'/>
<id>3b9baa61367f2b651c8068efc99ce017331622e0</id>
<content type='text'>
After some evaluation it became apparent that error level
and collision flags should not be a part of the fileobj
but rather passed directly to the parser function.
This way the interface is more clean and logical.
This patch:
1) Removes the error level and collision flags from
the fileobj
2) Moves validation function from ini_fileobj.c
to ini_configobj.c where it belongs.
3) Moves error level and collision flags arguments
from file open function to the parser function.
4) The internals of the file obj are cleaned
5) Validation of the arguments is moved to parser function.
6) Unit tests are updated.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After some evaluation it became apparent that error level
and collision flags should not be a part of the fileobj
but rather passed directly to the parser function.
This way the interface is more clean and logical.
This patch:
1) Removes the error level and collision flags from
the fileobj
2) Moves validation function from ini_fileobj.c
to ini_configobj.c where it belongs.
3) Moves error level and collision flags arguments
from file open function to the parser function.
4) The internals of the file obj are cleaned
5) Validation of the arguments is moved to parser function.
6) Unit tests are updated.
</pre>
</div>
</content>
</entry>
<entry>
<title>Replacing sprintf with snprintf</title>
<updated>2013-01-24T07:34:40+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2012-12-23T18:49:56+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=833a46e384828be48c27898e755d6215eb5c4bb8'/>
<id>833a46e384828be48c27898e755d6215eb5c4bb8</id>
<content type='text'>
Replaced sprintf in the unit test.
Defined constants for sizes and used them.
Wrpapped lines where noticed that they are longer than 80.
Added comments to the places where sprintf is still used
but it is safe to use.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replaced sprintf in the unit test.
Defined constants for sizes and used them.
Wrpapped lines where noticed that they are longer than 80.
Added comments to the places where sprintf is still used
but it is safe to use.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixing headers</title>
<updated>2013-01-24T07:34:37+00:00</updated>
<author>
<name>Dmitri Pal</name>
<email>dpal@redhat.com</email>
</author>
<published>2012-12-23T18:03:00+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/okos/public_git/ding-libs2.git/commit/?id=57faa64667411a3d8eeeeff62b1e659a94ed29cf'/>
<id>57faa64667411a3d8eeeeff62b1e659a94ed29cf</id>
<content type='text'>
Move GNU_SOUCE definition to configure.ac
Change all headers to use config.h.
Move config.h to the top.
Remove errno.h if it is not needed.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move GNU_SOUCE definition to configure.ac
Change all headers to use config.h.
Move config.h to the top.
Remove errno.h if it is not needed.
</pre>
</div>
</content>
</entry>
</feed>
