| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
One liner to fix Coverity isssue 10044.
|
|
|
|
|
| |
Noticed under valgrind then checked
and saw that this is a coverity issue 10077.
|
|
|
|
|
|
| |
The 'len' varible was not initialized properly.
The ref_array_get function does not return error so
the error check is removed.
|
|
|
|
|
|
|
|
| |
I investigated the coverity issue 10043.
Reading code did not reveal the issue.
I added the test just to be sure and ran
valgrind again. It does not seem to leak
despite the Coverity concerns.
|
|
|
|
|
|
|
|
| |
The paths to test files did not work in
parallel build or 'make diskcheck' cases.
Now they are corrected. All temp files are
created in the build directory and read
from there.
|
|
|
|
|
|
| |
This patch addresses the crashes with the file object
when the file is not there and the file context
needs to be destroyed during the open operation.
|
|
|
|
|
|
|
| |
* Rearranged code in parser module and
created a skeleton of the function that will
be responcible for merging sections.
* Added missing static declarations to some functions.
|
|
|
|
|
| |
Added validation of the collision flags
at the interface boundary.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is the first pass at merging functionality.
It implements merging of values that belong to the same
section. Patch includes:
* Definition of merge flags in doxy format
* Definition of the masks in internal header
* Changes to parser to handle the merging of values.
* Also swithed parser to not use ini_config.h as
I want to switch implementation of the current
interface to new interface at some point.
* New unit test was created.
* New config file for this unit test was added to ini.d
Main code changes are in ini_parse.c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added method to copy configuration.
* Added unit test for it.
* Added method to reset boandary for the
whole configuration.
* Added unit test for it.
* Unit test now can read a file
save it read again and save.
Both saves produce same files!
* Reworked the way the parser was dealing
with empty lines. It was sutting
off the value in the middle
if the folded line consisted of
just spaces.
|
|
|
|
|
|
| |
* Fixed different issues with folding
and serialization
* Added more unit testing.
|
|
|
|
| |
Minor cleanup in the error reporting.
|
|
|
|
|
|
|
| |
* Added capability to copy value.
* Added function to set alternative wrapping boundary
of the value.
* Created a unit test for both new functions.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added copy coment functionality
* Changed the internal implementation to
use array simple buffer instead of
the two arrays one for lines and one for lengths
* Realigned comments in the header file
* Changed the trace macros to use
simplified entry and exit macros.
* Corrected unit test to return error codes.
* Refactored unit test to use array
of test functions intead of the direct calls
* Added unit test for copy functionality.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
The patch contains two major pieces of work:
* The beginning of the new INI interface
significantly re-thought and reworked.
* The implementation of the file object.
Parsing was adjusted to use this object.
|
|
|
|
|
|
|
|
|
|
| |
I realized that the new high level interface should be
defined in one file instead of being scattered in many headers.
I would have to eventuallu eliminate ini_configobj.h too
and move everything to the new interface in ini_config.h.
This patch renames couple functions to be consistent
with the naming convention and removes ini_parse.h header.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The parser is added to the existing module.
The old parsing functuion will be removed when we
switch to the new interface.
Parser logic:
* There is one high level function that wraps the
parser interface. It is at the bottom of the module.
ini_parse_config();
* Internally it creates a perser object
and then runs parser on it.
* At the end parser object is destroyed.
* This object stores the state of the parser.
* The parser has an action queue
* There are several actions that parser can perform
- read line
- inspect read line
- record an error
- process last comment in the file (POST)
* Each action handler determines what to do next
depending upon what has happened.
* Read handler reads lines and enqueues inspection action
in case of success or error action in case of failure.
* Inspection action parses last read line and
treats it either is a:
* Comment
* Section
* New key + value
* Continuation of the value
In case of error the error action is enqueued.
* Error can be fatal or non fatal. It depend on the error_level
flag passed in. If the error is non fatal the read action is
enqueued otherwise parser stops.
* The POST action is a special action to handle comment at
the bottom of the file. The comment is stored with the
value it preceeds so in case there is a comment at
the bottom of the file a special value needs to be created
to hold just the comment.
|
|
|
|
|
|
|
|
| |
* ini_config_priv.h - private header
* ini_configobj.h - future public header for the new interface
* ini_configobj.c - just constructor/decructor for now
* ini_serialize.c - code to serialize the configuration
into a buffer so it can be written somewhere.
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removed the annoyong type casting in the serialization
since there is a new function in the simplebuffer to
addstring.
* Changed the serialization code to not create simple
buffer object but rather add to the passed in one.
* Added serialization of the value that stores section
* Started cleaning constants but then stopped since
this effor should be done a bit later when the new
high level ini config interface is better baked.
|
| |
|
|
|
|
|
| |
Take advantage of the already known string length instead
of counting bytes once more.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Value object is an object that combines
a potentially multiline value
comment and some statistical information
regarding a configuration value.
Patch includes:
Source
Header
Unit test
Makefile changes
|
|
|
|
| |
Comment object should store lengths of the lines.
|
|
|
|
|
| |
This changes our approach from having independent tarballs to
having a single, monolithic tarball for all of the libraries
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Addressing coverity issue. Ticket #513.
The memory was really leaked when
the configuration value was empty.
Added unit test that confirmed the bug.
MANUAL MERGE.
|
|
|
|
|
|
|
|
| |
Addressing ticket #504
Conflicts:
common/ini/ini_config.c
|
| |
|
|
|
|
|
| |
This is a reworked patch to add support for explicit
32 and 64 bit values in the config files.
|
|
|
|
|
|
|
|
|
| |
Comment object will store
the comments found in the INI file.
It is based on the ref_array
interface.
Fixing review comments for comment obj.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Time came to split ini_config.c
into many much smaller pieces.
1) ini_parse.c - will have parsing functions
2) ini_get_value.c - will have single value
interpretation functions
3) ini_get_array.c - will have array interpretation
functions.
4) ini_print.c - error printing
5) ini_defines.h - common constants
6) ini_parse.h header for parsing functions
7) ini_list.c - will have list processing functions
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When running 'make distcheck', the entire source directory is set
to read-only, to ensure that the build process only has write
access to $builddir. As a result, this was causing the unit test
for file mode to fail, since the file it was testing resides in
the $srcdir.
This patch guarantees that the test file has the correct
permissions prior to running the access test.
|
|
|
|
| |
[TRACE] Adding macros for signed numbers
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fixed the issue that metadata was saved
as numbers. Was supposed to be saved as strings.
2) Added two functions. One is to check permissions
on the config file. Another to check if the file
has changed and thus the cinfiguration needs
to be reread.
3) Added unit test will sample code
and comments how to use the functions.
4) Added doxygen description in the comments.
5) Fixed couple typos and ommisions here and there.
[INI] Fixing crash detected on 64-bit system
This patch corrects original code to be
more on the safe side and check parameters
before using.
Instead of dereferencing metadata it is now
passed as reference to the next level.
It is not used there yet so no other new changes
needed so far.
[INI] Addressing review comments
[INI] Addressing comments.
|
| |
|
|
|
|
|
|
| |
This patch implements function that collects
stats and saves them in the ACCESS section
inside metadata.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch:
1) Adds the definition of the metadata interface
to the header file. The functions that were exposed
for no good reason are now hidden.
2) Previously exposed functions and their descriptions
are removed from the public header and placed into
the source code for now.
3) The function that reads the config file no longer
tries to close file in case of error.
4) Lines collection is still passed in into the reading
function but as a collection itself not as a pointer
to it.
5) All the parts related to processing lines are currently
ifdefed using HAVE_VALIDATION that is currently is not defined.
This is done to disable creation of the lines collection
utill it is actually needed. I did not want to blindly remove
it though and loose already done work that will be useful
in future.
6) Version of the library and interface is updated
7) New header and source modules are introduced to hold functions
related to the meta data. They are mostly stubbed out.
This is incomplete patch. It builds and make check runs.
It is created just to simplify the review a bit.
|
|
|
|
| |
Additional changes.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
The null-terminator would have been written one byte past the end
of the array (and there may have been an extra garbage character
in the index before it)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The original implementation was compressing the list,
throwing away empty strings.
The function that did that was pretty brain damaging.
I cleaned it up and adjusted so that it could return
list with empty values and without them.
The old function was turned into a wrapper and a new
high level function was intorduced to provide
ability to get both empty and non empty strings.
|