| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
https://fedorahosted.org/sssd/ticket/1858
|
|
|
|
| |
https://fedorahosted.org/sssd/ticket/1856
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Guenther
|
|
|
|
|
| |
Added a new top level interface funtion
and a unit test for it.
|
|
|
|
|
| |
This patch corrects a problem related to stats being accessed
and evaluated without being initialized.
|
|
|
|
| |
Added unit test.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also realized that error list processing should not be
bound to the file object.
This patch corrects that by moving the error_list and
corresponding count from file object to the config object.
Things updated by the patch:
1. The internal variables are moved from file obj to config obj.
2. The external header is updated to reflect the change
3. Functions are moved from file obj module to config obj module.
4. Parser code is updated because error validation was in
the wrong place
5. Unit test is adjusted to get error list from the right object.
I had to adjust the copy function for the config object.
Copy function does not copy over the error list.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Added definition of the parsing flags to the header.
2. Added new argument to the parser.
3. Added function to check the correctness of the line.
4. Added new constants and strings for errors.
5. Refactored function that handles spaces.
6. Moved handle_space since it now calls handle_kvp.
7. Updated handle_kvp to trim spaces at the beginning.
8. Adjusted line inspection to handle any space character.
9. Adjusted exising unit tests. Added parameter to the call.
10. Found couple places where there was a space at the end
of the line and cleaned them.
The additional unit tests will be added in the follow up patch.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After some evaluation it became apparent that error level
and collision flags should not be a part of the fileobj
but rather passed directly to the parser function.
This way the interface is more clean and logical.
This patch:
1) Removes the error level and collision flags from
the fileobj
2) Moves validation function from ini_fileobj.c
to ini_configobj.c where it belongs.
3) Moves error level and collision flags arguments
from file open function to the parser function.
4) The internals of the file obj are cleaned
5) Validation of the arguments is moved to parser function.
6) Unit tests are updated.
|
|
|
|
|
|
|
|
| |
Replaced sprintf in the unit test.
Defined constants for sizes and used them.
Wrpapped lines where noticed that they are longer than 80.
Added comments to the places where sprintf is still used
but it is safe to use.
|
|
|
|
|
|
|
| |
Move GNU_SOUCE definition to configure.ac
Change all headers to use config.h.
Move config.h to the top.
Remove errno.h if it is not needed.
|
|
|
|
|
| |
Reviewed all uses or errno. Cleaned places that needed cleaning.
Did not remove <errno.h> yet where it is not needed.
|
|
|
|
|
| |
Patch converts error and error level
to enum instead of defines.
|
|
|
|
|
| |
Refactored the defines to enum.
Added support for fetching last value from the section.
|
| |
|
|
|
|
| |
Address CLANG issues in the main code.
|
| |
|
|
|
|
|
|
| |
The parser unit test have been updated to execute the changes
in the parser code.
A new test was added to execute merge code in all possible modes.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Move the last comment into the config object
Last comment in the file was previously treated as a special
value in the last section in the configuration object.
That created difficulties while merging. Storing an orphan
comment as part of the config object is a better approach
2. Since the structure of the config object changed
the internal header and serialization required update.
3. Parser code was updated to:
- deal with the last comment on the top level
- make sure the right error codes are returned in
different modes
- pass right information through the layers which caused
some refactoring of the internal calls
- prevent using an already used configuration object
as an input to parser.
|
|
|
|
| |
This patch adds capability to merge two configuration objects.
|
| |
|
|
|
|
|
| |
Patch allows merging comments that are part of the two different
value objects. The values are not merged.
|
|
|
|
|
|
| |
Patch adds ability to combine two different comments into one.
It includes changes to the comment API, header file and unit test.
It also fixes an invalid free in one of the error cases.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Duplicate sections in the config tree is a bad idea.
After more evaluation I decided to not allow more than one section
with the same name to be acceptable in the resulting object.
All duplicate sections need to be processed so that only
one section is left as a result. The collision flags control that.
It is OK to remove it as this code has not been released yet.
I also spotted that unit test does not exit if the system()
call was successful but the command it invoked was not.
Fixed that. Also fixed couple spelling mistakes here and there.
|
|
|
|
|
|
|
| |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=637955
Also while fixing this, I found that rpmbuild was broken due to missing
includes in ini_config-devel spec.
|
|
|
|
|
| |
The doxygen files contained some deprecated values and typos.
This patch cleans them for all interfaces exposed by ding libs.
|
|
|
|
| |
This patch fixes the doxygen warnings in the new interface.
|
|
|
|
| |
Pointer was not initialized before being read.
|
|
|
|
|
| |
1. The header files were not included into the package.
2. The `make distcheck` commnd was failing due to typo.
|
|
|
|
|
| |
This patch stops building interface docs for the old interface
and starts generating description for the new interface.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The three files in the patch implement the functions
of the new interface. It is mostly inspired by the old
interface except that the string value is replaced with
the value object that hides all the metadata about
the value itself. The main function to get value
now allows more than one value per key.
|
|
|
|
|
|
|
| |
The search state allows one to search a configuration object
for the same key in the cases when a key permits more
than one value scattered across the config file.
The state needs to be stored, initialized and properly cleaned.
|
|
|
|
|
|
|
|
| |
Some time ago I started the new INI interface
that exists in parallel to the existing interface
but uses value object to store value rather than just
strings. The header has all the details about the new
interface.
|
|
|
|
|
|
|
|
|
| |
The patch adds function to get the length of
the concatenated value. It also adds a convenince
print function that is convenint in debugging
the values inside configuration object.
Patch also add checkes for input values
that can be passed by pointer.
|
|
|
|
| |
File is copied from the test itself.
|
|
|
|
|
|
|
|
|
| |
The unit test was broken. The wrong function was used.
To make sure everything is correct I also added a convenience
function to print the internals if the file context object.
The unit test is fixed to use relative paths consitently.
Also added nice statements at the beggining and the end of
the unit test functions where they were missing.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
When running 'make distcheck', all files in the $srcdir are set to
read-only, to ensure that the build does not modify the source.
However, this broke our ability to test file permissions. We will
now copy the file to the builddir and do the tests there, where
we have control.
|