[qacp] Fix improper free when connect fails

Freeing from the middle of an allocated string is not right.
Keep a pointer to the strdup so we can free it correctly.

1 files changed, 5 insertions, 5 deletions

diff --git a/qacp.c b/qacp.c
index 2c39c96..6ddf414 100644
--- a/qacp.c
+++ b/qacp.c
@@ -479,7 +479,7 @@ recvfiles(char **argv, int argc, int fileidx, short recursive)
 int
 sendfiles(char **argv, int argc, int fileidx, short recursive)
 {
-	char *cp, *cp2;
+	char *cp, *cp2, *freeme;
 	char *rhost = NULL;
 	char *ruser = NULL;
 	char *rgrp = NULL;
@@ -500,7 +500,7 @@ sendfiles(char **argv, int argc, int fileidx, short recursive)
 		return -1; 
 	}
 
-	rhost = strdup(argv[argc-1]);
+	freeme = rhost = strdup(argv[argc-1]);
 	cp = strchr(rhost, ':');
 	*cp = '\0';
 
@@ -518,7 +518,7 @@ sendfiles(char **argv, int argc, int fileidx, short recursive)
 
 	if (!(pw = getpwuid(getuid()))) {
 		fprintf(stderr, "qacp: unknown user id.\n");
-		free(rhost);
+		free(freeme);
 		return -1;
 	}
 
@@ -536,7 +536,7 @@ sendfiles(char **argv, int argc, int fileidx, short recursive)
 				rhost, QARSHD_CONTROL_PORT, errno, strerror(errno));
 		}
 
-		free(rhost);
+		free(freeme);
 		return -1;
 	}
 
@@ -593,7 +593,7 @@ sendfiles(char **argv, int argc, int fileidx, short recursive)
 			} else {
 				fprintf(stderr, "%s:%s - %s\n", rhost, rmtpath, 
 				        strerror(rstaterrno));
-				free(rhost);
+				free(freeme);
 				return -1;
 			}
 		}