summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNathan Straz <nstraz@redhat.com>2009-01-08 18:12:45 -0500
committerNathan Straz <nstraz@redhat.com>2009-01-08 18:12:45 -0500
commited36373d0d92306cd89085be00637c1c3624edff (patch)
treede6a4e0d2ee4e39fe7a5e221a620b21ff5d8394e
parentf2419cc098d9f802765eb3cf71be698d411e086e (diff)
downloadqarsh-ed36373d0d92306cd89085be00637c1c3624edff.tar.gz
qarsh-ed36373d0d92306cd89085be00637c1c3624edff.tar.xz
qarsh-ed36373d0d92306cd89085be00637c1c3624edff.zip
[qarsh] Remove continue which could make qarsh hang
I don't know how, but I found one instance of qarsh looping through the pselect loop with a one second timeout. If the command has exited and the output file descriptors are all closed, we fall onto this continue which prevents us from getting to the break at the end of the loop. The only thing the continue skips over is that check which we really should check, so remove the continue.
-rw-r--r--qarsh.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/qarsh.c b/qarsh.c
index 2e43658..9bfd295 100644
--- a/qarsh.c
+++ b/qarsh.c
@@ -297,10 +297,6 @@ run_remote_cmd(char *cmdline)
* The hbeat state will take precedence over the
* exit status of the command. */
break;
- } else {
- /* No output to process, the command is
- * still running, and the host is still up */
- continue;
}
}