| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
- Gui allows to save results in info object
- Info object allows attaching files and saving as .zip archive
|
| |
|
| |
|
| |
|
|
|
|
| |
Config question. Also add radio button mode to Config question.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
- Expert tab is hidden by default
- Config dialog checks the format of entered values
- Example plugin for dialogs updated
|
| |
|
| |
|
| |
|
|
|
|
| |
(exception) issues
|
|
|
|
| |
Gtk UI
|
|
|
|
| |
Add /usr/share prefixes for architecture independent data
|
|
|
|
| |
Signed-off-by: Martin Sivak <msivak@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
queue operations, which causes an automatic deadlock on
a: get
a: ... lock _queue_lock
a: ... block on _queue
b: put
b: ... block on _queue_lock
Because nobody reads from the main queue that used round = True, this
doesn't change application behavior.
* Drop return value of Reports.put, it is always None anyway.
* Fix self._mailboxes locking: instead of
try:
lock
...
finally:
unlock
it needs to be
lock
try:
...
finally:
unlock
|
|
|
|
| |
Signed-off-by: Martin Sivak <msivak@redhat.com>
|
| |
|
|
|
|
| |
of answer
|
|
|
|
| |
standard methods of message construction
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makefile:
1. Cut counts from 1 not 0.
2. Create the "about" info in the makefile instead of spec file.
3. Put subdirs and about targets into one build target.
firstaidkit.spec:
1. Erase the about creation from here.
2. Erase the fedora 7 specific stuff.
3. Call make build.
4. xserver plugin does not need rhpl nor rhpxl anymore.
5. Actually include the COPYING file where the about says it is.
configuration.py:
1. Change the default backup dir from /tmp/fakbackup to /tmp.
/tmp/fakbackup caused some file permission strangeness when
a non root user executed fak after root had executed it. This
can still occur, but it will be left like this as the user
should not execute fak in non root anyway.
logging:
plugins.py,interpreter.py. __init__.py
1. Always use the reporting object when possible.
2. Add time stamp and level of message to log messages.
|
|
|
|
|
| |
Put the reverting logic into the main Backup class. This will allow
future classes that inherit from Backup to have this attribute.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Parse the arguments correctly for grub plugin.
Set the internal variables correctly for grub plguin.
Use the internal variavels when deciding which dev to install to.
plugin.py:
user lstrip instead of just strip to take off the first part of the
argument string. This still has an issue as the strip does not strip
strings but strips away all the characters listed in the str. At the
moment its working because the args always begin with "-" and the
plugin names dont have "-" in their names. but this might be a problem
in the future.
|
|
|
|
|
|
|
| |
It is necessary to differentiate between calling the BackupPersistent class
for backup purposes or for reverting purposes.
Also the grub revert function and the firstaidkitrevert file changed to
address the new changes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces new requirements to the plugins.
1. If a plugin wants to be revertable it must implement the revert function.
This function will be accessible from the plugins top most namespace. The
same place where get_plugin is.
2. For the plugin's backend directory to be easily found, the plugin must
give the backend its module name as an id. In this way when the user
specifies in the revert command line plugin 'x', the revert class will
go to the backup directory in search for a directory called the same
way as the module of 'x'.
3. If the plugin developer does not want to use the system of backup dir
naming, there is a second way how to specify the backup dir. The
plugin must specify a function getBackupId(), that will return the id
of the backup space that can be used for the backup dir search.
Backup spaces that fail to comply with these directive will be ignored.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
It is possible for the plugin name to have a space. when this
occured it threw off the argument detecting logic. This new
way of detecting the plugin name is more general.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This is more an esthetic change. Now, when the user defines the fullpath
the rootpath will be "" and not have some other value that does not relate
to the fullpath.
|
|
|
|
|
|
|
|
| |
Given that firstaidkit is fully automated we need a way to modify the
plugin behaviour from the initial command. This makes it easy for the
plugin developer to get a string with some arguments for his plugin.
It is up to the plugin developer to parse the string.
The arguments will be accessible through self._args variable.
|
|
|
|
|
|
| |
Use tempfile to create safe backup directories. User should define
backup.fullpath if he wants to override the default behaviour.
User can also choose the directory where the backup directory goes.
|
| |
|
| |
|
|
|
|
|
| |
Nothing was used from the original grub plugin. For now
they will both coexists in the code.
|
|
|
|
|
|
| |
This is the better way of doing things. If the prepare step
is a failure we cannot ensure the sate that the plugin
expects. Its best to go to clean and exit with no changes.
|
|
|
|
|
| |
This will make life much easier for the plugin developers. Now there
is no need to specify level inside the plugin.
|
|
|
|
|
|
|
|
| |
- This patch will append an "FAK_ERROR" string to the error message.
This will help them to be noticed when the user encounters them in
the log or the stdout.
- Create parent error class that has all the common qualities for the
error classes.
|
| |
|