| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makefile:
1. Cut counts from 1 not 0.
2. Create the "about" info in the makefile instead of spec file.
3. Put subdirs and about targets into one build target.
firstaidkit.spec:
1. Erase the about creation from here.
2. Erase the fedora 7 specific stuff.
3. Call make build.
4. xserver plugin does not need rhpl nor rhpxl anymore.
5. Actually include the COPYING file where the about says it is.
configuration.py:
1. Change the default backup dir from /tmp/fakbackup to /tmp.
/tmp/fakbackup caused some file permission strangeness when
a non root user executed fak after root had executed it. This
can still occur, but it will be left like this as the user
should not execute fak in non root anyway.
logging:
plugins.py,interpreter.py. __init__.py
1. Always use the reporting object when possible.
2. Add time stamp and level of message to log messages.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Parse the arguments correctly for grub plugin.
Set the internal variables correctly for grub plguin.
Use the internal variavels when deciding which dev to install to.
plugin.py:
user lstrip instead of just strip to take off the first part of the
argument string. This still has an issue as the strip does not strip
strings but strips away all the characters listed in the str. At the
moment its working because the args always begin with "-" and the
plugin names dont have "-" in their names. but this might be a problem
in the future.
|
| | |
|
| |
|
|
|
|
| |
It is possible for the plugin name to have a space. when this
occured it threw off the argument detecting logic. This new
way of detecting the plugin name is more general.
|
| |
|
|
|
|
|
|
| |
Given that firstaidkit is fully automated we need a way to modify the
plugin behaviour from the initial command. This makes it easy for the
plugin developer to get a string with some arguments for his plugin.
It is up to the plugin developer to parse the string.
The arguments will be accessible through self._args variable.
|
| |
|
|
|
|
| |
This is the better way of doing things. If the prepare step
is a failure we cannot ensure the sate that the plugin
expects. Its best to go to clean and exit with no changes.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When deviding a string into two lines one must use pythons automatic
string concatenation (python concatenates strings that are in different
line but are inside parenthesis). Do not use the "\" in the string as
this will cause strange and unwanted output.
Yes:
print("long string"
"rest of string")
No:
print("long string \
rest of string")
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Indendtation should be 4 spaces. There was a function indented with
8 spaces.
- Lines should be shorted than 80 chars. It just looks pretty :)
Think of terminals whith only 80 char of length. Think of debuging
in rescue mode.
- Change also the print statements. Just getting ready for python 3000.
- Get some spaces between elifs
- There should not be any lines ending in spaces.
- This can all be read in the python code conventions
http://www.python.org/dev/peps/pep-0008/
|
| | |
|
| |
|
|
| |
We don't want to fail as other paths might be usefull.
|
| | |
|
| |
|
|
|
| |
The new variable name better expresses the objective of the issue state.
This will help avoid confusion for the plugin developer.
|
| |
|
|
| |
class (so everybody can use something simple to report state)
|
| | |
|
| |
|
|
| |
print error message)
|
| | |
|
| |
|
|
| |
the None result in flow
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Use reporting when possible (some messages automatically use Logger to avoid duplication)
Improve the Output thread to use the new level/importance system
|
| |
|
|
| |
find it's parts
|
| |
|
|
|
|
| |
flows into diagnostics and fixes.
So when the user launches ./firstaidkit -a it runs only diagnostics. For fixing use ./firstaidkit -a fix
|
| |
|
|
|
| |
Fix the NoOptionError exception throwing in configuration
Add the -a|--auto parameter to launch the automatic mode of operation
|
| | |
|
| |
|
|
|
| |
True and false are not very generic for the flows. Favorable and
Unfavorable are not completely generic but are better.
|
| |
|
|
|
|
| |
system for it.
Add --info and --list commands for getting the information about plugins.
|
| |
|
|
| |
as the user sees necessary.
|
| | |
|
| | |
|
| |
|
|
| |
Add "activity" flags, so our "Tracker plugins logic" can work
|
| | |
|
| | |
|
| |
|
|
|
| |
Put the Logger in the __builtin__.
Use Config object to initialize the default values.
|
| | |
|
|
|
site-packages.
|
