| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makefile:
1. Cut counts from 1 not 0.
2. Create the "about" info in the makefile instead of spec file.
3. Put subdirs and about targets into one build target.
firstaidkit.spec:
1. Erase the about creation from here.
2. Erase the fedora 7 specific stuff.
3. Call make build.
4. xserver plugin does not need rhpl nor rhpxl anymore.
5. Actually include the COPYING file where the about says it is.
configuration.py:
1. Change the default backup dir from /tmp/fakbackup to /tmp.
/tmp/fakbackup caused some file permission strangeness when
a non root user executed fak after root had executed it. This
can still occur, but it will be left like this as the user
should not execute fak in non root anyway.
logging:
plugins.py,interpreter.py. __init__.py
1. Always use the reporting object when possible.
2. Add time stamp and level of message to log messages.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Indendtation should be 4 spaces. There was a function indented with
8 spaces.
- Lines should be shorted than 80 chars. It just looks pretty :)
Think of terminals whith only 80 char of length. Think of debuging
in rescue mode.
- Change also the print statements. Just getting ready for python 3000.
- Get some spaces between elifs
- There should not be any lines ending in spaces.
- This can all be read in the python code conventions
http://www.python.org/dev/peps/pep-0008/
|
|
|
|
|
| |
Use reporting when possible (some messages automatically use Logger to avoid duplication)
Improve the Output thread to use the new level/importance system
|
| |
|
| |
|
|
|
|
|
| |
Put the Logger in the __builtin__.
Use Config object to initialize the default values.
|
|
site-packages.
|