| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
1. Comment all the stuff we dont have in fedora distro. This makes it
much easier to cp the spec file when creating the new version of fak.
2. xserver.py: Its not experimental anymore.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makefile:
1. Cut counts from 1 not 0.
2. Create the "about" info in the makefile instead of spec file.
3. Put subdirs and about targets into one build target.
firstaidkit.spec:
1. Erase the about creation from here.
2. Erase the fedora 7 specific stuff.
3. Call make build.
4. xserver plugin does not need rhpl nor rhpxl anymore.
5. Actually include the COPYING file where the about says it is.
configuration.py:
1. Change the default backup dir from /tmp/fakbackup to /tmp.
/tmp/fakbackup caused some file permission strangeness when
a non root user executed fak after root had executed it. This
can still occur, but it will be left like this as the user
should not execute fak in non root anyway.
logging:
plugins.py,interpreter.py. __init__.py
1. Always use the reporting object when possible.
2. Add time stamp and level of message to log messages.
|
|
|
|
|
|
|
|
|
|
| |
- The "_p" is not needed. Avoiding the suffix makes the names simpler.
- When the plugin needs to be separated into varios subplugins,
use the _ to signify that a subplugin is related to a father
plugin. Like rpm_lowlevel, this say that lowlevel is part of
the rpm plugin.
- When naming a plugin keep the name SHORT and simple.
- Be sure to name all the plugin packages as "plugin-name"
|
|
|
|
|
|
|
|
|
|
|
| |
- The file names are the ones the the user will be using to reference
each plugin. Having a long name will not help the user.
- Also, to signify that they are plugins we will use the "p_" at the
beginning of each name.
- plugin_examples is left like that because it is not a plugin in
itself, but a directory that contains plugins.
Please follow these naming standards when you name you plugins.
|
|
|
|
|
|
|
| |
- Put the previous xorg config file in a backup file where
the user can see it.
- Give the user extra information about how to create an
xorg configuration file.
|
| |
|
|
|
|
|
| |
We should really implement a backup object that know who is calling and
sets the unique id.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When deviding a string into two lines one must use pythons automatic
string concatenation (python concatenates strings that are in different
line but are inside parenthesis). Do not use the "\" in the string as
this will cause strange and unwanted output.
Yes:
print("long string"
"rest of string")
No:
print("long string \
rest of string")
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Indendtation should be 4 spaces. There was a function indented with
8 spaces.
- Lines should be shorted than 80 chars. It just looks pretty :)
Think of terminals whith only 80 char of length. Think of debuging
in rescue mode.
- Change also the print statements. Just getting ready for python 3000.
- Get some spaces between elifs
- There should not be any lines ending in spaces.
- This can all be read in the python code conventions
http://www.python.org/dev/peps/pep-0008/
|
| |
|
|
|
|
| |
plugin)
|
| |
|
|
|
|
| |
Must have a origin and level.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
The new variable name better expresses the objective of the issue state.
This will help avoid confusion for the plugin developer.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 810d6bd770533a8504a64983a4d7e2db406595df
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Tue Mar 18 14:45:50 2008 +0100
fix some dependancy issues
commit f4bc1ffdb49fadc9fb3de735e06729a40e7641ac
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Tue Mar 18 14:42:20 2008 +0100
Include the utils package
commit afaaf4dadbe0fb8137576059c3da1cdf62a318e8
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Tue Mar 18 14:27:33 2008 +0100
Fix license in setup.py
commit 25442d8c09941126fde5b5d71d5287d0814d712f
Author: Joel Andres Granados <jgranado@redhat.com>
Date: Tue Mar 18 14:00:46 2008 +0100
Create the rpm subpackage for the xserver plugin
|
|
|