| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Marks all methods containing mostly gtk calls as gtk_thread_wait
or gtk_thread_nowait
- Uses gtk_call_once instead of GLib.idle_add to make sure the
method is called only once (returns False)
- Removes some code from the threading locks, because it wasn´t
touching Gtk at all
This change was discussed in the mailinglist here:
https://www.redhat.com/archives/anaconda-devel-list/2012-October/msg00030.html
The main point was:
According to the Gtk team, the gdk_threads_enter/leave pair should
not be used at all (and they have apparently discouraged usage of
it since early releases of Gtk2). Moreover in the current Gdk docs
(http://developer.gnome.org/gdk3/stable/gdk3-Threads.html)
those functions are now marked as deprecated.
The preferred way (and now the only way) is to use g_idle_add
(GLib.idle_add) with a callback method to schedule GUI changes.
The callback method will then get called by the Gtk main loop so
no locking is needed (and GLib.idle_add performs none). But that
is also the reason why everything Gtk related must be done from
the mainloop thread either directly or via idle_add.
|
|
|
|
| |
exception handler be called by Gtk only once
|
|
|
|
|
|
| |
When replacing the last layout in the list, user may mark the same
layout (among the others) for adding. In such cases we shouldn't
remove the layout from the list and just leave it where it was.
|
|
|
|
|
| |
There's no need for these to be editable, and setting this off also helps a
little with the packing.
|
| |
|
| |
|
|
|
|
|
|
| |
You've already bought into doing something destructive, so why not have the
chance to really tear things up? Also, make the cancel button the default
action.
|
|
|
|
|
| |
Most of this patch is just un-indenting stuff. The rest is replacing references
to currentPage with references to selector._root. Same data, really.
|
|
|
|
|
|
|
|
|
| |
First, it simply does not work right now. Secondly, it's not at all obvious
in the UI how you would go about doing this. Click on the expander and then
hit remove? Yes, but then the expander collapses and you still have a
mountpoint displayed on the right. Which thing are you deleting then?
We need a way to do this, but I don't think this code is it.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Without this change we were automatically selecting the first
environment from the list, and adding it to the existing package data.
This means no matter what you had in %packages you also got the GNOME
environment. Obviously this is wrong, so we don't autoselect if we're
doing an automated install and have package data.
|
|
|
|
|
|
| |
This brings it up to feature parity with the gui spoke, mostly. Still
don't have a way to completely disable the password here, but that's a
good thing for now.
|
|
|
|
|
|
| |
Errors bring returned is a simple mismatch or invalid chars, which we
can't allow. Raised items are actual quality issues which the user
could use anyway.
|
|
|
|
|
| |
This will only help if the disks and/or their free regions are very
small.
|
|
|
|
|
|
| |
They won't show up in /etc/fstab and they don't have mountpoints, so
it really doesn't matter if they exist or not. We want to include
them in the new root regardless.
|
|
|
|
|
| |
It already gets called from _do_refresh and multiple calls to
save_right_side are both wasteful and potentially dangerous.
|
| |
|
| |
|
|
|
|
|
|
| |
The parted list should be pretty much in sync, but this way saves
some trouble with resolving the parted partition paths to devices
in the devicetree.
|
|
|
|
|
| |
This also uses Storage.recursiveRemove to remove dependent devices
before trying to remove the partition.
|
| |
|
|
|
|
|
| |
This is used to prevent combinations of features that do not
reduce to a valid raid level.
|
| |
|
| |
|
|
|
|
|
|
| |
If we are given invalid X layouts (not supported), we have to remove them
from the list. If none are left in the list, we should act like if there
was none specified at all and add our defaults.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to set VConsole keymap and X layouts separately. We may
get them all from kickstart, but if not, we have to convert the
given one to the missing one and save the configuration. If X11
configuration is written before the server is started, it is
loaded. This way we can get rid of using XklWrapper in main anaconda
script.
Also we need to write one more configuration file. And it's better
to try to write all configuration files ignoring errors and in case
some error(s) appeared, raise exception at the end of the procedure.
Resolves: rhbz#853877
Resolves: rhbz#856362
Resolves: rhbz#859867
|
| |
|
|
|
|
|
|
|
|
| |
With the addition of Cinnamon and MATE and some others, there's now entirely
too much stuff in the environment window to fit without scrolling. Plus, I
guess smaller screens always needed to scroll. Without a scroll bar, GTK
puts this window in a really bizarre place. See the screenshot attached to
the bug.
|
|
|
|
|
|
| |
Catch some common errors that are not practical to prevent via the
UI and show an error message instead of attempting to carry out the
request.
|
| |
|
|
|
|
|
| |
Resolves: rhbz#862667
Resolves: rhbz#960994
|
|
|
|
|
|
|
|
| |
BTRFS and RAID are not always in the device type combo, so we
can't count on using direct index access to the combo.
Resolves: rhbz#862667
Resolves: rhbz#860994
|
|
|
|
|
|
| |
This likely hits every single kickstart install. Because we run execute
over and over again, we're eventually going to hit a situation where
storage just breaks.
|
|
|
|
|
|
| |
Now that we're storing full languages in the store again (thanks to the
mangling crud from earlier), that's what needs to get expanded when we are
comparing the language setting from the command line or kickstart.
|
| |
|
| |
|
|
|
|
|
|
| |
First, don't always put a cancel button on. That looks weird on the storage
spoke where we don't mention cancel. Second, change the order such that the
Quit or Cancel button comes left-most and is positioned secondarily.
|
|
|
|
|
| |
Otherwise, the resize dialog is going to be referencing devices that are hidden
in the devicetree, which makes them basically not exist.
|
|
|
|
| |
Otherwise, the resize dialog is going to be passed incorrect references.
|
|
|
|
|
|
| |
Give up on getting cute with payload data to set required or not, just
always make the user visit it. Also don't default the kickstart data to
locked, that can confuse the UI
|
|
|
|
| |
It needs to be more clear that deleting filesystems is also an option.
|
| |
|
|
|
|
|
| |
Otherwise, you'll end up in a situation where packages the previous and
current environment share will not get installed.
|
|
|
|
|
| |
When the custom checkbox is selected, we need to make sure the software spoke
is ready when deciding whether the Modify button is sensitive or not.
|
|
|
|
|
|
| |
Activating the checkbutton effectively sets the default behavior
of applying encryption to all new block devices, even in the
custom spoke.
|
| |
|
| |
|
| |
|
| |
|