summaryrefslogtreecommitdiffstats
path: root/pyanaconda/ui/gui
Commit message (Collapse)AuthorAgeFilesLines
* Make all Gtk calls from inside of it's main loop (and thread)threadingMartin Sivak2012-10-167-106/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Marks all methods containing mostly gtk calls as gtk_thread_wait or gtk_thread_nowait - Uses gtk_call_once instead of GLib.idle_add to make sure the method is called only once (returns False) - Removes some code from the threading locks, because it wasn´t touching Gtk at all This change was discussed in the mailinglist here: https://www.redhat.com/archives/anaconda-devel-list/2012-October/msg00030.html The main point was: According to the Gtk team, the gdk_threads_enter/leave pair should not be used at all (and they have apparently discouraged usage of it since early releases of Gtk2). Moreover in the current Gdk docs (http://developer.gnome.org/gdk3/stable/gdk3-Threads.html) those functions are now marked as deprecated. The preferred way (and now the only way) is to use g_idle_add (GLib.idle_add) with a callback method to schedule GUI changes. The callback method will then get called by the Gtk main loop so no locking is needed (and GLib.idle_add performs none). But that is also the reason why everything Gtk related must be done from the mainloop thread either directly or via idle_add.
* Remove Gdk thread initialization, introduce new helper functions and make ↵Martin Sivak2012-10-161-7/+60
| | | | exception handler be called by Gtk only once
* Do not remove the layout if it was added back (#865830)Vratislav Podzimek2012-10-161-1/+2
| | | | | | When replacing the last layout in the list, user may mark the same layout (among the others) for adding. In such cases we shouldn't remove the layout from the list and just leave it where it was.
* Remove the entry on the resize dialog's combo boxes.Chris Lumens2012-10-151-0/+1
| | | | | There's no need for these to be editable, and setting this off also helps a little with the packing.
* disks_free -> disks_size (#863647).Chris Lumens2012-10-151-1/+1
|
* Fix a traceback in media check (#865897).Chris Lumens2012-10-151-4/+3
|
* Add support for deleting an entire root via the existing ConfirmDeleteDialog.Chris Lumens2012-10-152-20/+47
| | | | | | You've already bought into doing something destructive, so why not have the chance to really tear things up? Also, make the cancel button the default action.
* Don't traceback when removing a mountpoint with no expanded selector (#862746).Chris Lumens2012-10-151-32/+35
| | | | | Most of this patch is just un-indenting stuff. The rest is replacing references to currentPage with references to selector._root. Same data, really.
* Remove the code for removing an entire Root all at once.Chris Lumens2012-10-151-24/+0
| | | | | | | | | First, it simply does not work right now. Secondly, it's not at all obvious in the UI how you would go about doing this. Click on the expander and then hit remove? Yes, but then the expander collapses and you still have a mountpoint displayed on the right. Which thing are you deleting then? We need a way to do this, but I don't think this code is it.
* Yet more TODO list updates.Chris Lumens2012-10-151-3/+8
|
* Fix configuration of protected wireless connections (#855526)Radek Vykydal2012-10-131-7/+12
|
* Fix graphical kickstart with %packages dataJesse Keating2012-10-121-24/+30
| | | | | | | | Without this change we were automatically selecting the first environment from the list, and adding it to the existing package data. This means no matter what you had in %packages you also got the GNOME environment. Obviously this is wrong, so we don't autoselect if we're doing an automated install and have package data.
* Make use of the validatePassword routine from users.pyJesse Keating2012-10-121-39/+15
| | | | | | Errors bring returned is a simple mismatch or invalid chars, which we can't allow. Raised items are actual quality issues which the user could use anyway.
* Fall back to lvm autopart if the default fails. (#864708)David Lehman2012-10-121-5/+29
| | | | | This will only help if the disks and/or their free regions are very small.
* Special boot devices are handled the same whether they exist or not.David Lehman2012-10-121-7/+4
| | | | | | They won't show up in /etc/fstab and they don't have mountpoints, so it really doesn't matter if they exist or not. We want to include them in the new root regardless.
* Remove some extra calls to show_first_mountpoint.David Lehman2012-10-121-5/+0
| | | | | It already gets called from _do_refresh and multiple calls to save_right_side are both wasteful and potentially dangerous.
* Show the correct raid options for btrfs.David Lehman2012-10-121-1/+5
|
* Support change of raid level in custom spoke.David Lehman2012-10-121-6/+26
|
* Use devicetree as partition list source instead of parted. (#864718)David Lehman2012-10-121-3/+1
| | | | | | The parted list should be pretty much in sync, but this way saves some trouble with resolving the parted partition paths to devices in the devicetree.
* Use Storage convenience methods to schedule reclaim actions.David Lehman2012-10-121-7/+3
| | | | | This also uses Storage.recursiveRemove to remove dependent devices before trying to remove the partition.
* Pass disk list when trying to recover from device type change failure.David Lehman2012-10-121-0/+1
|
* Fill in missing parts of the disabled raid features dict.David Lehman2012-10-121-1/+5
| | | | | This is used to prevent combinations of features that do not reduce to a valid raid level.
* Clear errors when entering or leaving the custom spoke.David Lehman2012-10-121-0/+2
|
* Hook up signal handler for raid feature checkbuttons.David Lehman2012-10-121-0/+9
|
* Check X layouts specified in kickstart for validityVratislav Podzimek2012-10-121-0/+8
| | | | | | If we are given invalid X layouts (not supported), we have to remove them from the list. If none are left in the list, we should act like if there was none specified at all and add our defaults.
* Work with VConsole keymap and X layouts separatelyVratislav Podzimek2012-10-122-7/+7
| | | | | | | | | | | | | | | | | We need to set VConsole keymap and X layouts separately. We may get them all from kickstart, but if not, we have to convert the given one to the missing one and save the configuration. If X11 configuration is written before the server is started, it is loaded. This way we can get rid of using XklWrapper in main anaconda script. Also we need to write one more configuration file. And it's better to try to write all configuration files ignoring errors and in case some error(s) appeared, raise exception at the end of the procedure. Resolves: rhbz#853877 Resolves: rhbz#856362 Resolves: rhbz#859867
* Don't display "None" for NIC vendors and products NM can't identify (#859540)Radek Vykydal2012-10-121-2/+2
|
* The environment window needs a vertical scroll bar (#865066).Chris Lumens2012-10-111-3/+2
| | | | | | | | With the addition of Cinnamon and MATE and some others, there's now entirely too much stuff in the environment window to fit without scrolling. Plus, I guess smaller screens always needed to scroll. Without a scroll bar, GTK puts this window in a really bizarre place. See the screenshot attached to the bug.
* Improve validation of device edit requests.David Lehman2012-10-111-7/+33
| | | | | | Catch some common errors that are not practical to prevent via the UI and show an error message instead of attempting to carry out the request.
* Don't set mountpoints of "(null)" in mountpoint selectors.David Lehman2012-10-111-2/+4
|
* Prevent crash trying to populate raid options on a one-disk system.David Lehman2012-10-111-1/+6
| | | | | Resolves: rhbz#862667 Resolves: rhbz#960994
* Rework type combos and don't offer RAID on one-disk systems.David Lehman2012-10-111-46/+135
| | | | | | | | BTRFS and RAID are not always in the device type combo, so we can't count on using direct index access to the combo. Resolves: rhbz#862667 Resolves: rhbz#860994
* Avoid a loop of storage spoke executions during kickstart (#865048).Chris Lumens2012-10-101-1/+1
| | | | | | This likely hits every single kickstart install. Because we run execute over and over again, we're eventually going to hit a situation where storage just breaks.
* Change language matching on the welcome screen back around.Chris Lumens2012-10-101-1/+1
| | | | | | Now that we're storing full languages in the store again (thanks to the mangling crud from earlier), that's what needs to get expanded when we are comparing the language setting from the command line or kickstart.
* Fix a stupid typo in the disk shopping cart (#864842).Chris Lumens2012-10-101-1/+1
|
* Reorder the buttons and labels on the bottom left of the storage spoke.Chris Lumens2012-10-091-2/+2
|
* Modify the DetailedErrorDialog buttons.Chris Lumens2012-10-094-38/+34
| | | | | | First, don't always put a cancel button on. That looks weird on the storage spoke where we don't mention cancel. Second, change the order such that the Quit or Cancel button comes left-most and is positioned secondarily.
* Sync up hidden/unhidden disks between the UI and storage module (#864180).Chris Lumens2012-10-091-0/+2
| | | | | Otherwise, the resize dialog is going to be referencing devices that are hidden in the devicetree, which makes them basically not exist.
* When handling a storage error, reload self.disks (#862972).Chris Lumens2012-10-091-0/+1
| | | | Otherwise, the resize dialog is going to be passed incorrect references.
* Require root password spoke be visited (#859069)Jesse Keating2012-10-091-8/+4
| | | | | | Give up on getting cute with payload data to set required or not, just always make the user visit it. Also don't default the kickstart data to locked, that can confuse the UI
* Reword the description on the resize dialog (#863577).Chris Lumens2012-10-092-3/+23
| | | | It needs to be more clear that deleting filesystems is also an option.
* Present an error message if no disks are detected (#864093).Chris Lumens2012-10-092-1/+6
|
* When changing environments, don't explicitly exclude groups (#863886).Chris Lumens2012-10-091-2/+8
| | | | | Otherwise, you'll end up in a situation where packages the previous and current environment share will not get installed.
* Fix marking the "Modify Software Selection" button as sensitive in one case.Chris Lumens2012-10-091-1/+2
| | | | | When the custom checkbox is selected, we need to make sure the software spoke is ready when deciding whether the Modify button is sensitive or not.
* Add UI support for encrypted automatic partitioning.David Lehman2012-10-083-1/+48
| | | | | | Activating the checkbutton effectively sets the default behavior of applying encryption to all new block devices, even in the custom spoke.
* Add support to the custom spoke for encrypted block devices.David Lehman2012-10-082-37/+192
|
* Add a page for decrypting existing LUKS devices.David Lehman2012-10-081-1/+131
|
* Add a dialog for collecting a passphrase for newly encrypted devices.David Lehman2012-10-082-0/+410
|
* Add a property that provides a list of all selectors in the accordion.David Lehman2012-10-081-0/+4
|
* s/dev/disk in the disk shopping cart.Chris Lumens2012-10-081-1/+1
|