| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
We can get also
org.freedesktop.DBus.Error.AccessDenied exception
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first pass at setting things up to split storage out into
a separate package.
It replaces the guts of iutil.execWithRedirect and iutil.execWithCapture
with a single backend function, _run_program. The main thing I can think
of that might be cause for complaint is that _run_program does not log
each output line as the external program outputs it, so you get the whole
output buffer at once. Storage gets its own copy of _run_program and
all of the calls in storage use the copy from storage.util.
The reason I moved all of the iutil arch functions into storage is that
they are mostly used in storage and I didn't want there to be two copies
of the whole set.
The rest is removing of unused things and moving of things only used by
storage into storage.
|
|
|
|
| |
Fix of previous patch.
|
| |
|
|
|
|
|
| |
Also removes urlgrabber.grabber.reset_curl_obj() from getDefaultHostname()
where all its job were to cause races occasionally.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The case:
1) Dracut does not use network so it does not write any ifcfg file
(e.g. DVD install)
2) NM creates default auto connection (DHCP) because it can't find
any ifcfg file for a device.
3) Anaconda writes out default ifcfg file (e.g. ifcfg-eth0)
4) When editing a connection in nm-c-e, ifcfg file of edited default
auto connection (Wired connection 1) is created
(ifcfg-Wired_connection_1).
5) If anaconda tweaks any ifcfg file later (setting ONBOOT, NM_CONTROLLED),
it is the ifcfg-eth0.
6) Both ifcfg files are copied to the target system at the end of
installation
Luckily, the ifcfg-Wired_connection_1 seems to be used after installation,
but bug #870922 suggests it might be not so in all cases.
Anyway, we shouldn't create anaconda's ifcfg-ethX default file in this case.
|
|
|
|
|
|
|
|
|
|
| |
Without these lines, the IO blocks everything in python until complete, which
means setting up a bad NFS mount in the source spoke gives you an unresponsive
hub until the NFS timeout hits.
This is only a patch. The better fix would be to use subprocess for mounting
instead of our own C blob. The only reason this C blob exists is because
loader also required it, and no one's found the time to convert this old code.
|
|
|
|
|
|
|
|
| |
Using libnm-glib from a separate thread results in a hang, probably
because libnm-glib has to do some "loops magic" for its internal use
of DBus.
Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
|
|
|
|
|
|
| |
isys.vtActivate is problematic when using tmux, chvt command works
well and we use it so rarely that it should be okay to call an
external command.
|
| |
|
|
|
|
|
| |
It is used only in the text mode and it should be possible to replace
it with calling 'loadkeys' command in the new text mode.
|
|
|
|
|
|
| |
Now that we are running from the media instead of RAM we can
lower our minimum requirements a bit. Tested with a DVD desktop
install in 512M and it worked fine.
|
|
|
|
|
|
|
| |
EVERY LAST REFERENCE TO LOADER MUST BE ELIMINATED RARRRR:
- remove references to loader in analog and makeupdates.
- change the default progname in isys/log.c from loader to anaconda.
- reword comments here and there that refer to loader.
|
| |
|
|
|
|
|
|
| |
A glitch in e2fsprogs-devel header files prevents us from building otherwise.
Related: rhbz#742147
|
|
|
|
|
| |
This is exactly how we used to do it before systemd took over
starting NM for anaconda - commit 4acfadedb038744e6b47af74fe584188f82e44aa.
|
|
|
|
| |
Also remove unused 'warnings' imports.
|
| |
|
|
|
|
|
|
|
| |
NM is started by systemd before anaconda writes out initial ifcfg files
which results in creating of automatic default connections (e.g.
"Wired connection 1"). The settings of auto connections are not persistent
so we are ok just restarting the NM.
|
|
|
|
|
|
|
|
| |
Followup to e24592f036ca1d8d0169d215ef45e333c442dacc, this changes the
[hopefully] last remaining int used to represent the total system memory
to an unsigned long long.
Patch from Anton Blanchard <anton AT samba DOT org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Our code had a limit of 2TB for the memory check. At least one reporter
is trying to install on a system with 3TB of memory and anaconda reports
that he does not have enough memory. The log file reports he has
-1119974932 kB of memory.
Make two changes here. The first is in iutil.py to explicitly use the
long() Python type for memory reporting. The second is in the
totalMemory() function in loadermisc.c, which is the source of error
reported in #704593.
|
|
|
|
|
|
| |
Else mount can get signalled with a SIGPIPE.
Resolves: rhbz#693732
|
|
|
|
|
|
|
|
| |
New minimum for physical memory is 768MB. New minimum memory for us to
not require swap space is 1152MB.
Related: rhbz#696805
Related: rhbz#699770
|
|
|
|
| |
Resolves: rhbz#693614
|
|
|
|
|
|
| |
This reverts commit 6f7ccb89bf9f99f7f0bb4503c9f73a65ce69b841.
HWADDR is required for BOOTPROTO=ibft, and more importantly
ifcfg-rh/NM needs it when activating devices.
|
|
|
|
| |
Related NM bugs: #672282, #604334
|
|
|
|
|
|
| |
Not needed anymore (udev and biosdevname take care of the naming).
Resolves: rhbz#690589
|
|
|
|
|
|
|
|
| |
If remount=True and the volume is already mounted, the mount() function
will bail. We don't want that for remount requests since remount
doesn't change the mount count.
(cherry picked from commit 517e6d45c736cef1d13f58db55d6f58553368990)
|
|
|
|
|
| |
Port from rhel6-branch
Resolves: rhbz#634016
|
|
|
|
|
|
|
|
|
| |
Port from rhel6-branch.
Resolves: rhbz#638131
Sets DEFROUTE=no in ifcfg file. Use case: one NIC used to fetch
packages, another for iSCSI. Using the option we can prevent the latter
to grab default route.
|
|
|
|
|
| |
Port from rhel6-branch
Resolves: rhbz#638131
|
|
|
|
|
|
|
|
|
|
|
| |
There were two kinds of unused but set variables:
- the really pointless ones
- the ones whose only purpose was to silence the warnings
about ignoring the return values from functions declared with
__attribute__((__warn_unused_result__))
Since gcc 4.5 the warnings can be disabled using -Wno-unused-result,
so the variables are no longer necessary.
Then -Wno-unused-but-set-variable is an overkill, so drop it.
|
| |
|
|
|
|
|
| |
Part of the removal never happened in the first place, and part of it got
overwritten when I pushed the install image merging patch series.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the getDevices() function in isys, we check the type of the device
during discovery to see if the type is ARPHRD_ETHER. If it isn't, we
skip that device when gathering network devices. This filters out lo,
sit0, and other devices we don't want in the network device list. But,
it does skip over one ethernet device type that is initialized as
ARPHRD_SLIP on s390.
(This is cherry-picked from rhel6-branch, but since the functionality is
already on master, I just made sure the test is using the ARPHRD_*
constants rather than 1 and 256.)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to being unnecessary, this obfuscation does not account for
the fact that the codes can be combined using a bitwise or.
This is part of the reason we were unable to identify the actual problem
with the series of bugs involving the error "SystemError: (2, None)"
during F11, F12, and perhaps after that.
Related: rhbz#548592
|
|
|
|
|
|
|
| |
Replace uses of mkdirChain() with g_mkdir_with_parents() and
remove the existing mkdirChain() code from isys/imount.*
Added a wrapper function for g_mkdir_with_parents() usage.
|
|
|
|
|
| |
The stubs.h header file does not exist anymore. Replace gunzip_*
macro usage with the real zlib function names.
|
|
|
|
|
|
| |
The only place this code is still used is in loader. Loader is now
using libarchive to unpack cpio streams and zlib to uncompress them, so
we do not need these functions anymore.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
if ((type != 1) && !((type == 256) && !strncmp(name, "ctc", 3)))
#1 #2 #3
type, name 1 !(2&&3) 2 3 Result
1 bob F T F F F skip continue
2 sam T T F F T continue
256 sam T T T F T continue
256 ctc T F T T F skip continue
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Since there is no more install.img, this whole process is pointless and all
its support code can come out.
|
|
|
|
| |
No longer used. mount can now handle loop devices itself.
|
| |
|