| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Marks all methods containing mostly gtk calls as gtk_thread_wait
or gtk_thread_nowait
- Uses gtk_call_once instead of GLib.idle_add to make sure the
method is called only once (returns False)
- Removes some code from the threading locks, because it wasn´t
touching Gtk at all
This change was discussed in the mailinglist here:
https://www.redhat.com/archives/anaconda-devel-list/2012-October/msg00030.html
The main point was:
According to the Gtk team, the gdk_threads_enter/leave pair should
not be used at all (and they have apparently discouraged usage of
it since early releases of Gtk2). Moreover in the current Gdk docs
(http://developer.gnome.org/gdk3/stable/gdk3-Threads.html)
those functions are now marked as deprecated.
The preferred way (and now the only way) is to use g_idle_add
(GLib.idle_add) with a callback method to schedule GUI changes.
The callback method will then get called by the Gtk main loop so
no locking is needed (and GLib.idle_add performs none). But that
is also the reason why everything Gtk related must be done from
the mainloop thread either directly or via idle_add.
|
|
|
|
| |
exception handler be called by Gtk only once
|
| |
|
|
|
|
|
|
| |
When replacing the last layout in the list, user may mark the same
layout (among the others) for adding. In such cases we shouldn't
remove the layout from the list and just leave it where it was.
|
|
|
|
|
| |
Since we add actions to main loop, not releasing lock may lead
to deadlock.
|
|
|
|
|
|
|
|
|
|
|
| |
If we want tboot to keep getting used, we need to configure
new-kernel-pkg to tell grubby to do that. When grubby finds a multiboot
stanza as the default template, it won't use the multiboot parts of the
template unless specifically configured to. This patch adds a
configuration option to tell grubby that we always want to use the tboot
multiboot kernel by default when we add a new kernel.
Signed-off-by: Peter Jones <pjones@redhat.com>
|
| |
|
|
|
|
| |
Resolves: rhbz#747278
|
|
|
|
| |
Related: rhbz#838736
|
| |
|
|
|
|
|
| |
There's no need for these to be editable, and setting this off also helps a
little with the packing.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
You've already bought into doing something destructive, so why not have the
chance to really tear things up? Also, make the cancel button the default
action.
|
|
|
|
|
| |
Most of this patch is just un-indenting stuff. The rest is replacing references
to currentPage with references to selector._root. Same data, really.
|
|
|
|
|
|
|
|
|
| |
First, it simply does not work right now. Secondly, it's not at all obvious
in the UI how you would go about doing this. Click on the expander and then
hit remove? Yes, but then the expander collapses and you still have a
mountpoint displayed on the right. Which thing are you deleting then?
We need a way to do this, but I don't think this code is it.
|
| |
|
|
|
|
|
|
| |
It's possible to end up in a situation where the root is "None Linux None for
None" which just looks silly. This happens in my testing if you kill an
install after it's made partitions, but before fedora-release gets installed.
|
| |
|
|
|
|
|
|
|
|
| |
Without this change we were automatically selecting the first
environment from the list, and adding it to the existing package data.
This means no matter what you had in %packages you also got the GNOME
environment. Obviously this is wrong, so we don't autoselect if we're
doing an automated install and have package data.
|
|
|
|
|
|
| |
This brings it up to feature parity with the gui spoke, mostly. Still
don't have a way to completely disable the password here, but that's a
good thing for now.
|
|
|
|
|
|
| |
Errors bring returned is a simple mismatch or invalid chars, which we
can't allow. Raised items are actual quality issues which the user
could use anyway.
|
|
|
|
|
|
| |
This moves it to a more central spot so that it can be used by both the
gui and the text spoke, or any other thing that wants to validate
passwords.
|
|
|
|
|
|
| |
There may be cases when we don't get exit code. Especially in those
nonstandard cases we should honor the 'nokill' flag and don't reboot
the machine.
|
|
|
|
|
| |
This will only help if the disks and/or their free regions are very
small.
|
|
|
|
|
|
| |
They won't show up in /etc/fstab and they don't have mountpoints, so
it really doesn't matter if they exist or not. We want to include
them in the new root regardless.
|
|
|
|
|
| |
This was only triggered if none of the partitions being allocated
were growable, which has become a very rare case.
|
| |
|
|
|
|
|
| |
There is no guarantee of growth, so be sure to start with a size
that can hold the specified formatting.
|
|
|
|
|
|
|
| |
If we skip accounting for any requests, the set's data will no longer
match the state of its devices. We need to know how much every device
has grown. This bug was leading to severely overgrown sets in some
cases.
|
|
|
|
|
| |
It already gets called from _do_refresh and multiple calls to
save_right_side are both wasteful and potentially dangerous.
|
| |
|
| |
|
|
|
|
|
|
| |
The parted list should be pretty much in sync, but this way saves
some trouble with resolving the parted partition paths to devices
in the devicetree.
|
|
|
|
|
| |
This also uses Storage.recursiveRemove to remove dependent devices
before trying to remove the partition.
|
| |
|
|
|
|
|
| |
This is used to prevent combinations of features that do not
reduce to a valid raid level.
|
| |
|
| |
|
|
|
|
|
| |
ValueError makes exception handling difficult since you can't know
if the error is something expected as opposed to a programming error.
|
| |
|
|
|
|
|
|
| |
If we are given invalid X layouts (not supported), we have to remove them
from the list. If none are left in the list, we should act like if there
was none specified at all and add our defaults.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to set VConsole keymap and X layouts separately. We may
get them all from kickstart, but if not, we have to convert the
given one to the missing one and save the configuration. If X11
configuration is written before the server is started, it is
loaded. This way we can get rid of using XklWrapper in main anaconda
script.
Also we need to write one more configuration file. And it's better
to try to write all configuration files ignoring errors and in case
some error(s) appeared, raise exception at the end of the procedure.
Resolves: rhbz#853877
Resolves: rhbz#856362
Resolves: rhbz#859867
|
| |
|
| |
|
|
|
|
|
| |
We should indicate where does this file come from. Moreover, without this
comment vim doesn't turn on the syntax highlighting automatically.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Wifi connections have separate ifcfg files, not specified by the
device name.
Signed-off-by: Vratislav Podzimek <vpodzime@redhat.com>
|