Remove raid clone option and code (#587036)

Remove the raid clone option from the create-storage menu, and also
remove the underlying code. It is broken, and this has not been noticed
until very recently as no-one uses it. So as discussed on irc it is better
to just remove it, otherwise the next time we accidentally break it,
it will likely once more remain broken for a long time.

This also "fixes" RHEL-6 bug 589957.

1 files changed, 1 insertions, 34 deletions

diff --git a/iw/partition_gui.py b/iw/partition_gui.py
index 7ce4df2ea..9496e4eac 100644
--- a/iw/partition_gui.py
+++ b/iw/partition_gui.py
@@ -1335,18 +1335,11 @@ class PartitionWindow(InstallWindow):
                 and availraidparts > 1):
             activate_create_raid_dev = True
 
-        # FIXME: Why do I need availraidparts to clone?
-        activate_create_raid_clone = False
-        if (len(self.storage.partitioned) > 1
-                and availraidparts > 0):
-            activate_create_raid_clone = True
-
         # Must check if all the possibilities are False.  In this case tell the
         # user that he can't create anything and the reasons.
         if (not activate_create_partition
                 and not activate_create_vg
-                and not activate_create_raid_dev
-                and not activate_create_raid_clone):
+                and not activate_create_raid_dev):
             self.intf.messageWindow(_("Cannot perform any creation action"),
                         _("Note that the creation action requires one of the "
                         "following:\n\n"
@@ -1433,12 +1426,6 @@ class PartitionWindow(InstallWindow):
         if activate_create_raid_dev:
             rd_rb.set_sensitive(True)
 
-        # Activate RAID clone if needed.
-        # rc_rb -> RAID clone
-        rc_rb = create_storage_xml.get_widget("create_storage_rb_raid_clone")
-        if activate_create_raid_clone:
-            rc_rb.set_sensitive(True)
-
         # Before drawing lets select the first radio button that is sensitive:
         # How can I get sensitivity from gtk.radiobutton?
         if activate_create_partition:
@@ -1450,9 +1437,6 @@ class PartitionWindow(InstallWindow):
         elif activate_create_raid_dev:
             rd_rb.set_active(True)
             rd_rb.grab_focus()
-        elif activate_create_raid_clone:
-            rc_rb.set_active(True)
-            rc_rb.grab_focus()
 
         gui.addFrame(self.dialog)
         self.dialog.show_all()
@@ -1525,23 +1509,6 @@ class PartitionWindow(InstallWindow):
             self.editPartition(member, isNew = True, restrictfs=["mdmember"])
             return
 
-        elif rc_rb.get_active():
-            # r_d_g -> raid_dialog_gui
-            cloneDialog = r_d_g.RaidCloneDialog(self.storage, self.intf,
-                    self.parent)
-            if cloneDialog is None:
-                self.intf.messageWindow(_("Couldn't Create Drive Clone Editor"),
-                                        _("The drive clone editor could not "
-                                          "be created for some reason."),
-                                        custom_icon="error")
-                return
-
-            if cloneDialog.run():
-                self.refresh()
-
-            cloneDialog.destroy()
-            return
-
         elif rd_rb.get_active():
             array = self.storage.newMDArray(fmt_type=self.storage.defaultFSType)
             self.editRaidArray(array, isNew = True)