/* MiddleWare.cpp Copyright (C) 2009 Zdenek Prikryl (zprikryl@redhat.com) Copyright (C) 2009 RedHat inc. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "abrtlib.h" #include "Daemon.h" #include "Settings.h" #include "abrt_exception.h" #include "comm_layer_inner.h" #include "CommLayerServer.h" #include "MiddleWare.h" using namespace std; /** * An instance of CPluginManager. When MiddleWare wants to do something * with plugins, it calls the plugin manager. * @see PluginManager.h */ CPluginManager* g_pPluginManager; /** * Get one crash info. If getting is successful, * then crash info is filled. * @param dump_dir_name A dump dir containing all necessary data. * @param pCrashData A crash info. * @return It return results of operation. See mw_result_t. */ static mw_result_t FillCrashInfo(const char *crash_id, map_crash_data_t& pCrashData); /** * Transforms a debugdump directory to inner crash * report form. This form is used for later reporting. * @param dump_dir_name A debugdump dir containing all necessary data. * @param pCrashData A created crash report. */ static bool DebugDumpToCrashReport(const char *dump_dir_name, map_crash_data_t& pCrashData) { VERB3 log(" DebugDumpToCrashReport('%s')", dump_dir_name); struct dump_dir *dd = dd_opendir(dump_dir_name, /*flags:*/ 0); if (!dd) return false; const char *const *v = must_have_files; while (*v) { if (!dd_exist(dd, *v)) { dd_close(dd); log("Important file '%s/%s' is missing", dump_dir_name, *v); return false; } v++; } load_crash_data_from_debug_dump(dd, pCrashData); char *events = list_possible_events(dd, NULL, ""); dd_close(dd); add_to_crash_data_ext(pCrashData, CD_EVENTS, CD_SYS, CD_ISNOTEDITABLE, events); free(events); return true; } static char *do_log_and_update_client(char *log_line, void *param) { VERB1 log("%s", log_line); update_client("%s", log_line); return log_line; } /* * Called in two cases: * (1) by StartJob dbus call -> CreateReportThread(), in the thread * (2) by CreateReport dbus call */ mw_result_t CreateCrashReport(const char *crash_id, long caller_uid, int force, map_crash_data_t& pCrashData) { VERB2 log("CreateCrashReport('%s',%ld,result)", crash_id, caller_uid); CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); struct db_row *row = database->GetRow(crash_id); database->DisConnect(); if (!row) { error_msg("crash '%s' is not in database", crash_id); return MW_IN_DB_ERROR; } mw_result_t r = MW_OK; if (caller_uid != 0 /* not called by root */ && row->db_inform_all[0] != '1' ) { char caller_uid_str[sizeof(long) * 3 + 2]; sprintf(caller_uid_str, "%ld", caller_uid); if (strcmp(caller_uid_str, row->db_uid) != 0) { error_msg("crash '%s' can't be accessed by user with uid %ld", crash_id, caller_uid); r = MW_IN_DB_ERROR; goto ret; } } try { struct run_event_state *run_state = new_run_event_state(); run_state->logging_callback = do_log_and_update_client; int res = run_event(run_state, row->db_dump_dir, force ? "reanalyze" : "analyze"); free_run_event_state(run_state); if (res != 0 && res != -1) /* -1 is "nothing was done", here it is ok */ { r = MW_PLUGIN_ERROR; goto ret; } /* Do a load_crash_data_from_debug_dump from (possibly updated) * crash dump dir */ if (!DebugDumpToCrashReport(row->db_dump_dir, pCrashData)) { error_msg("Error loading crash data"); r = MW_ERROR; goto ret; } } catch (CABRTException& e) { r = MW_CORRUPTED; error_msg("%s", e.what()); if (e.type() == EXCEP_PLUGIN) { r = MW_PLUGIN_ERROR; } } ret: db_row_free(row); VERB3 log("CreateCrashReport() returns %d", r); return r; } void RunAction(const char *pActionDir, const char *pPluginName, const char *pPluginArgs) { CAction* action = g_pPluginManager->GetAction(pPluginName); if (!action) { /* GetAction() already complained */ return; } try { action->Run(pActionDir, pPluginArgs, /*force:*/ 0); } catch (CABRTException& e) { error_msg("Execution of '%s' was not successful: %s", pPluginName, e.what()); } } struct logging_state { char *last_line; }; static char *do_log_and_save_line(char *log_line, void *param) { struct logging_state *l_state = (struct logging_state *)param; VERB1 log("%s", log_line); update_client("%s", log_line); free(l_state->last_line); l_state->last_line = log_line; return NULL; } // Do not trust client_report here! // dbus handler passes it from user without checking report_status_t Report(const map_crash_data_t& client_report, const vector_string_t& events, const map_map_string_t& settings, long caller_uid) { // Get ID fields const char *UID = get_crash_data_item_content_or_NULL(client_report, CD_UID); const char *UUID = get_crash_data_item_content_or_NULL(client_report, CD_UUID); if (!UID || !UUID) { throw CABRTException(EXCEP_ERROR, "Report(): UID or UUID is missing in client's report data"); } string crash_id = ssprintf("%s:%s", UID, UUID); // Retrieve corresponding stored record map_crash_data_t stored_report; mw_result_t r = FillCrashInfo(crash_id.c_str(), stored_report); if (r != MW_OK) { return report_status_t(); } // Is it allowed for this user to report? if (caller_uid != 0 // not called by root && get_crash_data_item_content(stored_report, CD_INFORMALL) != "1" && strcmp(to_string(caller_uid).c_str(), UID) != 0 ) { throw CABRTException(EXCEP_ERROR, "Report(): user with uid %ld can't report crash %s", caller_uid, crash_id.c_str()); } const char *dump_dir_name = get_crash_data_item_content_or_NULL(stored_report, CD_DUMPDIR); // Save comment, "how to reproduce", backtrace //TODO: we should iterate through stored_report and modify all //modifiable fields which have new data in client_report const char *comment = get_crash_data_item_content_or_NULL(client_report, FILENAME_COMMENT); const char *reproduce = get_crash_data_item_content_or_NULL(client_report, FILENAME_REPRODUCE); const char *backtrace = get_crash_data_item_content_or_NULL(client_report, FILENAME_BACKTRACE); if (comment || reproduce || backtrace) { struct dump_dir *dd = dd_opendir(dump_dir_name, /*flags:*/ 0); if (dd) { if (comment) { dd_save_text(dd, FILENAME_COMMENT, comment); add_to_crash_data_ext(stored_report, FILENAME_COMMENT, CD_TXT, CD_ISEDITABLE, comment); } if (reproduce) { dd_save_text(dd, FILENAME_REPRODUCE, reproduce); add_to_crash_data_ext(stored_report, FILENAME_REPRODUCE, CD_TXT, CD_ISEDITABLE, reproduce); } if (backtrace) { dd_save_text(dd, FILENAME_BACKTRACE, backtrace); add_to_crash_data_ext(stored_report, FILENAME_BACKTRACE, CD_TXT, CD_ISEDITABLE, backtrace); } dd_close(dd); } } /* Remove BIN filenames from stored_report if they are not present in client's data */ map_crash_data_t::const_iterator its = stored_report.begin(); while (its != stored_report.end()) { if (its->second[CD_TYPE] == CD_BIN) { std::string key = its->first; if (get_crash_data_item_content_or_NULL(client_report, key.c_str()) == NULL) { /* client does not have it -> does not want it passed to events */ VERB3 log("Won't report BIN file %s:'%s'", key.c_str(), its->second[CD_CONTENT].c_str()); its++; /* move off the element we will erase */ stored_report.erase(key); continue; } } its++; } VERB3 { log_map_crash_data(client_report, " client_report"); log_map_crash_data(stored_report, " stored_report"); } #define client_report client_report_must_not_be_used_below // Export overridden settings as environment variables GList *env_list = NULL; map_map_string_t::const_iterator reporter_settings = settings.begin(); while (reporter_settings != settings.end()) { map_string_t::const_iterator var = reporter_settings->second.begin(); while (var != reporter_settings->second.end()) { char *s = xasprintf("%s_%s=%s", reporter_settings->first.c_str(), var->first.c_str(), var->second.c_str()); VERB3 log("Exporting '%s'", s); putenv(s); env_list = g_list_append(env_list, s); var++; } reporter_settings++; } // Run events bool at_least_one_reporter_succeeded = false; report_status_t ret; std::string message; struct logging_state l_state; struct run_event_state *run_state = new_run_event_state(); run_state->logging_callback = do_log_and_save_line; run_state->logging_param = &l_state; for (unsigned i = 0; i < events.size(); i++) { std::string event = events[i]; l_state.last_line = NULL; int r = run_event(run_state, dump_dir_name, event.c_str()); if (r == -1) { l_state.last_line = xasprintf("Error: no processing is specified for event '%s'", event.c_str()); } if (r == 0) { at_least_one_reporter_succeeded = true; ret[event].push_back("1"); // REPORT_STATUS_IDX_FLAG ret[event].push_back(l_state.last_line ? : "Reporting succeeded"); // REPORT_STATUS_IDX_MSG if (message != "") message += ";"; message += (l_state.last_line ? : "Reporting succeeded"); } else { ret[event].push_back("0"); // REPORT_STATUS_IDX_FLAG ret[event].push_back(l_state.last_line ? : "Error in reporting"); // REPORT_STATUS_IDX_MSG update_client("Reporting via '%s' was not successful%s%s", event.c_str(), l_state.last_line ? ": " : "", l_state.last_line ? l_state.last_line : "" ); } free(l_state.last_line); } free_run_event_state(run_state); // Unexport overridden settings for (GList *li = env_list; li; li = g_list_next(li)) { char *s = (char*)li->data; /* Need to make a copy: just cutting s at '=' and unsetenv'ing * the result would be a bug! s _itself_ is in environment now, * we must not modify it there! */ char *name = xstrndup(s, strchrnul(s, '=') - s); VERB3 log("Unexporting '%s'", name); unsetenv(name); free(name); free(s); } g_list_free(env_list); // Save reporting results to database if (at_least_one_reporter_succeeded) { CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); report_status_t::iterator ret_it = ret.begin(); while (ret_it != ret.end()) { const string &event = ret_it->first; const vector_string_t &v = ret_it->second; if (v[REPORT_STATUS_IDX_FLAG] == "1") { database->SetReportedPerReporter(crash_id.c_str(), event.c_str(), v[REPORT_STATUS_IDX_MSG].c_str()); } ret_it++; } database->SetReported(crash_id.c_str(), message.c_str()); database->DisConnect(); } return ret; #undef client_report } /** * Check whether particular debugdump directory is saved in database. * @param debug_dump_dir * A debugdump dir containing all necessary data. * @return * It returns true if debugdump dir is already saved, otherwise * it returns false. */ static bool is_debug_dump_saved(const char *debug_dump_dir) { CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); struct db_row *row = database->GetRow_by_dir(debug_dump_dir); database->DisConnect(); db_row_free(row); return row != NULL; } /** * Save a debugdump into database. If saving is * successful, then crash info is filled. Otherwise the crash info is * not changed. * @param pUUID A local UUID of a crash. * @param pUID An UID of an user. * @param pTime Time when a crash occurs. * @param pDebugDumpPath A debugdump path. * @param pCrashData A filled crash info. * @return It return results of operation. See mw_result_t. */ static mw_result_t SaveDebugDumpToDatabase(const char *crash_id, bool inform_all_users, const char *pTime, const char *pDebugDumpDir, map_crash_data_t& pCrashData) { CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); /* note: if [UUID,UID] record exists, pDebugDumpDir is not updated in the record */ database->Insert_or_Update(crash_id, inform_all_users, pDebugDumpDir, pTime); struct db_row *row = database->GetRow(crash_id); database->DisConnect(); mw_result_t res = FillCrashInfo(crash_id, pCrashData); if (res == MW_OK) { const char *first = get_crash_data_item_content(pCrashData, CD_DUMPDIR).c_str(); if (row && row->db_reported[0] == '1') { log("Crash is in database already (dup of %s) and is reported", first); db_row_free(row); return MW_REPORTED; } if (row && xatou(row->db_count) > 1) { db_row_free(row); log("Crash is in database already (dup of %s)", first); return MW_OCCURRED; } } db_row_free(row); return res; } /* We need to share some data between SaveDebugDump and is_crash_id_in_db: */ struct cdump_state { char *uid; /* filled by SaveDebugDump */ char *crash_id; /* filled by is_crash_id_in_db */ int crash_id_is_in_db; /* filled by is_crash_id_in_db */ }; static int is_crash_id_in_db(const char *dump_dir_name, void *param) { struct cdump_state *state = (struct cdump_state *)param; if (state->crash_id) return 0; /* we already checked it, don't do it again */ struct dump_dir *dd = dd_opendir(dump_dir_name, /*flags:*/ 0); if (!dd) return 0; /* wtf? (error, but will be handled elsewhere later) */ char *uuid = dd_load_text_ext(dd, CD_UUID, DD_FAIL_QUIETLY + DD_LOAD_TEXT_RETURN_NULL_ON_FAILURE ); dd_close(dd); if (!uuid) { return 0; /* no uuid (yet), "run_event, please continue iterating" */ } state->crash_id = xasprintf("%s:%s", state->uid, uuid); free(uuid); CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); struct db_row *row = database->GetRow(state->crash_id); database->DisConnect(); if (!row) /* Crash id is not in db - this crash wasn't seen before */ return 0; /* "run_event, please continue iterating" */ /* Crash id is in db */ db_row_free(row); state->crash_id_is_in_db = 1; /* "run_event, please stop iterating": */ return 1; } static char *do_log(char *log_line, void *param) { VERB1 log("%s", log_line); //update_client("%s", log_line); return log_line; } mw_result_t SaveDebugDump(const char *dump_dir_name, map_crash_data_t& pCrashData) { mw_result_t res; if (is_debug_dump_saved(dump_dir_name)) return MW_IN_DB; struct dump_dir *dd = dd_opendir(dump_dir_name, /*flags:*/ 0); if (!dd) return MW_ERROR; struct cdump_state state = { NULL, NULL, false }; /* uid, crash_id, crash_id_is_in_db */ state.uid = dd_load_text(dd, CD_UID); char *time = dd_load_text(dd, FILENAME_TIME); char *analyzer = dd_load_text(dd, FILENAME_ANALYZER); dd_close(dd); res = MW_ERROR; struct run_event_state *run_state = new_run_event_state(); run_state->post_run_callback = is_crash_id_in_db; run_state->post_run_param = &state; run_state->logging_callback = do_log; int r = run_event(run_state, dump_dir_name, "post-create"); free_run_event_state(run_state); /* Is crash id in db? (In this case, is_crash_id_in_db() should have * aborted "post-create" event processing as soon as it saw uuid * such that uid:uuid (=crash_id) is in database, and set * the state.crash_id_is_in_db flag) */ if (!state.crash_id_is_in_db) { /* No. Was there error on one of processing steps in run_event? */ if (r != 0) goto ret; /* yes */ /* Was uuid created after all? (In this case, is_crash_id_in_db() * should have fetched it and created state.crash_id) */ if (!state.crash_id) { /* no */ log("Dump directory '%s' has no UUID element", dump_dir_name); goto ret; } } /* Loads pCrashData (from the *first debugdump dir* if this one is a dup) * Returns: * MW_REPORTED: "the crash is flagged as reported in DB" (which also means it's a dup) * MW_OCCURRED: "crash count is != 1" (iow: it is > 1 - dup) * MW_OK: "crash count is 1" (iow: this is a new crash, not a dup) * else: an error code */ res = SaveDebugDumpToDatabase(state.crash_id, true, /*analyzer_has_InformAllUsers(analyzer),*/ time, dump_dir_name, pCrashData); ret: free(state.crash_id); free(state.uid); free(time); free(analyzer); return res; } static mw_result_t FillCrashInfo(const char *crash_id, map_crash_data_t& pCrashData) { CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); struct db_row *row = database->GetRow(crash_id); database->DisConnect(); if (!row) return MW_ERROR; struct dump_dir *dd = dd_opendir(row->db_dump_dir, /*flags:*/ 0); if (!dd) { db_row_free(row); return MW_ERROR; } load_crash_data_from_debug_dump(dd, pCrashData); char *events = list_possible_events(dd, NULL, ""); dd_close(dd); add_to_crash_data_ext(pCrashData, CD_EVENTS, CD_SYS, CD_ISNOTEDITABLE, events); free(events); //TODO: we _never_ use CD_SYS, perhaps we should use it here? add_to_crash_data(pCrashData, CD_UID , row->db_uid ); add_to_crash_data(pCrashData, CD_UUID , row->db_uuid ); add_to_crash_data(pCrashData, CD_INFORMALL , row->db_inform_all ); add_to_crash_data(pCrashData, CD_COUNT , row->db_count ); add_to_crash_data(pCrashData, CD_REPORTED , row->db_reported ); add_to_crash_data(pCrashData, CD_MESSAGE , row->db_message ); add_to_crash_data(pCrashData, CD_DUMPDIR , row->db_dump_dir ); add_to_crash_data(pCrashData, FILENAME_TIME , row->db_time ); db_row_free(row); return MW_OK; } static void GetUUIDsOfCrash(long caller_uid, vector_string_t &result) { CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); GList *rows = database->GetUIDData(caller_uid); database->DisConnect(); for (GList *li = rows; li != NULL; li = g_list_next(li)) { struct db_row *row = (struct db_row*)li->data; string crash_id = ssprintf("%s:%s", row->db_uid, row->db_uuid); result.push_back(crash_id); } // TODO: return GList db_list_free(rows); } vector_map_crash_data_t GetCrashInfos(long caller_uid) { vector_map_crash_data_t retval; log("Getting crash infos..."); try { vector_string_t crash_ids; //TODO: it looks strange that we select UUIDs //olny in order to find which directories to read! //Should we simply retrieve list of *directories*, not *uuids*? GetUUIDsOfCrash(caller_uid, crash_ids); unsigned int ii; for (ii = 0; ii < crash_ids.size(); ii++) { const char *crash_id = crash_ids[ii].c_str(); map_crash_data_t info; mw_result_t res = FillCrashInfo(crash_id, info); switch (res) { case MW_OK: retval.push_back(info); break; case MW_ERROR: error_msg("Dump directory for crash_id %s doesn't exist or misses crucial files, deleting", crash_id); /* Deletes both DB record and dump dir */ DeleteDebugDump(crash_id, /*caller_uid:*/ 0); break; default: break; } } } catch (CABRTException& e) { error_msg("%s", e.what()); } return retval; } /* * Called in two cases: * (1) by StartJob dbus call -> CreateReportThread(), in the thread * (2) by CreateReport dbus call * In the second case, it finishes quickly, because previous * StartJob dbus call already did all the processing, and we just retrieve * the result from dump directory, which is fast. */ void CreateReport(const char* crash_id, long caller_uid, int force, map_crash_data_t& crashReport) { /* FIXME: starting from here, any shared data must be protected with a mutex. * For example, CreateCrashReport does: * g_pPluginManager->GetDatabase(g_settings_sDatabase); * which is unsafe wrt concurrent updates to g_pPluginManager state. */ mw_result_t res = CreateCrashReport(crash_id, caller_uid, force, crashReport); switch (res) { case MW_OK: VERB2 log_map_crash_data(crashReport, "crashReport"); break; case MW_IN_DB_ERROR: error_msg("Can't find crash with id %s in database", crash_id); break; case MW_PLUGIN_ERROR: error_msg("Particular analyzer plugin isn't loaded or there is an error within plugin(s)"); break; default: error_msg("Corrupted crash with id %s, deleting", crash_id); DeleteDebugDump(crash_id, /*caller_uid:*/ 0); break; } } typedef struct thread_data_t { pthread_t thread_id; long caller_uid; int force; char* crash_id; char* peer; } thread_data_t; static void* create_report(void* arg) { thread_data_t *thread_data = (thread_data_t *) arg; /* Client name is per-thread, need to set it */ set_client_name(thread_data->peer); try { log("Creating report..."); map_crash_data_t crashReport; CreateReport(thread_data->crash_id, thread_data->caller_uid, thread_data->force, crashReport); g_pCommLayer->JobDone(thread_data->peer); } catch (CABRTException& e) { error_msg("%s", e.what()); } catch (...) {} set_client_name(NULL); /* free strduped strings */ free(thread_data->crash_id); free(thread_data->peer); free(thread_data); /* Bogus value. pthreads require us to return void* */ return NULL; } int CreateReportThread(const char* crash_id, long caller_uid, int force, const char* pSender) { thread_data_t *thread_data = (thread_data_t *)xzalloc(sizeof(thread_data_t)); thread_data->crash_id = xstrdup(crash_id); thread_data->caller_uid = caller_uid; thread_data->force = force; thread_data->peer = xstrdup(pSender); pthread_attr_t attr; pthread_attr_init(&attr); pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED); int r = pthread_create(&thread_data->thread_id, &attr, create_report, thread_data); pthread_attr_destroy(&attr); if (r != 0) { free(thread_data->crash_id); free(thread_data->peer); free(thread_data); /* The only reason this may happen is system-wide resource starvation, * or ulimit is exceeded (someone floods us with CreateReport() dbus calls?) */ error_msg("Can't create thread"); return r; } VERB3 log("Thread %llx created", (unsigned long long)thread_data->thread_id); return r; } /* Remove dump dir and its DB record */ int DeleteDebugDump(const char *crash_id, long caller_uid) { try { CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); struct db_row *row = database->GetRow(crash_id); if (!row) { database->DisConnect(); return ENOENT; } char caller_uid_str[sizeof(long) * 3 + 2]; sprintf(caller_uid_str, "%li", caller_uid); if (caller_uid != 0 /* not called by root */ && row->db_inform_all[0] != '1' && strcmp(caller_uid_str, row->db_uid) != 0 ) { database->DisConnect(); db_row_free(row); return EPERM; } database->DeleteRow(crash_id); database->DisConnect(); if (row->db_dump_dir[0] != '\0') { delete_debug_dump_dir(row->db_dump_dir); db_row_free(row); return 0; /* success */ } db_row_free(row); } catch (CABRTException& e) { error_msg("%s", e.what()); } return EIO; /* generic failure code */ } void DeleteDebugDump_by_dir(const char *dump_dir) { try { CDatabase* database = g_pPluginManager->GetDatabase(g_settings_sDatabase); database->Connect(); database->DeleteRows_by_dir(dump_dir); database->DisConnect(); delete_debug_dump_dir(dump_dir); } catch (CABRTException& e) { error_msg("%s", e.what()); } } void GetPluginsInfo(map_map_string_t &map_of_plugin_info) { DIR *dir = opendir(PLUGINS_CONF_DIR); if (!dir) return; struct dirent *dent; while ((dent = readdir(dir)) != NULL) { if (!is_regular_file(dent, PLUGINS_CONF_DIR)) continue; char *ext = strrchr(dent->d_name, '.'); if (!ext || strcmp(ext + 1, PLUGINS_CONF_EXTENSION) != 0) continue; VERB3 log("Found %s", dent->d_name); *ext = '\0'; char *glade_file = xasprintf(PLUGINS_LIB_DIR"/%s.glade", dent->d_name); if (access(glade_file, F_OK) == 0) { *ext = '.'; char *conf_file = concat_path_file(PLUGINS_CONF_DIR, dent->d_name); *ext = '\0'; FILE *fp = fopen(conf_file, "r"); free(conf_file); char *descr = NULL; if (fp) { descr = xmalloc_fgetline(fp); fclose(fp); if (descr && strncmp("# Description:", descr, strlen("# Description:")) == 0) overlapping_strcpy(descr, skip_whitespace(descr + strlen("# Description:"))); else { free(descr); descr = NULL; } } map_string_t plugin_info; plugin_info["Name"] = dent->d_name; plugin_info["Enabled"] = "yes"; plugin_info["Type"] = "Reporter"; //was: plugin_type_str[module->GetType()]; field to be removed plugin_info["Version"] = VERSION; //was: module->GetVersion(); field to be removed? plugin_info["Description"] = descr ? descr : ""; //was: module->GetDescription(); plugin_info["Email"] = ""; //was: module->GetEmail(); field to be removed plugin_info["WWW"] = ""; //was: module->GetWWW(); field to be removed plugin_info["GTKBuilder"] = glade_file; //was: module->GetGTKBuilder(); free(descr); map_of_plugin_info[dent->d_name] = plugin_info; } free(glade_file); } closedir(dir); } void GetPluginSettings(const char *plugin_name, map_plugin_settings_t &plugin_settings) { char *conf_file = xasprintf(PLUGINS_CONF_DIR"/%s.conf", plugin_name); if (LoadPluginSettings(conf_file, plugin_settings, /*skip w/o value:*/ false)) VERB3 log("Loaded %s.conf", plugin_name); free(conf_file); }